stevenjb@: Can you comment on this?

Currently, we hide this notification once we get a "default network changed" callback which indicates that there is a non-null default network.

However, this callback is not actually invoked when the default network is in the process of connecting; it only occurs when the default networking is fully connected. I know there is logic in NetworkStateHandler which specifically does not invoke this callback during the connecting phase - why is this necessary? Is it okay if this logic is changed to invoke the callback more often?

you should not try to show any of this while any network is in the process of connecting 

Yep - if we made the change I mentioned in comment #1, this would be the case.

However, I'm not sure if this is necessarily the correct thing to do, since the code does not currently fire that event in the way we would need it to.

stevenjb@: What about listening to NetworkConnectionStateChanged() in this case?
 https://cs.chromium.org/chromium/src/chromeos/network/network_state_handler_observer.h

You can observe NetworkStateHandlerObserver::NetworkConnectionStateChanged(), then on any change call NSH::FirstNetworkByType(NetworkTypePattern::Default()) to check the state of the first network. If there is a connected or connecting network, it will always be the first network.

Sounds good - thanks, Steven!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbae375f0373c2aed4b9b1a460df608e263dae82

commit bbae375f0373c2aed4b9b1a460df608e263dae82
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Aug 23 23:23:22 2017

[CrOS Tether] Hide "enable Bluetooth" notification when connecting.

We show an "enable Bluetooth" notification under certain conditions
which alerts the user that enabling Bluetooth will enable scans for
nearby mobile devices. Previously, we would hide that notification any
time that the user is connected to a network. However, the
notification should also be hidden when the user is in the process of
connecting to a network.

Bug:  757556 , 672263
Change-Id: Ia3daa233d97c61ab1643e6e621e457687b516565
Reviewed-on: https://chromium-review.googlesource.com/629618
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496859}
[modify] https://crrev.com/bbae375f0373c2aed4b9b1a460df608e263dae82/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/bbae375f0373c2aed4b9b1a460df608e263dae82/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/bbae375f0373c2aed4b9b1a460df608e263dae82/chrome/browser/chromeos/tether/tether_service_unittest.cc

This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M61 Chrome OS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a98009ff83e7c1905f13e2caba6b73a57421c4f

commit 2a98009ff83e7c1905f13e2caba6b73a57421c4f
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 24 00:08:07 2017

[CrOS Tether] Hide "enable Bluetooth" notification when connecting.

We show an "enable Bluetooth" notification under certain conditions
which alerts the user that enabling Bluetooth will enable scans for
nearby mobile devices. Previously, we would hide that notification any
time that the user is connected to a network. However, the
notification should also be hidden when the user is in the process of
connecting to a network.

TBR=khorimoto@google.com

(cherry picked from commit bbae375f0373c2aed4b9b1a460df608e263dae82)

Bug:  757556 , 672263
Change-Id: Ia3daa233d97c61ab1643e6e621e457687b516565
Reviewed-on: https://chromium-review.googlesource.com/629618
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496859}
Reviewed-on: https://chromium-review.googlesource.com/630778
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#844}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/2a98009ff83e7c1905f13e2caba6b73a57421c4f/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/2a98009ff83e7c1905f13e2caba6b73a57421c4f/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/2a98009ff83e7c1905f13e2caba6b73a57421c4f/chrome/browser/chromeos/tether/tether_service_unittest.cc