Issue metadata
Sign in to add a comment
|
TrustStoreMacTest.SystemCerts (net_unittests) failing on chromium.mac/Mac10.12 Tests |
||||||||||||||||||||
Issue descriptionnet_unittests failing on chromium.mac/Mac10.12 Tests Builders failed on: - Mac10.12 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests Starting with revision fb0751e9764ac9f0 TrustStoreMacTest.SystemCerts has been failing. I couldn't find the culprit using the prior green build. I also reverted all the way back to the 7/1/2017 commit (both debug and release) and the test is failing there as well. Maybe it's a machine configuration issue? The error is: ../../net/cert/internal/trust_store_mac_unittest.cc:240: 1B4B396126276B6491A2686DD70243212D1F1D96 [90326:775:0821/071312.030617:30200928443291:WARNING:trust_store_mac_unittest.cc(262)] ParseCertificate::Create 4BD2BE5E0A7C7B7A154C064A0B363CB764DBBB76 failed: ERROR: Failed parsing extensions [ FAILED ] TrustStoreMacTest.SystemCerts (1254 ms) [ RUN ] TrustStoreMacTest.SystemCerts ../../net/cert/internal/trust_store_mac_unittest.cc:296: Failure Expected: expected_trust_anchor Which is: false To be equal to: is_trust_anchor Which is: true
,
Aug 22 2017
mattm@ can you take a look?
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a95d822b3a147e3121a0508251d6aab8734a631 commit 5a95d822b3a147e3121a0508251d6aab8734a631 Author: Trent Apted <tapted@chromium.org> Date: Tue Aug 22 07:59:06 2017 Disable TrustStoreMacTest.SystemCerts Fails on 10.12 since https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/4146 TBR=mattm@chromium.org Bug: 757540 Change-Id: I530f2e8c51935302da2d19d1f6a15789ce282a9c Reviewed-on: https://chromium-review.googlesource.com/625602 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#496244} [modify] https://crrev.com/5a95d822b3a147e3121a0508251d6aab8734a631/net/cert/internal/trust_store_mac_unittest.cc
,
Aug 22 2017
Removing sheriff label since this has been disabled and assigned.
,
Aug 26 2017
,
Sep 1 2017
This is failing on Beta as well. Shall we disable this on M-61 as well?
,
Sep 1 2017
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37c31877fe599c7c41f7af374105bc353dac7b14 commit 37c31877fe599c7c41f7af374105bc353dac7b14 Author: Matt Mueller <mattm@chromium.org> Date: Fri Sep 01 18:41:40 2017 Use kSecTrustOptionAllowExpired in TrustStoreMacTest.SystemCerts. Since the cert in the SecTrustEvaluate call is both the leaf and a (potential) root, the kSecTrustOptionAllowExpiredRoot was insufficient, and kSecTrustOptionAllowExpired is required. Re-enables TrustStoreMacTest.SystemCerts. Bug: 757540 Change-Id: I3f26a05ba23624218a25737cca0bb753c1e50219 Reviewed-on: https://chromium-review.googlesource.com/636754 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#499242} [modify] https://crrev.com/37c31877fe599c7c41f7af374105bc353dac7b14/net/cert/internal/trust_store_mac_unittest.cc
,
Sep 1 2017
This was a test-only issue (and the code being tested isn't currently used in the wild anyway), so you can feel free to disable the test on m-61 if you want. I don't know the procedure for that (do you need a merge request to merge the disable CL?) The test failing on multiple channels was due to the test not handling a cert expiration issue. I'll leave the bug open pending resolution of the m61 branch issue, but the test should be fixed now.
,
Sep 26 2017
The test fails only in stable channel no need of disabling in M61 since M62 will be in stable soon.
,
Sep 26 2017
Thanks, marking fixed then. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by tapted@chromium.org
, Aug 22 2017Summary: TrustStoreMacTest.SystemCerts (net_unittests) failing on chromium.mac/Mac10.12 Tests (was: net_unittests failing on chromium.mac/Mac10.12 Tests)