Clean up layout tests for idle time spell checker |
||
Issue descriptionAll layout tests related to the spellchecker functionality (not including those for marker painting only) should use idle time spellchecker, and should use spellcheck_test when possible. This should be done before cleaning up the old spellcheck code path in M63.
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0663fa47679c4ba07bbf23812ec8ac887e405ff commit e0663fa47679c4ba07bbf23812ec8ac887e405ff Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Aug 22 01:44:52 2017 Convert editing/spelling/spellcheck-input-search-crash.html with spellcheck_test This patch converts the layout test to use spellcheck_test, so that the test remains valid after we remove the non-idle-time spellcheck code path. Bug: 757525 Change-Id: Ide210895df34da5333235c0ed9260dc77878fbf3 Reviewed-on: https://chromium-review.googlesource.com/624654 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#496167} [delete] https://crrev.com/ff14fd16d5122997f5e637f342a2ab7c81c5817d/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-input-search-crash-expected.txt [modify] https://crrev.com/e0663fa47679c4ba07bbf23812ec8ac887e405ff/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-input-search-crash.html
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53c60272bb9bc7acde0c09687ca62e4d97bd3bf1 commit 53c60272bb9bc7acde0c09687ca62e4d97bd3bf1 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Aug 22 01:47:50 2017 Convert editing/spelling/right-click-no-renderer-crash.html with spellcheck_test This patch converts the layout test to use spellcheck_test, so that the test remains valid after we remove the non-idle-time spellcheck code path. Bug: 757525 Change-Id: Ibb61b0645e6dbc0dc8c501cd8015c1cd851c9080 Reviewed-on: https://chromium-review.googlesource.com/624521 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#496170} [delete] https://crrev.com/6547e4dc83851dd44acf74e88a8226235b32c2b6/third_party/WebKit/LayoutTests/editing/spelling/right-click-no-renderer-crash-expected.txt [modify] https://crrev.com/53c60272bb9bc7acde0c09687ca62e4d97bd3bf1/third_party/WebKit/LayoutTests/editing/spelling/right-click-no-renderer-crash.html
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dab1034335c0d82332e0f7572ba9781637d2e6af commit dab1034335c0d82332e0f7572ba9781637d2e6af Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Aug 22 04:11:49 2017 Force invocation of idle time spellchecker in some spellcheck crash tests This patch forces the invocation of idle time spellchecker in the following crash tests, so that they still remain valid tests after we remove the old spellcheck code paths: - editing/spelling/mark-empty-crash.html - editing/spelling/spellcheck-mixed-editable-crash.html - editing/spelling/spellcheck-mixed-editable-long-text-crash.html Bug: 757525 Change-Id: I16cd36d50046df1064be5e196e455a0fe1989b42 Reviewed-on: https://chromium-review.googlesource.com/624617 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#496209} [modify] https://crrev.com/dab1034335c0d82332e0f7572ba9781637d2e6af/third_party/WebKit/LayoutTests/editing/spelling/mark-empty-crash.html [modify] https://crrev.com/dab1034335c0d82332e0f7572ba9781637d2e6af/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-crash.html [modify] https://crrev.com/dab1034335c0d82332e0f7572ba9781637d2e6af/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-long-text-crash.html
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c54113775b40051403517d578e0b57854878787d commit c54113775b40051403517d578e0b57854878787d Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Aug 22 17:19:13 2017 Force invoking idle time spellchecker in accessibility/misspellings.html As requested by an existing TODO, this patch forces the invocation of idle time spell checker in the layout test. Bug: 757525 Change-Id: I668dd4303d3152f0d84d165bcb65124c4a3cdce0 Reviewed-on: https://chromium-review.googlesource.com/624534 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#496343} [modify] https://crrev.com/c54113775b40051403517d578e0b57854878787d/third_party/WebKit/LayoutTests/accessibility/misspellings.html
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2995c6134596571c075546ef193f727ac69535e commit f2995c6134596571c075546ef193f727ac69535e Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Aug 23 07:21:36 2017 Remove redundant test editing/spelling/spellcheck-sequencenum.html The layout test doesn't test any functionality in our product, but instead, tests the Internals testing framework. There is no need to add test for testing framework, so this CL removes it. Bug: 757525 Change-Id: I64a2a3f39df3dc9fa7d2cb3595070bb233de96d5 Reviewed-on: https://chromium-review.googlesource.com/627058 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#496610} [modify] https://crrev.com/f2995c6134596571c075546ef193f727ac69535e/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [delete] https://crrev.com/e1e8a765ee33d45ba58996e51ff088b18fab22b1/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-sequencenum-expected.txt [delete] https://crrev.com/e1e8a765ee33d45ba58996e51ff088b18fab22b1/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-sequencenum.html
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/224c043b04f82f5e06e8f3dab97f87b4d205e875 commit 224c043b04f82f5e06e8f3dab97f87b4d205e875 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Aug 23 07:22:52 2017 Convert editing/spelling/spelling-changed-text.html with spellcheck_test This patch converts the layout test to use spellcheck_test, so that the test remains valid after we remove the non-idle-time spellcheck code path. This patch also removed editing/spelling/resources/util.js since its only user is the removed test. Bug: 757525 Change-Id: I807c029711a5c63b4201c2e5c6ea2e9b7ff16382 Reviewed-on: https://chromium-review.googlesource.com/627169 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#496611} [modify] https://crrev.com/224c043b04f82f5e06e8f3dab97f87b4d205e875/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [delete] https://crrev.com/f2995c6134596571c075546ef193f727ac69535e/third_party/WebKit/LayoutTests/editing/spelling/resources/util.js [delete] https://crrev.com/f2995c6134596571c075546ef193f727ac69535e/third_party/WebKit/LayoutTests/editing/spelling/spelling-changed-text-expected.txt [modify] https://crrev.com/224c043b04f82f5e06e8f3dab97f87b4d205e875/third_party/WebKit/LayoutTests/editing/spelling/spelling-changed-text.html
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5423aa481ace901e604127daf2bcfded7f04efe0 commit 5423aa481ace901e604127daf2bcfded7f04efe0 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Aug 23 07:23:04 2017 Convert editing/spelling/spellcheck-async-remove-frame.html with spellcheck_test This patch converts the layout test to use spellcheck_test, so that the test remains valid after we remove the non-idle-time spellcheck code path. Bug: 757525 Change-Id: I15859a271baaa59e99b77a7862610a8f8b92f1b4 Reviewed-on: https://chromium-review.googlesource.com/627037 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#496612} [delete] https://crrev.com/224c043b04f82f5e06e8f3dab97f87b4d205e875/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async-remove-frame-expected.txt [modify] https://crrev.com/5423aa481ace901e604127daf2bcfded7f04efe0/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async-remove-frame.html
,
Aug 23 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by xiaoche...@chromium.org
, Aug 21 2017