New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757524 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Touch bar support for Password Bubble

Project Member Reported by spqc...@chromium.org, Aug 21 2017

Issue description

The password bubble's buttons should show up on the touch bar

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b2e991f676e12dd51c2d92ad17aa901e400a17a

commit 1b2e991f676e12dd51c2d92ad17aa901e400a17a
Author: spqchan <spqchan@chromium.org>
Date: Mon Aug 21 23:10:50 2017

[Mac] Touch Bar Support for Password Bubbles

Implement support on the touch bar for password
bubbles. Unit tests are available for
SavePendingPasswordViewControllerTest and
ManagePasswordsViewControllerTest.

Bug:  757524 
Change-Id: I162dd13b764820d0fcc876df44d509b3ff7e9bf1
Reviewed-on: https://chromium-review.googlesource.com/619688
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496110}
[modify] https://crrev.com/1b2e991f676e12dd51c2d92ad17aa901e400a17a/chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h
[modify] https://crrev.com/1b2e991f676e12dd51c2d92ad17aa901e400a17a/chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.mm
[modify] https://crrev.com/1b2e991f676e12dd51c2d92ad17aa901e400a17a/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.h
[modify] https://crrev.com/1b2e991f676e12dd51c2d92ad17aa901e400a17a/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.mm
[modify] https://crrev.com/1b2e991f676e12dd51c2d92ad17aa901e400a17a/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm
[modify] https://crrev.com/1b2e991f676e12dd51c2d92ad17aa901e400a17a/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.h
[modify] https://crrev.com/1b2e991f676e12dd51c2d92ad17aa901e400a17a/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm
[modify] https://crrev.com/1b2e991f676e12dd51c2d92ad17aa901e400a17a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.h
[modify] https://crrev.com/1b2e991f676e12dd51c2d92ad17aa901e400a17a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm
[modify] https://crrev.com/1b2e991f676e12dd51c2d92ad17aa901e400a17a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment