Keep devices cached in UI for longer |
|||||||
Issue descriptionWhile debugging, I've noticed that both Wi-Fi networks and Bluetooth devices stay cached until the next scan occurs. When a scan occurs, stale networks/devices are removed from the list at that point. If you try to connect to one of these stale networks/devices during a scan, it fails and is removed from the list. Tether networks should get the same treatment. I've found it to be a common occurrence that I log in, a scan starts, then I go do other things for a few minutes, then open the network settings, only to see that the networks are now gone after the 5-minute timeout. Since it is unlikely that people move their phones away from their laptops while in use, I think we should assume that scanned host devices stay around until we know they are gone. If we must keep a timeout, I think it should be much greater than the 5-minute timeout we have now. Maybe an hour would be better.
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3c8142db5d3731d8819a54cdda68cb58ac950d6 commit d3c8142db5d3731d8819a54cdda68cb58ac950d6 Author: Kyle Horimoto <khorimoto@google.com> Date: Mon Aug 21 22:26:51 2017 [CrOS Tether] Keep scanned host devices in the cache for longer. Previously, we would remove scanned host devices from the cache after 5 minutes. However, this value proved to be too low - I often found myself opening network settings a short while after a scan to find that the previously-scanned results were missing due to this timeout. With this CL, we change the timeout value from 5 minutes to 2 hours, which causes our UI to behave the same way that Wi-Fi and Bluetooth do: keep scan results in the UI until a scan completes and cannot find the same results. Bug: 757520 , 672263 Change-Id: If6c0e03cc478ad8949241e1f663d9c4c94745345 Reviewed-on: https://chromium-review.googlesource.com/624538 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#496087} [modify] https://crrev.com/d3c8142db5d3731d8819a54cdda68cb58ac950d6/chromeos/components/tether/master_host_scan_cache.h
,
Aug 21 2017
,
Aug 22 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 22 2017
Approving Merge to M61 Chrome OS.
,
Aug 22 2017
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee11974af9bfb9d89eb033e95f2063644c8d82ea commit ee11974af9bfb9d89eb033e95f2063644c8d82ea Author: Kyle Horimoto <khorimoto@google.com> Date: Tue Aug 22 00:17:13 2017 [CrOS Tether] Keep scanned host devices in the cache for longer. Previously, we would remove scanned host devices from the cache after 5 minutes. However, this value proved to be too low - I often found myself opening network settings a short while after a scan to find that the previously-scanned results were missing due to this timeout. With this CL, we change the timeout value from 5 minutes to 2 hours, which causes our UI to behave the same way that Wi-Fi and Bluetooth do: keep scan results in the UI until a scan completes and cannot find the same results. TBR=khorimoto@google.com (cherry picked from commit d3c8142db5d3731d8819a54cdda68cb58ac950d6) Bug: 757520 , 672263 Change-Id: If6c0e03cc478ad8949241e1f663d9c4c94745345 Reviewed-on: https://chromium-review.googlesource.com/624538 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#496087} Reviewed-on: https://chromium-review.googlesource.com/625166 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#743} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/ee11974af9bfb9d89eb033e95f2063644c8d82ea/chromeos/components/tether/master_host_scan_cache.h
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by khorimoto@chromium.org
, Aug 21 2017