New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757512 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

UKM should handle the case where Sync is in a broken state.

Project Member Reported by holte@chromium.org, Aug 21 2017 
We may want some special handling of the case where Sync is a broken state, e.g. if the user has changed their password, or they can't connect to sync, to keep UKM behavior more closely aligned to Sync's.

One possibility here would be to keep recording enabled, but disable recording, and just buffer logs until the user is able to connect to Sync.

Comment 1 by holte@chromium.org, Aug 21 2017

Components: Internals>Metrics

Comment 2 by holte@chromium.org, Sep 1 2017

Components: Internals>Metrics>UKM
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30dd3b61cd5b0d467abf38049a7847898402fbec

commit 30dd3b61cd5b0d467abf38049a7847898402fbec
Author: Steven Holte <holte@google.com>
Date: Wed Oct 11 06:58:56 2017

Move Sync Time string conversion to about_sync_util.cc

This will make it easier to use last sync time for UKM logic.

Bug:  757512 
Change-Id: Ic41b28017032cac02cf767595fee4b42af7fe2ee
Reviewed-on: https://chromium-review.googlesource.com/700976
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507914}
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/browser_sync/BUILD.gn
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/browser_sync/DEPS
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/browser_sync/profile_sync_service_mock.h
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/sync/BUILD.gn
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/sync/DEPS
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/sync/driver/about_sync_util.cc
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/sync/driver/about_sync_util_unittest.cc
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/sync/driver/fake_sync_service.cc
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/sync/driver/fake_sync_service.h
[modify] https://crrev.com/30dd3b61cd5b0d467abf38049a7847898402fbec/components/sync/driver/sync_service.h

Comment 4 by holte@chromium.org, Apr 27 2018

Status: Fixed (was: Untriaged)
This was fixed off a different bug.
►

Sign in to add a comment