New issue
Advanced search Search tips

Issue 757511 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 678687



Sign in to add a comment

mash: Add very simple test of Chrome OS login to main waterfall

Project Member Reported by jamescook@chromium.org, Aug 21 2017

Issue description

Right now login failures for chrome --mash are caught on the Chrome OS waterfall as hardware test failures. That's good, but it would be much cheaper if we caught them on the chrome waterfall.

mash_browser_tests are still being worked on, but we might be able to get the suite stable if it ran a single, simple test. So let's try that.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d77ea863f18e0cb14e77d609cf660b01d78efbc

commit 3d77ea863f18e0cb14e77d609cf660b01d78efbc
Author: James Cook <jamescook@chromium.org>
Date: Mon Aug 21 20:37:08 2017

mash: Add simple browser test for mash login

This exercises similar code paths to the desktopui_MashLogin autotest
on the Chrome OS waterfall. It should help us catch regressions earlier.

Bug:  757511 
Test: browser_tests --run-in-mash --gtest_filter="LoginUtilsTest.MashLogin"
Change-Id: I26424cb7359a8e69d9eadabec11bc2f4f068f8e5
Reviewed-on: https://chromium-review.googlesource.com/624191
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496051}
[modify] https://crrev.com/3d77ea863f18e0cb14e77d609cf660b01d78efbc/chrome/browser/chromeos/login/login_utils_browsertest.cc
[modify] https://crrev.com/3d77ea863f18e0cb14e77d609cf660b01d78efbc/testing/buildbot/filters/mojo.fyi.single.mash.browser_tests.filter

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78aa35abb4becac72b44437f811f826406e27b25

commit 78aa35abb4becac72b44437f811f826406e27b25
Author: Jonathan <jonross@chromium.org>
Date: Thu Aug 24 14:55:17 2017

Enable single_mash_browser_tests on CQ

An individual test from mash_browser_tests was encompassed within the single_mash_browser_tests configuration, and ran on the Mojo FYI bots. This test has passed 120 straight runs.

Since there is no apparent flake, nor the deadlock seen in the core mash_browser_tests I plan to enable this on the Linux ChromiumOS bot.

TEST= single_mash_browser_tests

Bug:  757511 
Change-Id: Ie45afbc133eb076fa8580e5661d70f7d31a443a7
Reviewed-on: https://chromium-review.googlesource.com/630936
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497046}
[modify] https://crrev.com/78aa35abb4becac72b44437f811f826406e27b25/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/78aa35abb4becac72b44437f811f826406e27b25/testing/buildbot/filters/BUILD.gn
[add] https://crrev.com/78aa35abb4becac72b44437f811f826406e27b25/testing/buildbot/filters/single.mash.browser_tests.filter

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment