Create new test runner chromium_python_tests similar to webkit_python_tests |
|||
Issue descriptionCreate new test running chromium_python_tests similar to webkit_python_tests. We have a bunch of Python code in Chromium with unit tests that are currently not run on the bots. This will add bot coverage for them. See thread for discussion: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/f3Tnh7SoZws
,
Aug 21 2017
Some tests that should be part of this: tools/metrics/actions/extract_actions_test.py tools/metrics/histograms/generate_expired_histograms_array_unittest.py tools/metrics/rappor/pretty_print_test.py tools/metrics/ukm/pretty_print_test.py tools/variations/fieldtrial_to_struct_unittest.py tools/variations/fieldtrial_util_unittest.py Those are the metrics ones at least. There's probably a ton more within Chromium that can also be added - such as GRIT. But my initial motivation would be to have the metrics ones be covered - which should be enough to set up the infrastructure - and then other tests could be added by people when desired.
,
Aug 21 2017
Per Jochen's reply on the chromium-dev@ thread, we shouldn't follow webkit_python_tests ' example, since that's not isolated. content_shell_crash_test.py might be a better case.
,
Sep 25 2017
webkit_python_tests are isolated now, actually :). We should indeed follow their lead.
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1 commit ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1 Author: Alexei Svitkine <asvitkine@chromium.org> Date: Fri Oct 06 13:46:30 2017 Add metrics_python_tests runner and run it on the bots. Also contains a couple of fixes for the tests included in the new runner so that they pass properly when invoked in this new way. Bug: 757504 Change-Id: If2d5045f67f416ac0dd902833d5e5d16029f3105 Reviewed-on: https://chromium-review.googlesource.com/701499 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#507047} [modify] https://crrev.com/ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1/testing/buildbot/chromium.linux.json [modify] https://crrev.com/ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1/testing/buildbot/chromium.mac.json [modify] https://crrev.com/ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1/testing/buildbot/chromium.win.json [modify] https://crrev.com/ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1/tools/json_comment_eater/json_comment_eater_test.py [modify] https://crrev.com/ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1/tools/metrics/BUILD.gn [modify] https://crrev.com/ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1/tools/metrics/actions/extract_actions.py [add] https://crrev.com/ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1/tools/metrics/metrics_python_tests.py [modify] https://crrev.com/ac3352b67eb7985bddb70f99f12c84ddfdb6c6c1/tools/variations/fieldtrial_to_struct_unittest.py
,
Oct 6 2017
Looks like this is running on the waterfall now: e.g. https://chromium-swarm.appspot.com/task?id=390b0ddf7b0d6110&refresh=10&show_raw=1 https://build.chromium.org/p/chromium.win/waterfall?builder=Win%20Builder |
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted