New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757498 link

Starred by 1 user
Status: Fixed
Owner:
hidehiko@chromium.org
Closed: Sep 2017
Cc:
█ lhchavez@chromium.org
yusukes@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

dcheck triggered on device

Project Member Reported by penghuang@chromium.org, Aug 21 2017 
A dcheck will be triggered on device if chrome is built and deployed with dcheck_always_on = true. See below stack trace.

[23598:23598:0821/131506.264498:FATAL:arc_session_manager.cc(970)] Check failed: arc_session_runner_->IsStopped().
#0 0x57275f3f5b0c base::debug::StackTrace::StackTrace()
#1 0x57275f410bee logging::LogMessage::~LogMessage()
#2 0x57275e053780 arc::ArcSessionManager::MaybeStartArcDataRemoval()
#3 0x57275e054608 arc::ArcSessionManager::Initialize()
#4 0x57275e0515af arc::ArcServiceLauncher::OnPrimaryUserProfilePrepared()
#5 0x57275e1dbefc chromeos::UserSessionManager::FinalizePrepareProfile()
#6 0x57275d043aca _ZN4base8internal7InvokerINS0_9BindStateIMN5media12PipelineImpl15RendererWrapperEFvPNS3_13DemuxerStreamEEJNS_7WeakPtrIS5_EES7_EEEFvvEE3RunEPNS0_13BindStateBaseE
#7 0x57275f3f631a base::debug::TaskAnnotator::RunTask()
#8 0x57275f418975 base::MessageLoop::RunTask()
#9 0x57275f4190fd base::MessageLoop::DoWork()
#10 0x57275f41ba99 base::MessagePumpLibevent::Run()
#11 0x57275f4183be base::MessageLoop::Run()
#12 0x57275f4466f7 base::RunLoop::Run()
#13 0x57275efe3667 ChromeBrowserMainParts::MainMessageLoopRun()
#14 0x57275d7017c4 <unknown>
#15 0x57275d7045e3 <unknown>
#16 0x57275d6fccdc <unknown>
#17 0x57275efaec7f <unknown>
#18 0x57275efaf58e <unknown>
#19 0x57275efd7b0d service_manager::Main()
#20 0x57275efae321 <unknown>
#21 0x57275ce28a55 ChromeMain
#22 0x797c3a0cc736 __libc_start_main
#23 0x57275ce28839 _start

Received signal 6
#0 0x57275f3f5b0c base::debug::StackTrace::StackTrace()
#1 0x57275f3f55d1 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x797c3b4762e0 <unknown>
#3 0x797c3a0dfdd2 gsignal
#4 0x797c3a0e1bf6 abort
#5 0x57275f3f40f5 base::debug::BreakDebugger()
#6 0x57275f410fdb logging::LogMessage::~LogMessage()
#7 0x57275e053780 arc::ArcSessionManager::MaybeStartArcDataRemoval()
#8 0x57275e054608 arc::ArcSessionManager::Initialize()
#9 0x57275e0515af arc::ArcServiceLauncher::OnPrimaryUserProfilePrepared()
#10 0x57275e1dbefc chromeos::UserSessionManager::FinalizePrepareProfile()

Comment 1 by lhchavez@chromium.org, Aug 21 2017

Cc: yusukes@chromium.org
Owner: hidehiko@chromium.org
Status: Assigned (was: Untriaged)
Few questions:

* Does this happen consistently?
* Does this happen just after initial sign-in or during every sign-in?
* Anything else we should know about the timing of this DCHECK?

Comment 2 by penghuang@chromium.org, Aug 21 2017 

It always happens just after sign-in for me.

Comment 3 by hidehiko@chromium.org, Aug 23 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/586a77465888ef6827f950814c80d82da4d2d8f2

commit 586a77465888ef6827f950814c80d82da4d2d8f2
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Aug 24 02:45:34 2017

Fix DCHECK error.

Because the mini container can be starting before login,
when ArcSessionManager is initialized, ArcSessionRunner::IsStopped()
may return false.
As it is OK to remove the data while mini container is running,
fix DCHECK condition not to fail.

BUG= chromium:757498 
TEST=Ran locally. Ran bots.

Change-Id: I8a988b7e87d9035bb1475e4b809135c745049f51
Reviewed-on: https://chromium-review.googlesource.com/627945
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496929}
[modify] https://crrev.com/586a77465888ef6827f950814c80d82da4d2d8f2/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/586a77465888ef6827f950814c80d82da4d2d8f2/components/arc/arc_session_runner.cc
[modify] https://crrev.com/586a77465888ef6827f950814c80d82da4d2d8f2/components/arc/arc_session_runner.h

Comment 5 by hidehiko@chromium.org, Aug 25 2017

Status: Fixed (was: Started)

Comment 6 by yusukes@chromium.org, Aug 25 2017 

thanks!

Comment 7 by penghuang@chromium.org, Aug 25 2017 

I tried Tot. It has a new dcheck crash, when an ARC app icon is clicked.

[8958:8958:0825/105149.767582:FATAL:arc_app_deferred_launcher_controller.cc(195)] Check failed: arc_session_manager->state() != arc::ArcSessionManager::State::STOPPED (STOPPED vs. STOPPED)
#0 0x594b0cfe8f2c base::debug::StackTrace::StackTrace()
#1 0x594b0d00400e logging::LogMessage::~LogMessage()
#2 0x594b0f7562b9 ArcAppDeferredLauncherController::RegisterDeferredLaunch()
#3 0x594b0f74d30b <unknown>
#4 0x594b0f74ce81 <unknown>
#5 0x594b0f6772ac LauncherControllerHelper::LaunchApp()
#6 0x594b0f840a50 AppShortcutLauncherItemController::ItemSelected()
#7 0x594b0f47478d ash::ShelfView::ButtonPressed()
#8 0x594b0e902f24 views::Button::OnMouseReleased()
#9 0x594b0f4da74e ash::ShelfButton::OnMouseReleased()
#10 0x594b0e95a2ac views::InkDropHostView::OnMouseEvent()
#11 0x594b10ba42a2 ui::ScopedTargetHandler::OnEvent()
#12 0x594b0db317eb ui::EventDispatcher::ProcessEvent()
#13 0x594b0db3162c ui::EventDispatcherDelegate::DispatchEvent()
#14 0x594b0e976f76 views::internal::RootView::OnMouseReleased()
#15 0x594b0e9480b6 views::Widget::OnMouseEvent()
#16 0x594b0e95443c views::NativeWidgetAura::OnMouseEvent()
#17 0x594b0db317eb ui::EventDispatcher::ProcessEvent()
#18 0x594b0db3162c ui::EventDispatcherDelegate::DispatchEvent()
#19 0x594b10ba404e ui::EventProcessor::OnEventFromSource()
#20 0x594b0db324dd ui::EventSource::SendEventToSink()
#21 0x594b0f3b269d ash::AshWindowTreeHostPlatform::DispatchEvent()
#22 0x594b0db33d6d ui::DispatchEventFromNativeUiEvent()
#23 0x594b0ab986f7 ui::DrmWindowHost::DispatchEvent()
#24 0x594b0ab987cd ui::DrmWindowHost::DispatchEvent()
#25 0x594b0d70f7b6 ui::PlatformEventSource::DispatchEvent()
#26 0x594b0de12a22 ui::EventFactoryEvdev::DispatchMouseButtonEvent()
#27 0x594b0de15a20 _ZN4base8internal7InvokerINS0_9BindStateIMN2ui17EventFactoryEvdevEFvRKNS3_16TouchEventParamsEEJNS_7WeakPtrIS4_EES5_EEEFvvEE3RunEPNS0_13BindStateBaseE
#28 0x594b0cfe973a base::debug::TaskAnnotator::RunTask()
#29 0x594b0d00bd95 base::MessageLoop::RunTask()
#30 0x594b0d00c51d base::MessageLoop::DoWork()
#31 0x594b0d00eeb9 base::MessagePumpLibevent::Run()
#32 0x594b0d00b7de base::MessageLoop::Run()
#33 0x594b0d039b77 base::RunLoop::Run()
#34 0x594b0cbe7b47 ChromeBrowserMainParts::MainMessageLoopRun()
#35 0x594b0b2f6be4 <unknown>
#36 0x594b0b2f9a03 <unknown>
#37 0x594b0b2f20fc <unknown>
#38 0x594b0cbb30cf <unknown>
#39 0x594b0cbb3abe <unknown>
#40 0x594b0cbdbfed service_manager::Main()
#41 0x594b0cbb2771 <unknown>
#42 0x594b0aa06b95 ChromeMain
#43 0x79b695899736 __libc_start_main
#44 0x594b0aa06979 _start

Comment 8 by yusukes@chromium.org, Sep 8 2017

Status: Assigned (was: Fixed)
Hidehiko, can you check if comment#7 is still happening?

Comment 9 by hidehiko@chromium.org, Sep 11 2017

Status: Fixed (was: Assigned)
Marked back to Fixed because the new stack trace looks much different from original one.

Re #8: I couldn't reproduce it locally (caroline).
penghuang@, if you still hit it, could you file another bug with more detailed repro steps and repro environments?

Comment 10 by penghuang@chromium.org, Sep 11 2017 

I didn't see this problem recently. I will open a new bug, if it happens again.

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 12 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment