New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757488 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Deduplicate SimpleDateFormat

Project Member Reported by kmilka@google.com, Aug 21 2017

Issue description

The same SimpleDateFormat is used several places through the codebase:
https://cs.chromium.org/search/?q=%22EEE,+dd+MMM+yyyy+HH:mm:ss+z%22+package:%5Echromium$&type=cs

All these locations should instead use the same variable.
 

Comment 1 by kmilka@google.com, Aug 21 2017

Cc: kmilka@google.com
Oh lol, I didn't realize most of the places referred to in your URL there are from third_party/foo/ so we won't be able to change those. How do we know that this is the correct format for our purposes?

Comment 3 by kmilka@google.com, Aug 21 2017

It's the format of the time in the HTTP header of the response from the server. See, https://golang.org/pkg/net/http/#pkg-constants.

Comment 4 by kmilka@chromium.org, May 26 2018

Cc: -kmilka@google.com

Sign in to add a comment