New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757470 link

Starred by 1 user
Status: WontFix
Owner:
mlippautz@chromium.org
Closed: Aug 2017
Cc:
█ zpeng@chromium.org
haraken@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

60KB regression in resource_sizes (MonochromePublic.apk) at 495810:495810

Project Member Reported by zpeng@chromium.org, Aug 21 2017 
Caused by [wrapper-tracing] Enable use of mixins for values

Commit: ac528b27b356ecddcf4c400c7de996eefd7f8e38

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=495810

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

The increase consists of 61KB native code.

It's not clear to me whether or not this increase was expected.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 21 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=757470

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0fe48f02fbe670d29ea9908fb9d91240efda869fb0c60090f8b71b8871a0b57d


Bot(s) for this bug's original alert(s):

Android Builder

Comment 2 by mlippautz@chromium.org, Aug 21 2017

Cc: haraken@chromium.org
Status: WontFix (was: Assigned)
The increase is expected.

Reason: We are adding 1 virtual call back to a sizable amount of objects from which we removed 4 virtual calls a few months ago [1]. It's still better than initially, just not as good anymore.

[1] https://codereview.chromium.org/2595053002/
►

Sign in to add a comment