New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757464 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Shadow is visible on the NTP bottom toolbar when the content is too short

Project Member Reported by gambard@chromium.org, Aug 21 2017 
With ContentSuggestions enabled.
iPhone only.

What steps will reproduce the problem?
(1) Disable the suggestions: settings -> privacy -> search and site suggestions
(2) Open a NTP

What is the expected result?
The shadow on the bottom toolbar should only be displayed when there is content below it.

What happens instead?
The shadow is displayed until the NTP is fully scrolled.
Simulator Screen Shot Aug 21, 2017, 5.46.42 PM.png
264 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e3caf09bc1a41c6fbae43a18e0356db1cd7d487

commit 0e3caf09bc1a41c6fbae43a18e0356db1cd7d487
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Aug 24 11:19:16 2017

Fix the toolbar shadow for ContentSuggestions

The bottom toolbar displayed on ContentSuggestions have a shadow if the
content of the collection is displayed below the toolbar.
On iPhone, in order to allow the user to scroll, the content of the
collection is extended to be able to scroll the fake omnibox to the top
of the collection. So collection.contentSize cannot be used directly.

Bug:  757464 
Change-Id: Ia8a6bc8d32d38a9461b591e335cc42c99a05f728
Reviewed-on: https://chromium-review.googlesource.com/628880
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497005}
[modify] https://crrev.com/0e3caf09bc1a41c6fbae43a18e0356db1cd7d487/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

Comment 2 by gambard@chromium.org, Aug 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment