Issue metadata
Sign in to add a comment
|
Borders of wide table is not rendered
Reported by
shiba200...@gmail.com,
Aug 21 2017
|
||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3188.4 Safari/537.36
Example URL:
Steps to reproduce the problem:
Render HTML below
```
<!doctype html>
<title></title>
<style>
table {
border-collapse: collapse;
width: 10000px;
}
td {
border: 10px solid black;
background:red;
height: 10px;
}
</style>
<table><tr>
<td></td><td></td><td></td><td></td>
<td></td><td></td><td></td><td></td>
<td></td><td></td><td></td><td></td>
<td></td><td></td><td></td><td></td>
</tr></table>
```
What is the expected behavior?
All table cells should have borders.
What went wrong?
Borders of some cells are not rendered.
In 1000x80 screen size, only 9 (of 16) cells are rendered correctly.
https://gyazo.com/743a72777f91bf28f10b0f6827b98eb1
Does it occur on multiple sites: N/A
Is it a problem with a plugin? No
Did this work before? N/A
Does this work in other browsers? Yes
Chrome version: 62.0.3188.4 Channel: dev
OS Version: 10.0
Flash Version:
Borders seem to be rendered correctly in <iframe> (so I could not use jsfiddle to reproduce this problem)
,
Aug 22 2017
,
Aug 22 2017
URGENT - PTAL. M61 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Know that this issue shouldn't block the release? Remove the ReleaseBlock-Stable label or move to M62. Thank you! Note: We will only have 2 beta releases before Stable promotion. Plan is to cut M61 Stable RC on 08/31/17.
,
Aug 22 2017
Fix is here: https://chromium-review.googlesource.com/627177. Will land and merge it soon.
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70176d2a327c7442145350d32eaab4277e98e4fd commit 70176d2a327c7442145350d32eaab4277e98e4fd Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Aug 23 17:42:54 2017 Repaint partially painted table row collapsed borders when cull rect changes We had a mechanism to repaint a large display item clipped by paint cull rect when cull rect changes, and used that mechanism for table section/row backgrounds. Now also use the mechanism for collapsed borders which are painted by table rows. BUG= 757457 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I641e82eec9aae477498e8daf1a5944b9d3f43201 Reviewed-on: https://chromium-review.googlesource.com/627177 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#496727} [add] https://crrev.com/70176d2a327c7442145350d32eaab4277e98e4fd/third_party/WebKit/LayoutTests/paint/tables/huge-table-composited-scroll-collapsed-borders-expected.html [add] https://crrev.com/70176d2a327c7442145350d32eaab4277e98e4fd/third_party/WebKit/LayoutTests/paint/tables/huge-table-composited-scroll-collapsed-borders.html [modify] https://crrev.com/70176d2a327c7442145350d32eaab4277e98e4fd/third_party/WebKit/Source/core/paint/TableRowPainter.cpp [modify] https://crrev.com/70176d2a327c7442145350d32eaab4277e98e4fd/third_party/WebKit/Source/core/paint/TableRowPainter.h
,
Aug 23 2017
,
Aug 23 2017
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 24 2017
Before we approve merge to M61, please answer followings: * Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M61? (CL at #6 landed 8 hrs back so not in canary yet) * Any other important details to justify the merge. Please note We're only 12 days away from M61 Stable promotion, so merge bar is VERY high.
,
Aug 24 2017
Answers to the questions: - I will wait for another 1 to 2 days for the change to be well baked/verified before merge. - The change let collapsed borders use the same mechanism that has been used for backgrounds since r461907 (5 months ago), so it's safe. - We should merge the change because it fixes a rendering regression of wide tables in M61.
,
Aug 24 2017
Thank you wangxianzhu@. Please update the bug with Canary result on Monday (08/28).
,
Aug 25 2017
Rechecked this issue on Chrome version 62.0.3196.0 on Windows 10, Mac 10.12.6, Ubuntu 14.04. Fix is working as intended. Adding TE-Verified labels for M62. Thanks.!
,
Aug 28 2017
,
Aug 28 2017
The NextAction date has arrived: 2017-08-28
,
Aug 28 2017
wangxianzhu@, how is the change looking so far in Canary?
,
Aug 28 2017
It looks good in Canary.
,
Aug 28 2017
Approving merge to M61 branch 3163 based on comments #10, #12 and #16. Please merge ASAP. Thank you.
,
Aug 28 2017
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/816668a9652ce7ccc1ed81abc7a8644455834e33 commit 816668a9652ce7ccc1ed81abc7a8644455834e33 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Aug 28 16:57:28 2017 Repaint partially painted table row collapsed borders when cull rect changes We had a mechanism to repaint a large display item clipped by paint cull rect when cull rect changes, and used that mechanism for table section/row backgrounds. Now also use the mechanism for collapsed borders which are painted by table rows. BUG= 757457 TBR=wangxianzhu@chromium.org (cherry picked from commit 70176d2a327c7442145350d32eaab4277e98e4fd) Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I641e82eec9aae477498e8daf1a5944b9d3f43201 Reviewed-on: https://chromium-review.googlesource.com/627177 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#496727} Reviewed-on: https://chromium-review.googlesource.com/638558 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#928} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [add] https://crrev.com/816668a9652ce7ccc1ed81abc7a8644455834e33/third_party/WebKit/LayoutTests/paint/tables/huge-table-composited-scroll-collapsed-borders-expected.html [add] https://crrev.com/816668a9652ce7ccc1ed81abc7a8644455834e33/third_party/WebKit/LayoutTests/paint/tables/huge-table-composited-scroll-collapsed-borders.html [modify] https://crrev.com/816668a9652ce7ccc1ed81abc7a8644455834e33/third_party/WebKit/Source/core/paint/TableRowPainter.cpp [modify] https://crrev.com/816668a9652ce7ccc1ed81abc7a8644455834e33/third_party/WebKit/Source/core/paint/TableRowPainter.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Aug 22 2017Components: Blink>Paint
Labels: -Pri-2 -Type-Compat hasbisect-per-revision ReleaseBlock-Stable M-61 Needs-Triage-M62 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)