New issue
Advanced search Search tips

Issue 757454 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature

Blocking:
issue 690166



Sign in to add a comment

Third party blocking needs a developer opt-out

Project Member Reported by chrisha@chromium.org, Aug 21 2017

Issue description

To allow A11Y developers to work there needs to be a third-party code blocking opt-out mechanism.

Proposal:
A feature flag, that when in use causes a warning to appear (much like --no-sandbox).
We could even consider making this flag a protected setting, to prevent easy tampering.
 
Status: Started (was: Assigned)
Making this a simple command-line flag for now, and adding it to the bad flag list so that a large warning appears when it is enabled.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63be0473919f1b16fb931c1f4d0a33dfaba1d397

commit 63be0473919f1b16fb931c1f4d0a33dfaba1d397
Author: Chris Hamilton <chrisha@chromium.org>
Date: Fri Nov 10 01:20:59 2017

Create a flag for allowing third party module injection.

This creates the "allow-third-party-modules" flag, and plumbs it into the sandbox to disable the BINARY_SIGNATURE process mitigation when specified. It also adds this flag to the list of bad flags. In the future this CL will also be integrated with the third party blocking logic in chrome_elf.

BUG=757454

Change-Id: I38199c295d4957795ff9c1302889115af5a8222a
Reviewed-on: https://chromium-review.googlesource.com/751298
Reviewed-by: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515400}
[modify] https://crrev.com/63be0473919f1b16fb931c1f4d0a33dfaba1d397/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/63be0473919f1b16fb931c1f4d0a33dfaba1d397/services/service_manager/sandbox/switches.cc
[modify] https://crrev.com/63be0473919f1b16fb931c1f4d0a33dfaba1d397/services/service_manager/sandbox/switches.h
[modify] https://crrev.com/63be0473919f1b16fb931c1f4d0a33dfaba1d397/services/service_manager/sandbox/win/sandbox_win.cc

Sign in to add a comment