New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757450 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Stylesheet not created for non-matching media types

Reported by r...@opera.com, Aug 21 2017

Issue description

Blink does not create a stylesheet for style elements when the media type is not matching screen or print. Gecko does. It looks like the spec[1] says that "update a style block" and "create a css style sheet" should be run for all media queries.

[1] https://html.spec.whatwg.org/multipage/semantics.html#the-style-element

 
media.html
202 bytes View Download
Labels: Hotlist-Interop Update-Quarterly
Owner: shanmug...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbe78d23e79476b05503d6fe028b83addfc45d6e

commit cbe78d23e79476b05503d6fe028b83addfc45d6e
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Tue Aug 29 12:48:36 2017

Changing <style> element's media attribute should reflect is CSS.

CSSStyleSheet is not created for style elements when the media type 
is not matching screen or print earlier.
With this change, it will create style sheet for all media types.

Bug:  756804 ,  759420 ,  757450 
Change-Id: I8c38f2daf6d70b749a0f8de394d646f755695d02
Reviewed-on: https://chromium-review.googlesource.com/631859
Reviewed-by: Rune Lillesveen <rune@opera.com>
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#498083}
[add] https://crrev.com/cbe78d23e79476b05503d6fe028b83addfc45d6e/third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/the-style-element/style_media_change.html
[add] https://crrev.com/cbe78d23e79476b05503d6fe028b83addfc45d6e/third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/the-style-element/style_non_matching_media.html
[modify] https://crrev.com/cbe78d23e79476b05503d6fe028b83addfc45d6e/third_party/WebKit/Source/core/dom/StyleElement.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment