Remove the media controls resources from content and load them directly in Blink.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3255bf706d4b958b9ac13515faef6270f7ae4f37 commit 3255bf706d4b958b9ac13515faef6270f7ae4f37 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Oct 02 10:27:01 2017 Media Controls: Load CSS directly in Blink Now that MediaControlsPainter has been removed, we should move resource loading for media controls to the media_controls module in Blink. BUG= 757445 Change-Id: Ic756e6dd0cf06109b7bae1f62dddd0e02c5dfb06 Reviewed-on: https://chromium-review.googlesource.com/628171 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#505569} [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/content/child/blink_platform_impl.cc [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/content/test/DEPS [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/content/test/test_content_client.cc [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/content/test/test_content_client.h [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/media/controls/lazy-loaded-style.html [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.h [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/core/layout/LayoutTheme.cpp [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/core/layout/LayoutTheme.h [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/core/layout/LayoutThemeMobile.h [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/modules/media_controls/BUILD.gn [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/modules/media_controls/DEPS [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.cpp [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.h [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/platform/heap/BUILD.gn [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/platform/media/BUILD.gn [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/platform/media/DEPS [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/platform/media/ResourceBundleHelper.cpp [add] https://crrev.com/3255bf706d4b958b9ac13515faef6270f7ae4f37/third_party/WebKit/Source/platform/media/ResourceBundleHelper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea1396c5a014fec9738aa6cbd4c0852e1961a799 commit ea1396c5a014fec9738aa6cbd4c0852e1961a799 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Oct 02 12:33:21 2017 Revert "Media Controls: Load CSS directly in Blink" This reverts commit 3255bf706d4b958b9ac13515faef6270f7ae4f37. Reason for revert: This is causing Windows Blink failures so I am going to pull it for now. Original change's description: > Media Controls: Load CSS directly in Blink > > Now that MediaControlsPainter has been removed, we should move > resource loading for media controls to the media_controls > module in Blink. > > BUG= 757445 > > Change-Id: Ic756e6dd0cf06109b7bae1f62dddd0e02c5dfb06 > Reviewed-on: https://chromium-review.googlesource.com/628171 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505569} TBR=haraken@chromium.org,mlamouri@chromium.org,jochen@chromium.org,beccahughes@chromium.org Change-Id: Iea81e898937329d3ee3afa0c384581e93550d3c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 757445 Reviewed-on: https://chromium-review.googlesource.com/695521 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#505589} [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/content/child/blink_platform_impl.cc [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/content/test/DEPS [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/content/test/test_content_client.cc [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/content/test/test_content_client.h [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/media/controls/lazy-loaded-style.html [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.png [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.png [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.png [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.h [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/core/layout/LayoutTheme.cpp [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/core/layout/LayoutTheme.h [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/core/layout/LayoutThemeMobile.h [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/modules/media_controls/BUILD.gn [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/modules/media_controls/DEPS [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.cpp [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.h [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/platform/heap/BUILD.gn [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/Source/platform/media/BUILD.gn [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/Source/platform/media/DEPS [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/Source/platform/media/ResourceBundleHelper.cpp [delete] https://crrev.com/7af36895aed21beb249c10ea8dfd8f2c62e02539/third_party/WebKit/Source/platform/media/ResourceBundleHelper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b0c080b0bb28d3d8616d863f0302053dd1dbf42 commit 3b0c080b0bb28d3d8616d863f0302053dd1dbf42 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Oct 03 08:42:02 2017 Reland "Media Controls: Load CSS directly in Blink" This is a reland of 3255bf706d4b958b9ac13515faef6270f7ae4f37 Original change's description: > Media Controls: Load CSS directly in Blink > > Now that MediaControlsPainter has been removed, we should move > resource loading for media controls to the media_controls > module in Blink. > > BUG= 757445 > > Change-Id: Ic756e6dd0cf06109b7bae1f62dddd0e02c5dfb06 > Reviewed-on: https://chromium-review.googlesource.com/628171 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505569} TBR=haraken@chromium.org,mlamouri@chromium.org,jochen@chromium.org,beccahughes@chromium.org Bug: 757445 Change-Id: If0fe56bb489cfd0b1e1b27c7da304bf75dc23be7 Reviewed-on: https://chromium-review.googlesource.com/695328 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#505985} [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/content/child/blink_platform_impl.cc [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/content/test/DEPS [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/content/test/test_content_client.cc [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/content/test/test_content_client.h [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/media/controls/lazy-loaded-style.html [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.h [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/core/layout/LayoutTheme.cpp [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/core/layout/LayoutTheme.h [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/core/layout/LayoutThemeMobile.h [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/modules/media_controls/BUILD.gn [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/modules/media_controls/DEPS [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.cpp [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.h [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/platform/heap/BUILD.gn [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/platform/media/BUILD.gn [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/platform/media/DEPS [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/platform/media/ResourceBundleHelper.cpp [add] https://crrev.com/3b0c080b0bb28d3d8616d863f0302053dd1dbf42/third_party/WebKit/Source/platform/media/ResourceBundleHelper.h
Comment 1 by beccahughes@chromium.org
, Aug 29 2017