New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757444 link

Starred by 4 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 756556



Sign in to add a comment

Deleting the currently-active profile should not open one of the other pre-existing profiles

Project Member Reported by tnagel@chromium.org, Aug 21 2017

Issue description

Chrome Version: 62.0.3188.2 (Official Build) dev (64-bit)
OS: Linux, probably applies to all desktop

What steps will reproduce the problem?
(1) Start with fresh user data dir
(2) Create a second profile
(3) Close all windows of the second profile
(4) Delete the first profile

What is the expected result?
The profile picker should be shown.

What happens instead?
The second profile is opened. This is problematic from a privacy perspective because the 2nd profile may contain data that belongs to a different user and the current user might not want to be exposed to it.
 

Comment 1 by tnagel@chromium.org, Aug 21 2017

Cc: zmin@chromium.org
Components: Enterprise
Adding zmin and Enterprise component because this affects the ForceBrowserSignin policy. (In that case, the user is presented with a sign-in prompt but it is unclear into which profile they are signing in.)
Cc: blumberg@chromium.org kkaluri@chromium.org ligim...@chromium.org
Labels: Needs-Bisect Needs-Triage-M62
Labels: Needs-Feedback
Tested this issue on Skytap env with Win2k12 as server and Win7 as Client

Preconditions :
1. Enabled user data directory policy.
2. Enabled force sign in policy

Steps followed :
1. Launch chrome in client machine
2. Sign into two profiles 
3. Close 2nd profile windows 
4. From 1st profile window, click on manage people
5. delete 1st profile.

Observations:
-------------
After closing 1st profile window, immediately 2nd profile window is opened.

Attaching the screen-cast for reference.

 
tnagel@ could you confirm this is the issue you are experiencing ? or did i missed anything while reproducing the scenario.

Thank You... 
757444.mp4
1.6 MB View Download

Comment 4 by tnagel@chromium.org, Aug 25 2017

Yes, that's the problem. (Setting policy is not a precondition for it, though.)
Owner: blumberg@chromium.org
Assigned to Matt for prioritization.
Labels: Enterprice-Triaged
Labels: -Enterprice-Triaged Enterprise-Triaged
Cc: pa...@yandex-team.ru
Labels: -Type-Bug -Pri-2 -Needs-Feedback -Needs-Bisect hasbisect-per-revision Pri-1 Type-Bug-Regression
Owner: bauerb@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.6 with chrome #60.0.3112.113, canary #63.0.3206.0
Issue broken in M57.

Bisect Info:
===========
Good build :  57.0.2929.0,  Revision Range - 434071
Bad build  :  57.0.2934.0,  Revision Range - 434580

After executing the per-revision bisect script, i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/56f03f53c9dd7cd2977b6e06dd724f07187124a7..198d711e1e047b20d235c430a697f1b39a651b08

The suspecting Change Log is :
-----------
https://codereview.chromium.org/2519953004

Note:
======
1. In mac machine, issue exists in earlier M50 builds.
2. Since the author is not available in owner's list, assigning it to the one of reviewers for further triage

bauerb@- Could you please help us to reassign this issue to the right owner.

Components: UI>SignIn

Comment 10 by ew...@chromium.org, Nov 10 2017

Labels: -Pri-1 Pri-2
This doesn't feel like a P1 issue. You can always open another user's profile by just going to the user manager and selecting the other profile. Profiles don't provide any guarantee of privacy or security from other users on the same machine.

I'm demoting to P2.
Cc: ew...@chromium.org
Elias: It's a difference whether a user actively needs to seeks out private data of another user or whether the user is inadvertently presented with private data of another user. I don't mind whether this is P1 or P2 as long as it will be fixed. Given that this has regressed almost a year ago, I don't think that pursuing a fix *now* could be considered undue haste.

Bernhard, make I kindly ask you to chime in on this?

Comment 12 by ew...@chromium.org, Dec 12 2017

Cc: bauerb@chromium.org
Components: -UI>SignIn -Enterprise
Owner: ----
Status: Available (was: Assigned)
Re "actively" seeking out vs. "inadvertently presented": even if we change the behavior such that the user manager is presented upon profile deletion, the user would be looking at the user manager screen which just contains the second profile, and it would be one click away from opening that profile. I would not consider that "actively" seeking it out; it's right there in front of you.

Either way, I don't think Bernhard is the right owner, since this is really a profiles thing. The sign-in team is extremely bandwidth constrained, as we're heads down focused on Unity + Dice. I'm cc'ing Mihai for help triaging within the sign-in team and marking as Available for someone to pick up.

Mihai (and others): desired behavior is to open the user manager when a profile is deleted, instead of the next available profile on the machine.

Thiemo - if someone on the privacy team has the bandwidth to pick this up, they are more than welcome to help us out :)
Cc: anthonyvd@chromium.org
Labels: -Pri-2 Pri-1
+anthonyvd who's also an owner of //chrome/browser/profiles.

Anthony, Mihai, could you please take a look at this regression and find an eng owner for it? I'm not familiar with the code, but it's really a very simple request. (Bumping this up to P1 again because it's a regression of something that used to work.)
Owner: droger@chromium.org
Status: Assigned (was: Available)
I this we must bump this back to P1 as otherwise we will not have the time to work on it (at this point, the whole team is focused on DICE and I'm afraid this bug will just get lost otherwise). I am assigning this bug to David as he needs to ramp up a bit on UI.
Thanks a lot, Mihai!

Comment 16 by ew...@chromium.org, Dec 13 2017

To be very clear: this is a much lower priority than working on Dice. This is a minor regression that from my perspective does not have any significant usability, privacy, or security implications.

Mihai, I don't think David should spend his time fixing this with everything else he's working on for Dice. We can discuss this during our next 1:1, but this is the reality of being a small engineering team with a large number of UI surfaces that we are responsible for. We have to prioritize appropriately.

If this is a very quick and easy fix, then I'm happy for David (or anyone else on the team) to make it. If there is complexity involved (i.e. more than .5-1 days of engineering time), we should punt on this for now.
Any progress on this, David? Should we bump down the priority per #c16?

Comment 18 by ew...@chromium.org, Feb 10 2018

Labels: -Pri-1 Pri-2
Bumping down the priority of this to P2 given how swamped we are with Dice.
Project Member

Comment 19 by sheriffbot@chromium.org, Mar 12 2018

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Available)
Project Member

Comment 21 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment