New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757439 link

Starred by 2 users
Status: Fixed
Owner:
█ lod@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
mard...@chromium.org
pschaffner@chromium.org
█ lod@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Labels in suggested sites widget aren't vibrant

Project Member Reported by pschaffner@chromium.org, Aug 21 2017 
The labels under the most visited tiles should be in a visual effect view with widgetSecondaryVibrancyEffect vibrancy (just like those in the quick actions widget).
Simulator Screen Shot 21 Aug 2017, 15.37.20.png
449 KB View Download

Comment 1 by pschaffner@chromium.org, Aug 21 2017

Description: Show this description

Comment 2 by lod@chromium.org, Aug 21 2017

Owner: lod@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by pschaffner@chromium.org, Aug 21 2017

Cc: pschaffner@chromium.org

Comment 4 by lod@chromium.org, Aug 21 2017 

Issue 754296 has been merged into this issue.

Comment 5 by lod@chromium.org, Aug 21 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf

commit daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf
Author: Elodie Banel <lod@google.com>
Date: Wed Aug 23 08:36:42 2017

Use vibrancy in content widget, refactor vibrancy in search widget.

Make content widget labels more vibrant using vibrancy effect, and
move creation of vibrancy effects to the point of use in the search
widget.

Bug:  757439 
Change-Id: Ia84d676d2f32ca6f8894426ce3a1a88ab99007cf
Reviewed-on: https://chromium-review.googlesource.com/624027
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496629}
[modify] https://crrev.com/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf/ios/chrome/content_widget_extension/content_widget_view_controller.mm
[modify] https://crrev.com/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf/ios/chrome/content_widget_extension/most_visited_tile_view.h
[modify] https://crrev.com/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf/ios/chrome/content_widget_extension/most_visited_tile_view.mm
[modify] https://crrev.com/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf/ios/chrome/search_widget_extension/copied_url_view.h
[modify] https://crrev.com/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf/ios/chrome/search_widget_extension/copied_url_view.mm
[modify] https://crrev.com/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf/ios/chrome/search_widget_extension/search_action_view.h
[modify] https://crrev.com/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf/ios/chrome/search_widget_extension/search_action_view.mm
[modify] https://crrev.com/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf/ios/chrome/search_widget_extension/search_widget_view.h
[modify] https://crrev.com/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf/ios/chrome/search_widget_extension/search_widget_view.mm
[modify] https://crrev.com/daf4e7e57bba59256b4189ca4b07f20ed7d5fcbf/ios/chrome/search_widget_extension/search_widget_view_controller.mm

Comment 7 by lod@chromium.org, Aug 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment