New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757432 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 724708



Sign in to add a comment

Hardlock present after the set up with the login disabled.

Project Member Reported by sacomoto@chromium.org, Aug 21 2017

Issue description

After a successful set up (the login flag is disabled), the screen is still hard locked (screenshot attached). But the Chromebook actually finds, connects, and authenticate with the phone correctly.

14:00:10.929 proximity_auth_system.cc:186
Creating RemoteDeviceLifeCycle for focused user: {"account_type":"google","email":"sacomotosmartlock4@gmail.com","gaia_id":"104253985630965752975"}
14:00:10.930 remote_device_life_cycle_impl.cc:55
Life cycle for A0:91:69:28:41:E6 started.
14:00:10.931 bluetooth_low_energy_connection_finder.cc:85
Finding connection
14:00:10.932 bluetooth_low_energy_connection_finder.cc:182
Adapter ready
14:00:10.934 bluetooth_low_energy_connection_finder.cc:190
Discovery session started
14:00:10.935 remote_device_life_cycle_impl.cc:111
Life cycle transition: 0 => 1
14:00:10.937 unlock_manager_impl.cc:159
RemoteDeviceLifeCycle state changed: 1
14:00:10.938 unlock_manager_impl.cc:427
Updating screenlock state from 0 to 2
14:00:11.327 bluetooth_low_energy_connection_finder.cc:167
Generating EIDs for: 5E:F5:F7:6E:DB:2F
14:00:11.329 background_eid_generator.cc:70
Generated EIDs: [
  (1503315000000: 0xc3dd),
  (1503315900000: 0xe2b5),
  (1503316800000: 0xcb70),
  (1503317700000: 0xaaa6),
  (1503318600000: 0xd4cc),
]
14:00:11.330 bluetooth_low_energy_connection_finder.cc:173
Found a matching EID: 0xe2b5
14:00:11.331 bluetooth_low_energy_connection_finder.cc:147
Connecting to device 5E:F5:F7:6E:DB:2F
14:00:11.332 bluetooth_low_energy_connection_finder.cc:244
OnConnectionStatusChanged: 0 -> 1
14:00:11.333 bluetooth_low_energy_connection_finder.cc:226
Stopping discovery session
14:00:11.337 bluetooth_low_energy_weave_client_connection.cc:186
Creating GATT connection with 5E:F5:F7:6E:DB:2F
14:00:12.782 bluetooth_low_energy_weave_client_connection.cc:476
Sending connection request message.
14:00:12.783 bluetooth_low_energy_weave_client_connection.cc:507
Writing 7 bytes.
14:00:12.820 bluetooth_low_energy_connection_finder.cc:244
OnConnectionStatusChanged: 1 -> 2
14:00:12.821 remote_device_life_cycle_impl.cc:111
Life cycle transition: 1 => 2
14:00:12.822 unlock_manager_impl.cc:159
RemoteDeviceLifeCycle state changed: 2
14:00:12.826 device_to_device_authenticator.cc:136
Sending [Initiator Hello] message.
14:00:12.827 bluetooth_low_energy_weave_client_connection.cc:507
Writing 203 bytes.
14:00:13.132 device_to_device_authenticator.cc:237
Received [Responder Auth] message, payload_size=324
14:00:13.147 device_to_device_authenticator.cc:165
Successfully validated [Responder Auth]! Sending [Initiator Auth]...
14:00:13.155 bluetooth_low_energy_weave_client_connection.cc:507
Writing 255 bytes.
14:00:13.179 device_to_device_authenticator.cc:210
Authentication succeeded!
14:00:13.180 remote_device_life_cycle_impl.cc:111
Life cycle transition: 2 => 3
14:00:13.181 unlock_manager_impl.cc:159
RemoteDeviceLifeCycle state changed: 3
 

 
Screenshot 2017-08-21 at 1.58.30 PM.png
398 KB View Download
The issue is the |EasyUnlockService::CheckCryptohomeKeysAndMaybeHardlock| method:
https://cs.chromium.org/chromium/src/chrome/browser/signin/easy_unlock_service.cc?dr=C&l=516

which then calls |EasyUnlockService::OnCryptohomeKeysFetchedForChecking|:
https://cs.chromium.org/chromium/src/chrome/browser/signin/easy_unlock_service.cc?rcl=14bef8b87710c26cc38737c8668a5797dd8094a3&l=796

when the login flags is disabled there will be no devices in the crypthome so the hardlock state handler will always be set to PAIRING_ADDED:
https://cs.chromium.org/chromium/src/chrome/browser/signin/easy_unlock_service.cc?rcl=14bef8b87710c26cc38737c8668a5797dd8094a3&l=817

Comment 2 by tengs@chromium.org, Aug 21 2017

Blocking: 724708
Labels: M-61
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875214817b888f4dd3ade00df0c7ce447ef946bd

commit 875214817b888f4dd3ade00df0c7ce447ef946bd
Author: Gustavo Sacomoto <sacomoto@chromium.org>
Date: Mon Aug 21 17:40:46 2017

Don't compare crypthome keys when the login flag is disabled.

Bug:  757432 
Change-Id: Ic38da4fbcbd14722f14014ce7677eadbc026b3a1
Reviewed-on: https://chromium-review.googlesource.com/623712
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495977}
[modify] https://crrev.com/875214817b888f4dd3ade00df0c7ce447ef946bd/chrome/browser/signin/easy_unlock_service.cc

Labels: Merge-Request-61
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 22 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e71521b3a1c9934f5f5cf324035b3e623bfe28f

commit 5e71521b3a1c9934f5f5cf324035b3e623bfe28f
Author: Gustavo Sacomoto <sacomoto@chromium.org>
Date: Tue Aug 22 09:23:32 2017

Don't compare crypthome keys when the login flag is disabled.

TBR=sacomoto@chromium.org

(cherry picked from commit 875214817b888f4dd3ade00df0c7ce447ef946bd)

Bug:  757432 
Change-Id: Ic38da4fbcbd14722f14014ce7677eadbc026b3a1
Reviewed-on: https://chromium-review.googlesource.com/623712
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495977}
Reviewed-on: https://chromium-review.googlesource.com/625736
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#749}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/5e71521b3a1c9934f5f5cf324035b3e623bfe28f/chrome/browser/signin/easy_unlock_service.cc

Status: Fixed (was: Untriaged)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment