UnpicklingError in memory.dual_browser_test when migrating to WprGo |
|||||
Issue description
Steps to reproduce:
$ ./tools/perf/fetch_benchmark_deps.py memory.dual_browser_test
$ ./tools/perf/convert_legacy_wpr_archive ./tools/perf/page_sets/data/dual_browser_story.json
$ ./tools/perf/run_benchmark memory.dual_browser_test --browser=android-chrome --pageset-repeat 1
Fails with the exception:
ReplayNotStartedError: Web Page Replay failed to start. Log output:
Traceback (most recent call last):
File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/web-page-replay/replay.py", line 563, in <module>
sys.exit(main())
File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/web-page-replay/replay.py", line 559, in main
return replay(options, options.replay_filename)
File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/web-page-replay/replay.py", line 327, in replay
http_archive = httparchive.HttpArchive.Load(replay_filename)
File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/web-page-replay/httparchive.py", line 460, in Load
return cPickle.load(open(filename, 'rb'))
cPickle.UnpicklingError: invalid load key, ' '.
(*) On issue 757425 there is a bug that causes this error message to be hidden; fix is landing now.
,
Aug 21 2017
Thanks, the fix has landed, in case you want to git it a try.
,
Aug 21 2017
The archive was converted successfully in step 2. Step 3 should not have invoked the legacy WPR server's httparchive.py. I am building android-webview now.
,
Aug 21 2017
Ah! That's probably my fault then. This benchmark uses a custom shared state, so I'm probably missing the code needed to pick up the correct WPR version. Assigning back to myself. Do you know where in Telemetry's code is that bit to figure out which WPR version to use?
,
Aug 21 2017
Juan: I believe this is the place: https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/wpr/archive_info.py#L50
,
Aug 21 2017
Got it. Thanks for both for the help! I've got a fix ready now.
,
Aug 21 2017
,
Aug 22 2017
I've just sent out the CL for review. Note: from code search I can see another caller to network_controller.Open that would need to be updated to pass the correct use_wpr_go value and avoid a similar exception to the one I found in #0. https://cs.chromium.org/chromium/src/tools/perf/profile_creators/profile_extender.py?rcl=ae82a28f135c30abe56e6e04a4ac91b4ca1cd98d&l=147
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba7e48f93bd0d79696d11baf8374d273f76d72d1 commit ba7e48f93bd0d79696d11baf8374d273f76d72d1 Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Tue Aug 22 14:22:26 2017 [tools/perf] Update memory.dual_browser_test to WprGo Also update the MultiBrowserSharedState to use_wpr_go when available. Bug: 730036 , 757429 Change-Id: I4efff8ca0db16bbc84b7835af76623d0d0a25fd8 Reviewed-on: https://chromium-review.googlesource.com/625956 Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#496302} [modify] https://crrev.com/ba7e48f93bd0d79696d11baf8374d273f76d72d1/tools/perf/page_sets/data/dual_browser_story.json [delete] https://crrev.com/ba5468be92dde91424e518b062c2bbf96a01402b/tools/perf/page_sets/data/dual_browser_story_000.wpr.sha1 [add] https://crrev.com/ba7e48f93bd0d79696d11baf8374d273f76d72d1/tools/perf/page_sets/data/dual_browser_story_000.wprgo.sha1 [delete] https://crrev.com/ba5468be92dde91424e518b062c2bbf96a01402b/tools/perf/page_sets/data/dual_browser_story_001.wpr.sha1 [add] https://crrev.com/ba7e48f93bd0d79696d11baf8374d273f76d72d1/tools/perf/page_sets/data/dual_browser_story_001.wprgo.sha1 [delete] https://crrev.com/ba5468be92dde91424e518b062c2bbf96a01402b/tools/perf/page_sets/data/dual_browser_story_002.wpr.sha1 [add] https://crrev.com/ba7e48f93bd0d79696d11baf8374d273f76d72d1/tools/perf/page_sets/data/dual_browser_story_002.wprgo.sha1 [modify] https://crrev.com/ba7e48f93bd0d79696d11baf8374d273f76d72d1/tools/perf/page_sets/dual_browser_story.py
,
Aug 22 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xunji...@chromium.org
, Aug 21 2017