Bug in MultiBrowserSharedState.DumpStateUponFailure |
||
Issue descriptionDumpStateUponFailure [1] may be called before browser creation has been completed thus causing a "None has no method DumpStateUponFailure" when trying to dump on a browser value that is still None. This second exception, furthermore, hides whatever might have been the failure reason which caused the method to be called in the first place. Found this out while preparing these benchmarks for WprGo migration. [1]: https://cs.chromium.org/chromium/src/tools/perf/page_sets/dual_browser_story.py?rcl=b5985781e77b51eab38ef967c0f4466401fd80fd&l=202
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/145d744af343aa27e6220e041004b9005956fbd3 commit 145d744af343aa27e6220e041004b9005956fbd3 Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Mon Aug 21 14:00:15 2017 [tools/perf] Fix MultiBrowserSharedState.DumpStateUponFailure DumpStateUponFailure may be called before the creation of the browsers has been completed. The method did not work in such case, raising a second exception that would mask the original cause of failure. Bug: 757425 Change-Id: I89df74d2a1321f14e87ef122de4d9e9bd5111729 Reviewed-on: https://chromium-review.googlesource.com/623787 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#495926} [modify] https://crrev.com/145d744af343aa27e6220e041004b9005956fbd3/tools/perf/page_sets/dual_browser_story.py
,
Aug 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by perezju@chromium.org
, Aug 21 2017