Issue metadata
Sign in to add a comment
|
Regression: Scrollbar should not be seen on Keep extension when clicked on Google apps icon |
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3192.0 OS:Ubuntu 14.04 Prerequisite: Turn off show bookmarks bars on settings page What steps will reproduce the problem? (1)Launch chrome>> Go to WBS>> Add Keep extension>> Login (2)Click on Google apps icon and observe Expected Scroll bar should not be seen Actual Unwanted scroll bar is seen This is a Regression issue broken in M-51 Note: On Windows: Issue is not Reproducible On Linux: Issue is seen on screen resolution 1366*768(16:9) Here is the manual bisect info =============== Good build: 51.0.2666.0 Bad build: 51.0.2667.0
,
Aug 21 2017
Here is the manual bisect info and changelog from omahaproxy Manual Bisect Info: ==================== Good build: 51.0.2666.0 Bad build: 51.0.2667.0 You are probably looking for a change made after 379099 (known good), but no later than 379110 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/a9af97d82c54e699fb369db0fdc8e44923af03d7..e4dae472b2f122a5c93dc3f7338ee946eda677b1 Suspecting: https://codereview.chromium.org/1726743003 @jonross: : Please pardon me if it has nothing to do with your change, and please help in assigning to appropriate owner
,
Aug 21 2017
This would be unrelated to the CL listed in #2 which affected the tab strip, and has since been replaced with a different implementation. I am not aware of who works on scrollbars. But it sounds like given the screen resolution in the report, either we miscalculate the need for scrollbars, or the keep site itself is doing something odd.
,
Aug 22 2017
On retrying the scenario, repeatedly getting same bisect info as mentioned in the comment #2 Manual Bisect Info: ==================== Good build: 51.0.2666.0 Bad build: 51.0.2667.0 Hence providing the Normal change log https://chromium.googlesource.com/chromium/src/+log/51.0.2666.0..51.0.2667.0?pretty=fuller&n=10000 Suspecting: https://codereview.chromium.org/1736073002 @sunxd: Please pardon me if it has nothing to do with your change, and please help in assigning to appropriate owner
,
Aug 22 2017
The CL should not change any scroll related logic, since it only moves the scroll offset variable from layer tree to scroll tree. I think the bug should at least happen when we decide NeedsScrollbars. CC some folks who might have better knowledge on scrollbars.
,
Aug 22 2017
I'm unable to reproduce this locally in 62.0.3188.2. Is installing the keep extension required? It looks like you're just interacting with the keep.google.com page. Lowering priority since it's been around for a long time.
,
Aug 23 2017
the scrollbar appears when the browser window doesn't have room to show that element (see screenshot). The change you've noticed is that our tabstrip got a little taller, leaving less room for the web contents, which happens to have tipped the scales and shown the scrollbar on this page. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, Aug 21 2017