New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757383 link

Starred by 2 users
Status: Fixed
Owner:
█ oskopek@google.com
Last visit > 30 days ago
Closed: Aug 2017
Cc:
█ sfiera@chromium.org
█ oskopek@google.com
treib@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Local NTP: Blinking cursor in fakebox missing

Project Member Reported by treib@chromium.org, Aug 21 2017 
Navigate to chrome-search://local-ntp/local-ntp.html
Click the fakebox

Expected: Blinking cursor
Actual: No cursor

Broken in M62 (Dev channel and trunk), works fine in M61 Beta. Probably related to one of the recent CSS changes.

Comment 1 by sfiera@chromium.org, Aug 21 2017

Owner: oskopek@google.com
Status: Assigned (was: Available)
Disappeared somewhere between 62.0.3175.0 and 62.0.3192.0.

The CSS rule that is supposed to cause the blink refers to "body.fakebox-focused #cursor"

crrev.com/8e8e431c22b0 renamed #cursor to #fakebox-cursor, but didn't change the blink CSS rule, only the main "#cursor" rule.

Comment 2 by treib@chromium.org, Aug 21 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f378d597da299f25c93c1e6b92589022ea8ee1e5

commit f378d597da299f25c93c1e6b92589022ea8ee1e5
Author: Ondrej Skopek <oskopek@google.com>
Date: Mon Aug 21 16:22:41 2017

[Local NTP] Properly rename the 'cursor' element to 'fakebox-cursor'.

Fixes a bug introduced in http://crrev.com/8e8e431c22b0
due to not renaming all occurrences of 'cursor'.

Bug:  757383 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I89c2185d5e41b6908f96a606a058b2220de46510
Reviewed-on: https://chromium-review.googlesource.com/623673
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Ondrej Škopek <oskopek@google.com>
Cr-Commit-Position: refs/heads/master@{#495954}
[modify] https://crrev.com/f378d597da299f25c93c1e6b92589022ea8ee1e5/chrome/browser/resources/local_ntp/local_ntp.css

Comment 4 by oskopek@google.com, Aug 22 2017

Status: Fixed (was: Started)
Thanks for finding this Marc, and thanks for tracking down the culprit, Chris.
►

Sign in to add a comment