New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757368 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Samus stack overflow when processing the hash command

Project Member Reported by cheyuw@google.com, Aug 21 2017

Issue description

The stack overflow will happen in HOSTCMD task when it tries to start a hash calculation with a long nonce (> 32bytes).

Here is the stack trace:

Task: HOSTCMD, Max size: 752 (528 + 224), Allocated size: 512
Call Trace:
    host_command_task (56) [common/host_command.c:418] 27984
        -> host_command_task [common/host_command.c:433] 27a04
    host_command_process (48) [common/host_command.c:603] 2783c
    host_command_vboot_hash (24) [common/vboot_hash.c:425] 30a60
        -> host_command_vboot_hash [common/vboot_hash.c:442] 30aba
           - host_start_hash [common/vboot_hash.c:414]
    vboot_hash_start (32) [common/vboot_hash.c:162] 30778
        -> vboot_hash_start [common/vboot_hash.c:188] 307d4
    SHA256_update (24) [common/sha256.c:160] 2e748
        -> SHA256_update [common/sha256.c:180] 2e786
        -> SHA256_update [common/sha256.c:181] 2e794
    SHA256_transform (344) [common/sha256.c:120] 2e5b4

What steps will reproduce the problem?
(1) Apply CL https://chromium-review.googlesource.com/c/622295
(2) Deploy the modified ectool to samus.
(3) In the shell, "sudo ectool echash start 0 100 100".

 

Comment 1 by vpalatin@google.com, Aug 21 2017

AFAIK we never do this.

but we should still plug the hole (might be just putting a smaller size limit on the host command nonce parameter).
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 13 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
The assigned owner "cheyuw@google.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment