Devtools - Elements - Styles panel: pressing Tab after creating a new rule doesn't proceed to a new property input
Reported by
woxxom@gmail.com,
Aug 21 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3191.0 Safari/537.36 Steps to reproduce the problem: 1. open devtools on any page, switch to Elements panel, Styles subpanel 2. click + icon to add a new style rule 3. press the Tab key What is the expected behavior? Able to proceed to enter the rule contents: an empty input field inside the rule is focused. What went wrong? Not able to proceed. Nothing is focused. To enter the contents an additional click inside the rule area is required. Did this work before? Yes 61 Chrome version: 62.0.3191.0 Channel: canary OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Rough bisect info: 493028 (good) - 494351 (bad) https://chromium.googlesource.com/chromium/src/+log/ef41d237..aee19604?n=10000 Suspecting r493604 "DevTools: Allow tabbing into styles sidebar" Couldn't do a more precise bisect because Windows snapshots in the range don't start at all, but the suspected CL seems directly related to the problem.
,
Sep 17 2017
Beta of M62 ends in 4 days on Sep 21, and the bug hasn't yet been fixed...
,
Sep 17 2017
If fixing the bug is too difficult, is it possible to simply revert r493604 ?
,
Sep 21 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ab0eb4e7f4f2f1c00467cacaf4f30cef760f9e9 commit 6ab0eb4e7f4f2f1c00467cacaf4f30cef760f9e9 Author: Joel Einbinder <einbinder@chromium.org> Date: Wed Nov 08 04:54:43 2017 DevTools: Fix tabbing from newly created style rule to first property Bug: 757364 Change-Id: I334bb09b5eb1e447c26ef3cfd154bf0732baf367 Reviewed-on: https://chromium-review.googlesource.com/677128 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#514754} [add] https://crrev.com/6ab0eb4e7f4f2f1c00467cacaf4f30cef760f9e9/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-keyboard-expected.txt [add] https://crrev.com/6ab0eb4e7f4f2f1c00467cacaf4f30cef760f9e9/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-keyboard.html [modify] https://crrev.com/6ab0eb4e7f4f2f1c00467cacaf4f30cef760f9e9/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Dec 4 2017
,
Dec 4 2017
,
Jan 2 2018
Issue 796240 has been merged into this issue.
,
Jan 17 2018
,
Jan 30 2018
Is this something that is going to be fixed?
,
Jan 30 2018
It's already fixed in 64.0.3263.0.
,
Jan 31 2018
Thank you for this fix! |
||||
►
Sign in to add a comment |
||||
Comment 1 by jmukthavaram@chromium.org
, Aug 22 2017Labels: -Pri-2 hasbisect-per-revision M-62 Needs-Triage-M62 OS-Linux OS-Mac Pri-1
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)