New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757360 link

Starred by 1 user
Status: Verified
Owner:
█ lod@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
mard...@chromium.org
pschaffner@chromium.org
olivierrobin@chromium.org
█ lod@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Need highlighted state for all controls

Project Member Reported by pschaffner@chromium.org, Aug 21 2017 
Between both widgets, we need to apply a highlighted state for all controls (quick actions, copied link and suggested site tiles).

I would like the default provided by a UIButton (a slight reduction in opacity) ... so I guess make everything a UIButton! ;)

Comment 1 by lod@chromium.org, Aug 21 2017

Owner: lod@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by pschaffner@chromium.org, Aug 21 2017

Cc: pschaffner@chromium.org

Comment 3 by lod@chromium.org, Sep 7 2017 

We'll use the kDuration8 constant in material_timing.h (0.07) for animation and 0.5 alpha for the highlighted state.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a384b064b79e81c9498d6fa3526eba607d7596e3

commit a384b064b79e81c9498d6fa3526eba607d7596e3
Author: Elodie Banel <lod@google.com>
Date: Fri Sep 08 10:56:21 2017

Show feedback on touch in widget extensions.

Feedback is in the form of 0.5 opacity, animated.

Bug:  757360 
Change-Id: Ia22c05092a99dee438f455c3f60b5fb564ed29c7
Reviewed-on: https://chromium-review.googlesource.com/649688
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500563}
[modify] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/common/BUILD.gn
[modify] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/common/README.txt
[add] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/common/highlight_button.h
[add] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/common/highlight_button.mm
[modify] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/content_widget_extension/BUILD.gn
[modify] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/content_widget_extension/most_visited_tile_view.h
[modify] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/search_widget_extension/BUILD.gn
[modify] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/search_widget_extension/copied_url_view.h
[modify] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/search_widget_extension/copied_url_view.mm
[modify] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/search_widget_extension/search_action_view.h
[modify] https://crrev.com/a384b064b79e81c9498d6fa3526eba607d7596e3/ios/chrome/search_widget_extension/search_action_view.mm

Comment 5 by lod@chromium.org, Sep 8 2017

Status: Fixed (was: Assigned)

Comment 6 by vbhatso...@chromium.org, Sep 26 2017

Status: Verified (was: Fixed)
Verified on build 63.0.3224.0 Canary on iPhone 6+ iOs 11.0 , iPad Pro 12'5 iOS 10.3.3
There is a highlighted state for controls - >quick actions, copied link and suggested site tiles.
►

Sign in to add a comment