New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757348 link

Starred by 1 user
Status: Archived
Owner:
x...@chromium.org
Closed: Aug 2017
Cc:
█ krajshree@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Add button is seen disabled in 'Add a printer manually' screen even after entering all the details

Project Member Reported by rkalavakuntla@chromium.org, Aug 21 2017 
Chrome Version:62.0.3190.0/9862.0.0 dev-channel Daisy,Kip,Peppy
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign in to chrome or Browse as guest >> Navigate to chrome://settings/cupsPrinters page
(2)Click on Add Printer button >> In 'Add a printer manually' screen, enter all details and Observe Add button.

Expected:Add button should be enabled after entering all mandatory details.
Actual: Instead, Add button is seen disabled

This is Regression issue as same is working fine in 62.0.3186.0/9845.0.0 dev channel Kip.

Note: Issue is not applicable to Linux and Windows.

Attaching screen-cast for reference.

@xdai: Please confirm the issue.
Actual.webm
270 KB View Download
Expected.webm
586 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97c7a39a9a8c84956bd603b21d5596c6f53f253c

commit 97c7a39a9a8c84956bd603b21d5596c6f53f253c
Author: xdai <xdai@chromium.org>
Date: Tue Aug 22 19:03:06 2017

[CUPS] Fix the regression issue that "Add" button is disabled.

The "selectedPrinter" property in "add-printer-discovery-dialog' and
"newPrinter" property in "add-printer-manually-dialog' are both binded
to the "newPrinter" property in "settings-cups-add-printer-dialog", thus
they might interfere with each other unexpectedly. We need to make sure
the value of the properties are properly reset when switching from one
add-printer-flow to the other add-printer-flow.

Bug:  757348 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I099a73d60bd02abd5326f3cc26d2e64d5e856f88
Reviewed-on: https://chromium-review.googlesource.com/624530
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496391}
[modify] https://crrev.com/97c7a39a9a8c84956bd603b21d5596c6f53f253c/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js

Comment 2 by x...@chromium.org, Aug 22 2017

Labels: -M-62 M-61 Merge-Request-61
Status: Fixed (was: Assigned)
I think this should also merged in M61.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 22 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by keta...@chromium.org, Aug 22 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 25 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71ff21c8787e62cbb12a3bde7257869b2fc425cf

commit 71ff21c8787e62cbb12a3bde7257869b2fc425cf
Author: xdai <xdai@chromium.org>
Date: Fri Aug 25 22:06:07 2017

[Merge to M61][CUPS] Fix the regression issue that "Add" button is disabled.

The "selectedPrinter" property in "add-printer-discovery-dialog' and
"newPrinter" property in "add-printer-manually-dialog' are both binded
to the "newPrinter" property in "settings-cups-add-printer-dialog", thus
they might interfere with each other unexpectedly. We need to make sure
the value of the properties are properly reset when switching from one
add-printer-flow to the other add-printer-flow.

TBR=michaelpg@chromium.org
(cherry picked from commit 97c7a39a9a8c84956bd603b21d5596c6f53f253c)

Bug:  757348 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I099a73d60bd02abd5326f3cc26d2e64d5e856f88
Reviewed-on: https://chromium-review.googlesource.com/624530
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496391}
Reviewed-on: https://chromium-review.googlesource.com/636119
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#904}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/71ff21c8787e62cbb12a3bde7257869b2fc425cf/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment