Regression : In 'SIGN OUT' confirmation dialog, checkbox is seen misplaced.
Reported by
avsha...@etouch.net,
Aug 21 2017
|
|||||
Issue descriptionChrome version : 62.0.3192.0 (Official Build) 006fe05062cd9696cd11f2cb607c92f577471b7d-refs/heads/master@{#495856} 32/64 bit OS : Windows (7,8,10), Mac(10.11.6, 10.12.3, 10.12.5) Precondition : Sign in to chrome using valid credentials. What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://settings. 2. Click on 'SIGN OUT' button and observe the 'Also remove your existing..' option's checkbox alignment. Actual Result : Checkbox is seen misplaced in 'SIGN OUT' confirmation dialog. Expected Result : Checkbox should have proper alignment in 'SIGN OUT' confirmation dialog. This is a regression issue broken in ‘M-62’, below is the manual regression range and will soon update bisect info. Good build : 62.0.3190.0 Bad build : 62.0.3191.0 Will soon update other OS info.
,
Aug 21 2017
Able to reproduce the issue on Windows 7, Mac 10.12.6 & Ubuntu 14.04 using latest Canary-62.0.3192.0. Manual Bisect info: ------------------ Good build : 62.0.3190.0-Revision-495757 Bad build : 62.0.3191.0-Revision-495816 Per revision bisect info: ------------------------- You are probably looking for a change made after 495791 (known good), but no later than 495792 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/90113a2c01ca9ff77042daacd8282a4c16aade85..8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a Suspected CL: ------------ https://chromium.googlesource.com/chromium/src/+/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a dschuyler@,Could you please take a look & reassign to the respective owner if it is not related to your change. As it is recent regression issue, adding Release block stable label . Please remove if it is not the case. Thanks..!!
,
Aug 21 2017
Your bug is tagged as Release block Stable. M62 is branching soon and we will be taking only CRITICAL merges. Please plan accordingly.
,
Aug 21 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2c26a32e0b78da66a29585db80358eab35109f0 commit d2c26a32e0b78da66a29585db80358eab35109f0 Author: Dave Schuyler <dschuyler@chromium.org> Date: Tue Aug 29 22:38:25 2017 [MD settings] using settings-box in dialog footer The sign out dialog contains more UI in the dialog that other dialog footers. Changing footer to use setting-box so that it can be lain out similarly to other UI. Bug: 757318 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9955844bf4e4411fb76b53c29bf16a99d1d3661b Reviewed-on: https://chromium-review.googlesource.com/624894 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#498262} [modify] https://crrev.com/d2c26a32e0b78da66a29585db80358eab35109f0/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/d2c26a32e0b78da66a29585db80358eab35109f0/chrome/browser/resources/settings/settings_vars_css.html [modify] https://crrev.com/d2c26a32e0b78da66a29585db80358eab35109f0/ui/webui/resources/cr_elements/shared_vars_css.html
,
Aug 29 2017
,
Aug 30 2017
Tested the issue on Windows 7, Mac 10.12.6 and Ubutu 14.04 using Chrome version M62 - 62.0.3200.0 as per the issue mentioned in original comment. Observed that issue is working as intended (In the “Sign out of Chrome” dialog check box is properly aligned ). Hence adding TE-Verified label. Attached the screenshot for reference. Thank you! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by avsha...@etouch.net
, Aug 21 2017712 KB
712 KB View Download
656 KB
656 KB View Download
29.7 KB
29.7 KB View Download