Misspelling markers does not disappear for newly added words
Reported by
nicki...@yandex-team.ru,
Aug 21 2017
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.125 YaBrowser/17.7.0.1575 Yowser/2.5 Safari/537.36 Steps to reproduce the problem: 1. type a misspelled word 2. put this word to the custom dictionary What is the expected behavior? Misspelling markers will be removed. What went wrong? They are left. Only when you change the text in a some way markers will be removed. The problem is in cache (I mean |last_request_| and |last_results_| fields of SpellCheckProvider) which is used in SpellCheckProvider::SatisfyRequestFromCache(). While the text wasn't touched, every call of SpellCheckProvider::RequestTextChecking() will lead to returning of old check results. And when the text will be changed we perform new check and correctly determine misspellings. OS affected by this bug: Mac, Win, Linux (presumably). Did this work before? N/A Chrome version: 59.0.3071.125 Channel: n/a OS Version: OS X 10.12.6 Flash Version: Shockwave Flash 26.0 r0
,
Aug 23 2017
Able to reproduce the issue on the latest canary(62.0.3193.0) of Mac OS 10.12.6,Linux Ubuntu 14.04 and Windows-10. This is non-regressed behavior is seen on older chrome version: 45.0.2454.101 as well.
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/935253bf5e54b5d076f73d2c431f012c90cd5f68 commit 935253bf5e54b5d076f73d2c431f012c90cd5f68 Author: Konstantin Ganenko <ganenkokb@yandex-team.ru> Date: Mon May 07 13:33:05 2018 Fix misspelling marking after adding new word into custom dictionary. Previously spellcheck provider cached last spell check result, so after adding new word to dictionary misspelling mark could disappear only after changing input. Now we reset cached spellcheck result on each custom dictionary change. R=groby@chromium.org Bug: 757294 Change-Id: Ia47771e0972ab26468c4da9bdebad2070ce89c64 Reviewed-on: https://chromium-review.googlesource.com/1006576 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#556426} [modify] https://crrev.com/935253bf5e54b5d076f73d2c431f012c90cd5f68/components/spellcheck/renderer/spellcheck.cc [modify] https://crrev.com/935253bf5e54b5d076f73d2c431f012c90cd5f68/components/spellcheck/renderer/spellcheck.h [modify] https://crrev.com/935253bf5e54b5d076f73d2c431f012c90cd5f68/components/spellcheck/renderer/spellcheck_provider.cc [modify] https://crrev.com/935253bf5e54b5d076f73d2c431f012c90cd5f68/components/spellcheck/renderer/spellcheck_provider.h [modify] https://crrev.com/935253bf5e54b5d076f73d2c431f012c90cd5f68/components/spellcheck/renderer/spellcheck_provider_test.cc [modify] https://crrev.com/935253bf5e54b5d076f73d2c431f012c90cd5f68/components/spellcheck/renderer/spellcheck_provider_test.h [modify] https://crrev.com/935253bf5e54b5d076f73d2c431f012c90cd5f68/components/spellcheck/renderer/spellcheck_provider_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by lgrey@chromium.org
, Aug 22 2017