New issue
Advanced search Search tips

Issue 757291 link

Starred by 3 users
Status: Fixed
Owner:
xing...@intel.com
Closed: Jan 2018
Cc:
danakj@chromium.org
ericrk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 738190



Sign in to add a comment

Split the write/read in ResourceProvider

Project Member Reported by xing...@intel.com, Aug 21 2017 
Currently most of these Scoped*s are used by both the producer(write) and consumer(read) in ResourceProvider as listed in below table:
https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit

Need to investigate how to split read/write in ResourceProvider into LayerTreeResourceProvider or DisplayResourceProvider.

Comment 1 by xing...@intel.com, Aug 23 2017

Components: Internals>Compositing
Status: Assigned (was: Untriaged)

Comment 2 by fsam...@chromium.org, Aug 24 2017 

Ultimately we want to place DisplayResourceProvider next to Display in components/viz/service/display.

Comment 4 by xing...@intel.com, Aug 28 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56e7a6003c755d9aa8614b3b4bcaabb72c19230f

commit 56e7a6003c755d9aa8614b3b4bcaabb72c19230f
Author: Xu Xing <xing.xu@intel.com>
Date: Thu Aug 31 21:45:46 2017

viz: Move ScopedReadLockGL to Display

BUG= 757291 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0bb4b9e17a21dfd081323d78b995cd176cd1bbb3
Reviewed-on: https://chromium-review.googlesource.com/640410
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#499020}
[modify] https://crrev.com/56e7a6003c755d9aa8614b3b4bcaabb72c19230f/cc/output/overlay_unittest.cc
[modify] https://crrev.com/56e7a6003c755d9aa8614b3b4bcaabb72c19230f/cc/resources/display_resource_provider.cc
[modify] https://crrev.com/56e7a6003c755d9aa8614b3b4bcaabb72c19230f/cc/resources/display_resource_provider.h
[modify] https://crrev.com/56e7a6003c755d9aa8614b3b4bcaabb72c19230f/cc/resources/layer_tree_resource_provider.h
[modify] https://crrev.com/56e7a6003c755d9aa8614b3b4bcaabb72c19230f/cc/resources/resource_provider.cc
[modify] https://crrev.com/56e7a6003c755d9aa8614b3b4bcaabb72c19230f/cc/resources/resource_provider.h
[modify] https://crrev.com/56e7a6003c755d9aa8614b3b4bcaabb72c19230f/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/56e7a6003c755d9aa8614b3b4bcaabb72c19230f/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/56e7a6003c755d9aa8614b3b4bcaabb72c19230f/components/viz/service/display/gl_renderer.h
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc2f064b85fc5221f7a16c5bdcba6e91bce14f1b

commit cc2f064b85fc5221f7a16c5bdcba6e91bce14f1b
Author: Xu Xing <xing.xu@intel.com>
Date: Thu Aug 31 22:03:06 2017

viz: Move ScopedReadLockSoftware to Display

In ResourceProviderTest/TransferSoftwareResources and TileManagerTest/LowResHasNoImage,
use ScopedWriteLockSoftware to replace ScopedReadLockSoftware.

BUG= 757291 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia5bbd0a984cf070c61ff5d55e73cc476f6b0e9e5
Reviewed-on: https://chromium-review.googlesource.com/642453
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#499032}
[modify] https://crrev.com/cc2f064b85fc5221f7a16c5bdcba6e91bce14f1b/cc/output/software_renderer.cc
[modify] https://crrev.com/cc2f064b85fc5221f7a16c5bdcba6e91bce14f1b/cc/resources/display_resource_provider.cc
[modify] https://crrev.com/cc2f064b85fc5221f7a16c5bdcba6e91bce14f1b/cc/resources/display_resource_provider.h
[modify] https://crrev.com/cc2f064b85fc5221f7a16c5bdcba6e91bce14f1b/cc/resources/resource_provider.cc
[modify] https://crrev.com/cc2f064b85fc5221f7a16c5bdcba6e91bce14f1b/cc/resources/resource_provider.h
[modify] https://crrev.com/cc2f064b85fc5221f7a16c5bdcba6e91bce14f1b/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/cc2f064b85fc5221f7a16c5bdcba6e91bce14f1b/cc/tiles/tile_manager_unittest.cc

Comment 8 by xing...@intel.com, Sep 1 2017

Blocking: 738190

Comment 9 by xing...@intel.com, Sep 6 2017 

Next step, will investigate the possibility to move SingleReleaseCallbackImpl/CreateResourceFromTextureMailbox into LayerTreeREsourceProvider. For detail, please refer to:
https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit#gid=75748731
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa28a986ec23a5fca6ca69ee7466fccc9370ae50

commit aa28a986ec23a5fca6ca69ee7466fccc9370ae50
Author: Xu Xing <xing.xu@intel.com>
Date: Mon Sep 11 18:06:06 2017

viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest

As a step of moving SingleReleaseCallbackImpl/CreateResourceFromTextureMailbox
into LayerTreeREsourceProvider, move the call of
DisplayResourceProvider::CreateResourceFromTextureMailbox
into LayerTreeResourceProvider::CreateResourceFromTextureMailbox.

The usage of CreateResourceFromTextureMailbox is listed here:
https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit

BUG= 757291 

Change-Id: I41e5d44c5f2ac03b3a5b3da1951a5ca09b3b4529
Reviewed-on: https://chromium-review.googlesource.com/654444
Commit-Queue: Xing Xu <xing.xu@intel.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500974}
[modify] https://crrev.com/aa28a986ec23a5fca6ca69ee7466fccc9370ae50/components/viz/service/display/gl_renderer_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0c00467d673f5f21d2d87cb0df06a8efcfcf13e

commit e0c00467d673f5f21d2d87cb0df06a8efcfcf13e
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Mon Sep 11 21:38:26 2017

Revert "viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest"

This reverts commit aa28a986ec23a5fca6ca69ee7466fccc9370ae50.

Reason for revert: viz_unittests failure, details in  crbug.com/764069 

Original change's description:
> viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest
> 
> As a step of moving SingleReleaseCallbackImpl/CreateResourceFromTextureMailbox
> into LayerTreeREsourceProvider, move the call of
> DisplayResourceProvider::CreateResourceFromTextureMailbox
> into LayerTreeResourceProvider::CreateResourceFromTextureMailbox.
> 
> The usage of CreateResourceFromTextureMailbox is listed here:
> https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit
> 
> BUG= 757291 
> 
> Change-Id: I41e5d44c5f2ac03b3a5b3da1951a5ca09b3b4529
> Reviewed-on: https://chromium-review.googlesource.com/654444
> Commit-Queue: Xing Xu <xing.xu@intel.com>
> Reviewed-by: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500974}

TBR=danakj@chromium.org,sunnyps@chromium.org,xing.xu@intel.com

Change-Id: I195041642f58de7568922029642b8c2640d0319f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  757291 
Reviewed-on: https://chromium-review.googlesource.com/661457
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501048}
[modify] https://crrev.com/e0c00467d673f5f21d2d87cb0df06a8efcfcf13e/components/viz/service/display/gl_renderer_unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b63476e1d8e78b51d978bfc17b80cba58171885

commit 8b63476e1d8e78b51d978bfc17b80cba58171885
Author: Ben Wells <benwells@chromium.org>
Date: Tue Sep 12 01:09:06 2017

Revert "viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest"

This reverts commit aa28a986ec23a5fca6ca69ee7466fccc9370ae50.

Reason for revert: Has caused stack-use-after-scope errors on ASAn bot.

First build failure: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23580

Sample output:
[ RUN      ] GLRendererTest.OverlaySyncTokensAreProcessed
=================================================================
==9679==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f2ca060c548 at pc 0x000000736f66 bp 0x7ffffdbd9de0 sp 0x7ffffdbd9dd8
READ of size 8 at 0x7f2ca060c548 thread T0
    #0 0x736f65 in end buildtools/third_party/libc++/trunk/include/vector:1481:30
    #1 0x736f65 in viz::(anonymous namespace)::CollectResources(std::__1::vector<viz::ReturnedResource, std::__1::allocator<viz::ReturnedResource> >*, std::__1::vector<viz::ReturnedResource, std::__1::allocator<viz::ReturnedResource> > const&, cc::BlockingTaskRunner*) components/viz/service/display/gl_renderer_unittest.cc:1925
    #2 0x3680f76 in Run base/callback.h:92:12
    #3 0x3680f76 in cc::DisplayResourceProvider::DeleteAndReturnUnusedResourcesToChild(std::__1::__hash_map_iterator<std::__1::__hash_iterator<std::__1::__hash_node<std::__1::__hash_value_type<int, cc::DisplayResourceProvider::Child>, void*>*> >, cc::ResourceProvider::DeleteStyle, std::__1::vector<unsigned int, std::__1::allocator<unsigned int> > const&) cc/resources/display_resource_provider.cc:255
    #4 0x367dfbf in cc::DisplayResourceProvider::DestroyChildInternal(std::__1::__hash_map_iterator<std::__1::__hash_iterator<std::__1::__hash_node<std::__1::__hash_value_type<int, cc::DisplayResourceProvider::Child>, void*>*> >, cc::ResourceProvider::DeleteStyle) cc/resources/display_resource_provider.cc:145:3
    #5 0x367d6d0 in cc::DisplayResourceProvider::~DisplayResourceProvider() cc/resources/display_resource_provider.cc:35:5
    #6 0x367e10d in cc::DisplayResourceProvider::~DisplayResourceProvider() cc/resources/display_resource_provider.cc:33:53
    #7 0x74ad4e in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5
    #8 0x74ad4e in reset buildtools/third_party/libc++/trunk/include/memory:2585
    #9 0x74ad4e in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539
    #10 0x74ad4e in viz::(anonymous namespace)::GLRendererTest_OverlaySyncTokensAreProcessed_Test::TestBody() components/viz/service/display/gl_renderer_unittest.cc:2211
....

Original change's description:
> viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest
> 
> As a step of moving SingleReleaseCallbackImpl/CreateResourceFromTextureMailbox
> into LayerTreeREsourceProvider, move the call of
> DisplayResourceProvider::CreateResourceFromTextureMailbox
> into LayerTreeResourceProvider::CreateResourceFromTextureMailbox.
> 
> The usage of CreateResourceFromTextureMailbox is listed here:
> https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit
> 
> BUG= 757291 
> 
> Change-Id: I41e5d44c5f2ac03b3a5b3da1951a5ca09b3b4529
> Reviewed-on: https://chromium-review.googlesource.com/654444
> Commit-Queue: Xing Xu <xing.xu@intel.com>
> Reviewed-by: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500974}

TBR=danakj@chromium.org,sunnyps@chromium.org,xing.xu@intel.com

Change-Id: I4429d959bea725598662c5bee5c7f1c70acba22f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  757291 
Reviewed-on: https://chromium-review.googlesource.com/662470
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501133}
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3bf2aa149154b42827556585a5866dd14e3f7a3

commit b3bf2aa149154b42827556585a5866dd14e3f7a3
Author: Xu Xing <xing.xu@intel.com>
Date: Tue Sep 12 17:41:00 2017

Reland "viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest"

This is a reland of aa28a986ec23a5fca6ca69ee7466fccc9370ae50
Original change's description:
> viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest
>
> As a step of moving SingleReleaseCallbackImpl/CreateResourceFromTextureMailbox
> into LayerTreeREsourceProvider, move the call of
> DisplayResourceProvider::CreateResourceFromTextureMailbox
> into LayerTreeResourceProvider::CreateResourceFromTextureMailbox.
>
> The usage of CreateResourceFromTextureMailbox is listed here:
> https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit
>
> BUG= 757291 
>
> Change-Id: I41e5d44c5f2ac03b3a5b3da1951a5ca09b3b4529
> Reviewed-on: https://chromium-review.googlesource.com/654444
> Commit-Queue: Xing Xu <xing.xu@intel.com>
> Reviewed-by: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500974}

Bug:  757291 
Change-Id: I3a480f72dd6761e940f67f56d636eaf2340df4cc
Reviewed-on: https://chromium-review.googlesource.com/662437
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#501328}
[modify] https://crrev.com/b3bf2aa149154b42827556585a5866dd14e3f7a3/components/viz/service/display/gl_renderer_unittest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd585def824c2ea92c4a2b2a060ef5ac6e5f507d

commit fd585def824c2ea92c4a2b2a060ef5ac6e5f507d
Author: Xu Xing <xing.xu@intel.com>
Date: Wed Sep 13 15:03:14 2017

viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in OverlayTest

The usage of CreateResourceFromTextureMailbox is listed here:
https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit

BUG= 757291 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I73327a885e5b4dc171c79b420b3913e9e648b6e4
Reviewed-on: https://chromium-review.googlesource.com/664309
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501631}
[modify] https://crrev.com/fd585def824c2ea92c4a2b2a060ef5ac6e5f507d/cc/output/overlay_unittest.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a016b412009d090a2339eb0f1b203bde02bc2f3e

commit a016b412009d090a2339eb0f1b203bde02bc2f3e
Author: Xu Xing <xing.xu@intel.com>
Date: Fri Sep 22 19:35:02 2017

viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in render_pass_test_utils

BUG= 757291 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I302ff10eab190cafa48cd5825a3b56ce27bd375b
Reviewed-on: https://chromium-review.googlesource.com/672012
Commit-Queue: Xing Xu <xing.xu@intel.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503821}
[modify] https://crrev.com/a016b412009d090a2339eb0f1b203bde02bc2f3e/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/a016b412009d090a2339eb0f1b203bde02bc2f3e/cc/test/render_pass_test_utils.h
[modify] https://crrev.com/a016b412009d090a2339eb0f1b203bde02bc2f3e/components/viz/service/display/gl_renderer_unittest.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8c70d98dd3ee4bdf81614ffc835888079eaacda

commit a8c70d98dd3ee4bdf81614ffc835888079eaacda
Author: Xu Xing <xing.xu@intel.com>
Date: Tue Oct 03 15:09:01 2017

viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererPixelTest

BUG= 757291 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ice931c4d32788ad0dfbf98604fdf487aa1dad75c
Reviewed-on: https://chromium-review.googlesource.com/693617
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506042}
[modify] https://crrev.com/a8c70d98dd3ee4bdf81614ffc835888079eaacda/cc/test/pixel_test.cc
[modify] https://crrev.com/a8c70d98dd3ee4bdf81614ffc835888079eaacda/cc/test/pixel_test.h
[modify] https://crrev.com/a8c70d98dd3ee4bdf81614ffc835888079eaacda/components/viz/service/display/renderer_pixeltest.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ddea27ce57e8f38460cdfc1c83bfcb480ee1d7c

commit 4ddea27ce57e8f38460cdfc1c83bfcb480ee1d7c
Author: Xu Xing <xing.xu@intel.com>
Date: Wed Oct 11 02:45:16 2017

viz: Move CreateResourceFromTextureMailbox from Display to LayerTree

BUG= 757291 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0bb7f300993a15fb143c444fa521cc58e20e17bb
Reviewed-on: https://chromium-review.googlesource.com/707015
Commit-Queue: Xing Xu <xing.xu@intel.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507877}
[modify] https://crrev.com/4ddea27ce57e8f38460cdfc1c83bfcb480ee1d7c/cc/resources/layer_tree_resource_provider.cc
[modify] https://crrev.com/4ddea27ce57e8f38460cdfc1c83bfcb480ee1d7c/cc/resources/layer_tree_resource_provider.h
[modify] https://crrev.com/4ddea27ce57e8f38460cdfc1c83bfcb480ee1d7c/cc/resources/resource_provider.cc
[modify] https://crrev.com/4ddea27ce57e8f38460cdfc1c83bfcb480ee1d7c/cc/resources/resource_provider.h
[modify] https://crrev.com/4ddea27ce57e8f38460cdfc1c83bfcb480ee1d7c/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/4ddea27ce57e8f38460cdfc1c83bfcb480ee1d7c/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/4ddea27ce57e8f38460cdfc1c83bfcb480ee1d7c/cc/test/render_pass_test_utils.h
[modify] https://crrev.com/4ddea27ce57e8f38460cdfc1c83bfcb480ee1d7c/components/viz/service/display/renderer_pixeltest.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d36381baf1d57d2858415be76b125382b0a7a43

commit 4d36381baf1d57d2858415be76b125382b0a7a43
Author: Xu Xing <xing.xu@intel.com>
Date: Thu Jan 11 01:59:34 2018

[viz] Split ScopedSkSurface and misc from ResourceProvider to LayerTree and Display

ScopedSkSurface and Settings into LayerTree.
Overlay related into Display.

BUG= 757291 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iea698c8d4a3e55d56abd337108ca8af39dc46758
Reviewed-on: https://chromium-review.googlesource.com/859106
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#528531}
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/raster/staging_buffer_pool.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/raster/staging_buffer_pool.h
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/raster/staging_buffer_pool_unittest.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/resources/display_resource_provider.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/resources/display_resource_provider.h
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/resources/layer_tree_resource_provider.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/resources/layer_tree_resource_provider.h
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/resources/resource_provider.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/resources/resource_provider.h
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/test/fake_resource_provider.h
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/cc/test/pixel_test.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/components/viz/service/display/ca_layer_overlay.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/components/viz/service/display/ca_layer_overlay.h
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/components/viz/service/display/dc_layer_overlay.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/components/viz/service/display/dc_layer_overlay.h
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/components/viz/service/display/display.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/4d36381baf1d57d2858415be76b125382b0a7a43/components/viz/service/display/vulkan_renderer.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09eabdf76d1fa50fbcaf608f64fc180e8bc979fd

commit 09eabdf76d1fa50fbcaf608f64fc180e8bc979fd
Author: Xu Xing <xing.xu@intel.com>
Date: Wed Jan 17 05:27:36 2018

[viz] Move InUseByConsumer to LayerTree and Display

BUG= 757291 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I0024bc5fae4519d1453d1b0d4585b5a08cdbe20e
Reviewed-on: https://chromium-review.googlesource.com/863903
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#529624}
[modify] https://crrev.com/09eabdf76d1fa50fbcaf608f64fc180e8bc979fd/cc/resources/display_resource_provider.cc
[modify] https://crrev.com/09eabdf76d1fa50fbcaf608f64fc180e8bc979fd/cc/resources/display_resource_provider.h
[modify] https://crrev.com/09eabdf76d1fa50fbcaf608f64fc180e8bc979fd/cc/resources/layer_tree_resource_provider.cc
[modify] https://crrev.com/09eabdf76d1fa50fbcaf608f64fc180e8bc979fd/cc/resources/layer_tree_resource_provider.h
[modify] https://crrev.com/09eabdf76d1fa50fbcaf608f64fc180e8bc979fd/cc/resources/resource_provider.cc
[modify] https://crrev.com/09eabdf76d1fa50fbcaf608f64fc180e8bc979fd/cc/resources/resource_provider.h
[modify] https://crrev.com/09eabdf76d1fa50fbcaf608f64fc180e8bc979fd/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/09eabdf76d1fa50fbcaf608f64fc180e8bc979fd/components/viz/service/display/overlay_unittest.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f71a38f48f1f58ebd8496d6fa25965a29125562

commit 0f71a38f48f1f58ebd8496d6fa25965a29125562
Author: Xu Xing <xing.xu@intel.com>
Date: Sat Jan 20 00:00:36 2018

[viz] Private BindForSampling

Also refine GetActiveTextureUnit and FakeResourceProvider.
This was to followup https://chromium-review.googlesource.com/c/chromium/src/+/859106.

BUG= 757291 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I40dd516e12c35a2388e9c857e87dbe83e638804c
Reviewed-on: https://chromium-review.googlesource.com/875530
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#530671}
[modify] https://crrev.com/0f71a38f48f1f58ebd8496d6fa25965a29125562/cc/resources/display_resource_provider.cc
[modify] https://crrev.com/0f71a38f48f1f58ebd8496d6fa25965a29125562/cc/resources/display_resource_provider.h
[modify] https://crrev.com/0f71a38f48f1f58ebd8496d6fa25965a29125562/cc/resources/layer_tree_resource_provider.cc
[modify] https://crrev.com/0f71a38f48f1f58ebd8496d6fa25965a29125562/cc/test/fake_resource_provider.h

Comment 21 by xing...@intel.com, Jan 29 2018

Status: Fixed (was: Started)
►

Sign in to add a comment