New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757284 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools: Network request priority column isn't sorted properly

Reported by karolina...@envato.com, Aug 21 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.101 Safari/537.36

Steps to reproduce the problem:
1. Open Developer Tools on any website
2. In `Network` tab right-click the table title to enable `Priority` column
3. Click on `Priority` heading to sort ascending or descending manner

What is the expected behavior?
For descending sorting the order should be: 

- Highest
- High
- Medium
- Low
- Lowest

For ascending sorting the order should be: 

- Lowest
- Low
- Medium
- High
- Highest

What went wrong?
Sorting in any way produces mixed, unordered results.

Did this work before? N/A 

Chrome version: 60.0.3112.101  Channel: stable
OS Version: OS X 10.11.6
Flash Version: 

Thank you for looking into this issue! <3
 
Screen Shot 2017-08-21 at 12.06.57 PM.png
274 KB View Download
Labels: Needs-Triage-M60
This goes to allada@
Cc: kkaluri@chromium.org ovkadu...@gmail.com
Labels: -Type-Bug -Pri-2 hasbisect-per-revision M-62 OS-Linux OS-Windows Pri-1 Type-Bug-Regression
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on Windows 10, Ubuntu 14.04 & Mac 10.12.6 with chrome version #60.0.3112.113 and also in current canary version #62.0.3197.4
Issue is broken in M57.

Bisect Info:
===========
Good build : 57.0.2964.0,  Revision Range -440723
Bad build  : 57.0.2965.0,  Revision Range -440816

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/4573aaf76ac901bd48fc2eaa5314a206a04a6cc5..3c8def3b7ec0e9be5f76c7881fdffd574c72e0c7

The suspecting Change Log is :
-----------
Review-Url: https://codereview.chromium.org/2562193002

Note: Unable to find the ovkadurin@ in the owners list, hence cc'ing him and assigning it to the one of the reviewers.

dgozman@- Could you please look into this issue and assign it to the concern owner.

Thank You...

Cc: dgozman@chromium.org
Owner: allada@chromium.org
Owner: l...@chromium.org

Comment 6 by l...@chromium.org, Dec 14 2017

Status: Fixed (was: Assigned)
Summary: DevTools: Network request priorities aren't sorted properly (was: Request priorities aren't sorted properly)
Thanks for the report.  I just tried this out on versions 62.0.3202.94 and 65.0.3293.0, and it looks like the priorities are sorted fine, from Lowest to Highest.

Could you please check it out on a newer Chrome version and comment if it's still broken?

Comment 7 by l...@chromium.org, Dec 14 2017

Status: Assigned (was: Fixed)
Summary: DevTools: Network request priority column isn't sorted properly (was: DevTools: Network request priorities aren't sorted properly)
Ahh, sorry my bad.  I was looking at the autocomplete suggestions, not at the Priority column.  It's still broken, I'll take a look!
Yep. Definitely still broken. 

Start - Calibre 2017-12-14 12-22-13.png
319 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf0a72a1e09af665856d9f29828661a1f8e1de03

commit cf0a72a1e09af665856d9f29828661a1f8e1de03
Author: Erik Luo <luoe@chromium.org>
Date: Thu Dec 21 19:02:17 2017

DevTools: fix sorting by priority in Network panel

Bug:  757284 
Change-Id: I7c19a0f2430fc6d01a32078a07d2c91c02974a86
Reviewed-on: https://chromium-review.googlesource.com/837030
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525758}
[modify] https://crrev.com/cf0a72a1e09af665856d9f29828661a1f8e1de03/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Comment 10 by l...@chromium.org, Dec 21 2017

Status: Fixed (was: Assigned)
Cc: rbasuvula@chromium.org
Labels: TE-Verified-M65 TE-Verified-65.0.3309.0
Tested the issue on Windows-7, Ubuntu 14.04 and Mac OS 10.12.6 using chrome latest Canary M65-65.0.3309.0 by following steps mentioned in the original comment. Observed that Network request priority column is sorted properly displaying as expected. Hence adding TE-Verified label.

Please find the screen cast for reference.

Thank you!
757284.ogv
19.4 MB Download

Sign in to add a comment