New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757277 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Convert database_messages.h from IPC to Mojo and onion soup resulting classes.

Project Member Reported by slangley@chromium.org, Aug 21 2017

Issue description

Looks fairly straight forward to convert these from IPC to MOJO and then move out of the //content layer,

https://cs.chromium.org/chromium/src/content/common/database_messages.h
https://cs.chromium.org/chromium/src/content/child/db_message_filter.h
 

Comment 1 by dcheng@chromium.org, Aug 21 2017

Cc: dcheng@chromium.org

Comment 2 by michaeln@google.com, Aug 23 2017

Here are some notes about the set of DB messages...

Threading considerations:

Each blink::Document has a dedicated database thread for sqlite3 usage. If
multiple blink::Databases are opened by a document, all of the sqlite3 handles
are used on the same background thread.

The browser process pushes information to the renderer and into blink thru the
WebDatabase static methods. Currently, these methods are invoked on the IPC
thread.

There the relative ordering of the browser to renderer msgs matter:
* DatabaseOpened must preceded DatabaseOpenFile
* DatabaseModified cannot occur after DatabaseClosed
* and of course DatabaseOpened must precede DatabaseClosed

brower->renderer, IPC thread, mostly quota related

  BLINK_EXPORT static void UpdateDatabaseSize(const WebSecurityOrigin&,
                                              const WebString& name,
                                              long long size);

  BLINK_EXPORT static void CloseDatabaseImmediately(
      const WebSecurityOrigin&,
      const WebString& database_name);

renderer->browser, background DB threads, mostly vfs related

  static blink::Platform::FileHandle DatabaseOpenFile(
      const blink::WebString& vfs_file_name,
      int desired_flags,
      IPC::SyncMessageFilter* sync_message_filter);
  static int DatabaseDeleteFile(
      const blink::WebString& vfs_file_name,
      bool sync_dir,
      IPC::SyncMessageFilter* sync_message_filter);
  static long DatabaseGetFileAttributes(
      const blink::WebString& vfs_file_name,
      IPC::SyncMessageFilter* sync_message_filter);
  static long long DatabaseGetFileSize(
      const blink::WebString& vfs_file_name,
      IPC::SyncMessageFilter* sync_message_filter);
  static long long DatabaseGetSpaceAvailable(
      const blink::WebSecurityOrigin& origin,
      IPC::SyncMessageFilter* sync_message_filter);
  static bool DatabaseSetFileSize(const blink::WebString& vfs_file_name,
                                  int64_t size,
                                  IPC::SyncMessageFilter* sync_message_filter);



renderer->browser, Mix of main and db threads, the DatabaseObserver messages

  virtual void DatabaseOpened(const WebSecurityOrigin&,
                              const WebString& database_name,
                              const WebString& database_display_name,
                              unsigned long estimated_size) = 0;
  virtual void DatabaseModified(const WebSecurityOrigin&,
                                const WebString& database_name) = 0;
  virtual void DatabaseClosed(const WebSecurityOrigin&,
                              const WebString& database_name) = 0;

  void HandleSqliteError(origin, string name, int error)

Cc: michaeln@chromium.org
Cheers Michael - I will of course include you on all related CLs. 

--Stuart
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab1d634af0bc88f21d60d2609b7e8d0fd352b0a9

commit ab1d634af0bc88f21d60d2609b7e8d0fd352b0a9
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Aug 23 02:12:34 2017

Removed unused DatabaseMsg IPC messages.

The messages DatabaseMsg_UpdateSpaceAvailable & DatabaseMsg_ResetSpaceAvailable
are not being used and can be removed.

This is preliminary work for Mojofying the rest of this interface.

Bug: 757277
Change-Id: I2842a71b48ba5a8f07ed8ce6eb6d1792749ce13a
Reviewed-on: https://chromium-review.googlesource.com/622457
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496560}
[modify] https://crrev.com/ab1d634af0bc88f21d60d2609b7e8d0fd352b0a9/content/child/db_message_filter.cc
[modify] https://crrev.com/ab1d634af0bc88f21d60d2609b7e8d0fd352b0a9/content/child/db_message_filter.h
[modify] https://crrev.com/ab1d634af0bc88f21d60d2609b7e8d0fd352b0a9/content/common/database_messages.h

Hi Stuart, thanx for doing this!
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/849079adeeaa989c2aca2b7aadbf5f7c165773be

commit 849079adeeaa989c2aca2b7aadbf5f7c165773be
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Aug 28 02:02:50 2017

Remove dead code from public/web/WebDatabase and dependencies.

Now that the relevant IPC messages have been removed we can cleanup unused code
from public/web/WebDatabase, specifically UpdateSpaceAvailable and
ResetSpaceAvailable.

As WebDatabase was the only called of these methods in QuotaTracker as well we
can remove UpdateSpaceAvailableToOrigin and ResetSpaceAvailableToOrigin.

I did not change the method GetDatabaseSizeAndSpaceAvailableToOrigin as the
current implementation in Platform make an IPC back to the browser to get the
space that is available for the origin.

Also, fixed some linter related header issues.

Bug: 757277
Change-Id: I19c59d119451e90d6dde0895c31cdf2f773b821e
Reviewed-on: https://chromium-review.googlesource.com/627527
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497685}
[modify] https://crrev.com/849079adeeaa989c2aca2b7aadbf5f7c165773be/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/849079adeeaa989c2aca2b7aadbf5f7c165773be/third_party/WebKit/Source/modules/exported/WebDatabase.cpp
[modify] https://crrev.com/849079adeeaa989c2aca2b7aadbf5f7c165773be/third_party/WebKit/Source/modules/webdatabase/QuotaTracker.cpp
[modify] https://crrev.com/849079adeeaa989c2aca2b7aadbf5f7c165773be/third_party/WebKit/Source/modules/webdatabase/QuotaTracker.h
[modify] https://crrev.com/849079adeeaa989c2aca2b7aadbf5f7c165773be/third_party/WebKit/Source/modules/webdatabase/QuotaTrackerTest.cpp
[modify] https://crrev.com/849079adeeaa989c2aca2b7aadbf5f7c165773be/third_party/WebKit/public/web/WebDatabase.h

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6771c9019170d94bcea38efa179e4c3d1a0dc0c4

commit 6771c9019170d94bcea38efa179e4c3d1a0dc0c4
Author: Stuart Langley <slangley@chromium.org>
Date: Fri Sep 01 11:23:30 2017

Mojofy the DatabaseMsg IPC used for WebDatabase calls from browser to renderer.

This CL is a straight forward conversion of the DatabaseMsg IPC calls to mojo.
As the name content::Database is already taken the mojo interface was called
WebDatabase and the implementation WebDatabaseImpl. Once onion souped it is
likely that this class will replace the existing blink::WebDatabase public
interface.

The mojo conversion is slightly complicated as the setup and teardown of the
client side binding needs to occur on different threads to where the interface
is called.

Bug: 757277
Change-Id: Idd6ae95fcd34732751aad2a6c5a7759c591f04e7
Reviewed-on: https://chromium-review.googlesource.com/622458
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499165}
[modify] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/browser/renderer_host/database_message_filter.cc
[modify] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/browser/renderer_host/database_message_filter.h
[modify] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/child/BUILD.gn
[delete] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/content/child/db_message_filter.cc
[delete] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/content/child/db_message_filter.h
[add] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/child/web_database_impl.cc
[add] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/child/web_database_impl.h
[modify] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/common/BUILD.gn
[modify] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/common/database_messages.h
[add] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/common/web_database.mojom
[modify] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/6771c9019170d94bcea38efa179e4c3d1a0dc0c4/content/renderer/render_thread_impl.h

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd

commit 0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd
Author: Stuart Langley <slangley@chromium.org>
Date: Sat Sep 16 03:57:52 2017

Mojofy the DatabaseHostMessage sync IPC messages.

This patch is the first step in mojofying the DatabaseHostMessage's. It converts
the sync messages first, which are:

- DatabaseHostMsg_OpenFile
- DatabaseHostMsg_DeleteFile
- DatabaseHostMsg_GetFileAttributes
- DatabaseHostMsg_GetFileSize
- DatabaseHostMsg_GetSpaceAvailable
- DatabaseHostMsg_SetFileSize

Interesting challenges included:

- The call to OpenFile actually blocks the main thread. This means that we need
  to initialize the mojo request in the RendererBlinkPlatformImpl to prevent
  a deadlock.
- The calls to RendererBlinkPlatformImpl::Database* occur on different threads
  so we need to use a ThreadSafeWebDatabaseHostPtr with its own task runner.
- Sync calls to a ThreadSafeInterfacePtr actually block the task runner, so we
  will in effect serialize all of the sync calls.

Bug: 757277
Change-Id: Ic5d8aeb8b02672abed83256ada5e8798fc5fd224
Reviewed-on: https://chromium-review.googlesource.com/654561
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502485}
[modify] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/browser/BUILD.gn
[modify] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/browser/renderer_host/database_message_filter.cc
[modify] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/browser/renderer_host/database_message_filter.h
[modify] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/browser/renderer_host/render_process_host_impl.cc
[add] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/browser/renderer_host/web_database_host_impl.cc
[add] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/browser/renderer_host/web_database_host_impl.h
[modify] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/child/BUILD.gn
[delete] https://crrev.com/5487d51f9175a69613e7b715be437ece3c1d88e5/content/child/database_util.cc
[delete] https://crrev.com/5487d51f9175a69613e7b715be437ece3c1d88e5/content/child/database_util.h
[modify] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/common/database_messages.h
[modify] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/common/web_database.mojom
[modify] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/0454b95836e0d396f3cfe61b7b616ee5b0e6c0dd/content/renderer/renderer_blink_platform_impl.h

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c

commit 9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Oct 10 12:37:53 2017

Mojofy the rest of database_messages and database_message_filter.

This patch moves the remaining database_message IPC messages to mojo. It uses
the same InterfacePtr on the renderer side as the SYNC messages that were
converted to mojo previously, which is a ThreadSafeInterfacePtr so messages
can be sent from any thread.

Bug: 757277
Change-Id: I83e5692b0524eec4fafd8ea86c0160956a653f9f
Reviewed-on: https://chromium-review.googlesource.com/676924
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507647}
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/browser/BUILD.gn
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/browser/bad_message.h
[delete] https://crrev.com/2850f29f62c0807c779d567f681b3fe3119b1d04/content/browser/renderer_host/database_message_filter.cc
[delete] https://crrev.com/2850f29f62c0807c779d567f681b3fe3119b1d04/content/browser/renderer_host/database_message_filter.h
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/browser/renderer_host/web_database_host_impl.cc
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/browser/renderer_host/web_database_host_impl.h
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/child/web_database_observer_impl.cc
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/child/web_database_observer_impl.h
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/common/BUILD.gn
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/common/content_message_generator.h
[delete] https://crrev.com/2850f29f62c0807c779d567f681b3fe3119b1d04/content/common/database_messages.h
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/common/web_database.mojom
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/9655ccf44e9cfd1339c2bb6d1b2e7c65b4321a9c/content/renderer/renderer_blink_platform_impl.h

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608

commit 7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Oct 31 03:55:20 2017

Onion Soup the web_database.mojom interface.

This appears to be the first former control message that has been Onion Souped, so
I needed to create the infrastructure to add the interface to a BinderRegistry
and then add this to the service manager.

I also needed to expose the IO thread via Platform so that the mojo interface
can be created on it, to maintain the previous implementation.

Most of the rest of the changes are just a result of changing the namespace from
content::mojom to blink::mojom.

Bug: 757277
Change-Id: I1e8a0606c19cc715a4890d27c922cfa26a84c4cf
Reviewed-on: https://chromium-review.googlesource.com/727487
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512739}
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/browser/DEPS
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/browser/renderer_host/web_database_host_impl.cc
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/browser/renderer_host/web_database_host_impl.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/child/blink_platform_impl.cc
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/child/blink_platform_impl.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/common/BUILD.gn
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/public/test/render_view_test.cc
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/renderer/BUILD.gn
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/renderer/mojo/blink_interface_registry_impl.cc
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/renderer/mojo/blink_interface_registry_impl.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/renderer/render_thread_impl.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/renderer/renderer_blink_platform_impl.h
[delete] https://crrev.com/67e9dcd2c4d2af8044e22b20564b265b0db4ac90/content/renderer/web_database_impl.cc
[delete] https://crrev.com/67e9dcd2c4d2af8044e22b20564b265b0db4ac90/content/renderer/web_database_impl.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/renderer/web_database_observer_impl.cc
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/renderer/web_database_observer_impl.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/media/blink/run_all_unittests.cc
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/services/data_decoder/image_decoder_impl_unittest.cc
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/controller/BlinkInitializer.cpp
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/core/CoreInitializer.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/modules/exported/BUILD.gn
[delete] https://crrev.com/67e9dcd2c4d2af8044e22b20564b265b0db4ac90/third_party/WebKit/Source/modules/exported/WebDatabase.cpp
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/modules/webdatabase/BUILD.gn
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/modules/webdatabase/DEPS
[add] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/modules/webdatabase/WebDatabaseImpl.cpp
[add] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/modules/webdatabase/WebDatabaseImpl.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/platform/exported/InterfaceRegistry.cpp
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/Source/platform/wtf/Functional.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/public/platform/InterfaceRegistry.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/public/platform/Platform.h
[add] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/public/platform/modules/webdatabase/OWNERS
[rename] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/public/platform/modules/webdatabase/web_database.mojom
[delete] https://crrev.com/67e9dcd2c4d2af8044e22b20564b265b0db4ac90/third_party/WebKit/public/web/WebDatabase.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/third_party/WebKit/public/web/WebKit.h
[modify] https://crrev.com/7b8dc77cd5f2d71c62a6baf4dff4fa63b69b7608/tools/v8_context_snapshot/v8_context_snapshot_generator.cc

Status: Fixed (was: Started)
Status: Started (was: Fixed)
Needs onion souping.
Owner: ----
Status: Available (was: Started)

Sign in to add a comment