RTCPeerConnection.close() throws, but it should not according to standard
Reported by
robert.k...@gmail.com,
Aug 20 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0 Steps to reproduce the problem: 1. Open a RTCPeerConnection 2. call close on the object 3. call close again What is the expected behavior? Second call to close should have no effect. Spec*) says in point 2: If connection's [[isClosed]] slot is true, abort these steps. *) http://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-close What went wrong? Application crashes with uncaught exception: ``` Error: Failed to execute 'close' on 'RTCPeerConnection': The RTCPeerConnection's signalingState is 'closed'. ``` Did this work before? No Does this work in other browsers? Yes Chrome version: 58.0.3029.110 (Developer Build) (64-bit) Channel: n/a OS Version: nixos Flash Version: Firefox works as expected and ignores the second call to close().
,
Aug 21 2017
,
Aug 21 2017
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc65039dd61f8b7a86ef93d8424b4324d20323c3 commit cc65039dd61f8b7a86ef93d8424b4324d20323c3 Author: Guido Urdaneta <guidou@chromium.org> Date: Wed Aug 23 11:43:50 2017 Do not throw on RTCPeerConnection.close() BUG= 757254 Change-Id: Ic9fa9c18ea1d215fb0f5f99df197bbe4fad1fd38 Reviewed-on: https://chromium-review.googlesource.com/623408 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#496657} [add] https://crrev.com/cc65039dd61f8b7a86ef93d8424b4324d20323c3/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-close.html [modify] https://crrev.com/cc65039dd61f8b7a86ef93d8424b4324d20323c3/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp [modify] https://crrev.com/cc65039dd61f8b7a86ef93d8424b4324d20323c3/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h [modify] https://crrev.com/cc65039dd61f8b7a86ef93d8424b4324d20323c3/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
,
Aug 23 2017
That was fast. Many thanks! :-)
,
Aug 23 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nyerramilli@google.com
, Aug 21 2017