New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757250 link

Starred by 1 user
Status: Fixed
Owner:
█ lpz@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

components_unittests depends on almost all of //chrome

Project Member Reported by brettw@chromium.org, Aug 20 2017 
https://chromium-review.googlesource.com/c/525854 introduced a dependency from //components/safe_browsing/triggers to //chrome/test:test_support. This is a layering violation.

It also means that almost all of Chrome is built for components_unittests which is very bad for build performance, and is a major regression for people working in components who want to run tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db71922da8caabc15e3c154b64cd27abcb436d38

commit db71922da8caabc15e3c154b64cd27abcb436d38
Author: Luke Zielinski <lpz@chromium.org>
Date: Sun Aug 20 23:06:36 2017

Remove unnecessary dep from components to chrome.

This dep was accidentally introduced in
chromium-review.googlesource.com/c/525854

TBR=jialiul@chromium.org

Bug:  757250 
Change-Id: I71d88695691e72597e012c58ae8e334836fd60c4
Reviewed-on: https://chromium-review.googlesource.com/621544
Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495854}
[modify] https://crrev.com/db71922da8caabc15e3c154b64cd27abcb436d38/components/safe_browsing/triggers/BUILD.gn

Comment 2 by lpz@chromium.org, Aug 21 2017

Status: Fixed (was: Assigned)
Dependency removed. Apologies, it seems it was accidentally leftover in that CL.

Comment 3 by brettw@chromium.org, Aug 21 2017 

Thanks for the fast turnaround!
►

Sign in to add a comment