New issue
Advanced search Search tips

Issue 757247 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 755391



Sign in to add a comment

2.3% regression in thread_raster_cpu_time_per_frame thread_times.tough_compositor_cases JS_FULL_SCREEN_INVALIDATION 2017-08-16

Project Member Reported by vmi...@chromium.org, Aug 20 2017

Issue description

Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Aug 20 2017

Cc: mtklein@chromium.org
Owner: mtklein@chromium.org

=== Auto-CCing suspected CL author mtklein@chromium.org ===

Hi mtklein@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Mike Klein
  Commit : 25954b64c066b143819bc720b20a9b4287042ecc
  Date   : Tue Aug 15 22:28:17 2017
  Subject: explicitly vectorize sk_memset{16,32,64}

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : thread_times.tough_compositor_cases
  Metric       : thread_raster_cpu_time_per_frame/http___jsbin.com_beqojupo_1_quiet?JS_FULL_SCREEN_INVALIDATION
  Change       : 4.03% | 9.84402237322 -> 10.2402488298

Revision                             Result                    N
chromium@494491                      9.84402 +- 0.0590071      6      good
chromium@494568                      9.82677 +- 0.0479513      6      good
chromium@494606                      9.77828 +- 0.0765666      6      good
chromium@494616                      9.79393 +- 0.156408       6      good
chromium@494621                      9.82699 +- 0.0829652      6      good
chromium@494621,skia@32491566da      9.81599 +- 0.123988       6      good
chromium@494621,skia@135a1b10fe      9.70549 +- 0.0841867      6      good
chromium@494621,skia@25954b64c0      10.0856 +- 0.0812755      6      bad       <--
chromium@494622                      10.0574 +- 0.0676163      6      bad
chromium@494623                      10.0595 +- 0.102297       6      bad
chromium@494625                      10.0945 +- 0.110897       6      bad
chromium@494644                      10.1101 +- 0.100122       6      bad
chromium@494796                      10.2402 +- 0.067656       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...jsbin.com.beqojupo.1.quiet.JS.FULL.SCREEN.INVALIDATION thread_times.tough_compositor_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970718421393161840


For feedback, file a bug with component Speed>Bisection

Comment 3 by vmi...@chromium.org, Aug 21 2017

Blocking: 755391
Status: WontFix (was: Assigned)
"explicitly vectorize sk_memset{16,32,64}" was a huge win on desktop Linux, where we rely on software rasterization much more than Android.

Sign in to add a comment