For memory usage and platform consistency, we want to standardize on base::circular_deque.
For memory usage and platform consistency, we want to standardize on base::circular_deque. https://docs.google.com/document/d/1YL1FORFMWo0FK0lMg7WsImnjNQ3ZpY0nK0NHGjkeHT4/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24b9b406e912cee0b6726b1f627a4ca3a2d9a652 commit 24b9b406e912cee0b6726b1f627a4ca3a2d9a652 Author: Brett Wilson <brettw@chromium.org> Date: Tue Aug 22 01:22:06 2017 Replace some uses of std::deque with base::circular_deque in componnets. This is roughly half of the uses in //components. Some of the uses require deque and TODOs have been added with the reason why. #include <algorithm> is added to circular_deque.h for the calls to std::max. Previous uses apparently included this some other way. Some nontrivial updates were made to dependency_graph.cc to simplify the code. In trying to study what this code's requirements were to see if the usage could be replaced, I realized it could be simplified by using the (relatively new) base::Erase function. The constructors that take a range are also used, instead of the existing std::copy with a back_inserter iterator. Bug: 757232 Change-Id: I712b1368f5719dfd0bc79421ef3d0d8f58e8239f Reviewed-on: https://chromium-review.googlesource.com/622887 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#496164} [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/base/containers/circular_deque.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/app_modal/app_modal_dialog_queue.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/domain_reliability/context.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/download/internal/download_service_impl.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/drive/event_logger.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/drive/file_change.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/drive/job_queue.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/exo/shell_surface.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/exo/wayland/clients/rects.cc [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/gcm_driver/gcm_stats_recorder_android.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/gcm_driver/gcm_stats_recorder_impl.cc [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/gcm_driver/gcm_stats_recorder_impl.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/guest_view/browser/guest_view_base.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/guest_view/renderer/guest_view_container.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/keyed_service/core/dependency_graph.cc [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/machine_intelligence/ranker_model_loader_unittest.cc [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/nacl/browser/nacl_browser.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/nacl/renderer/plugin/pnacl_translate_thread.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/ntp_snippets/remote/remote_suggestions_fetcher_impl_unittest.cc [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/ntp_snippets/remote/remote_suggestions_provider_impl.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/omnibox/browser/history_match.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/proximity_auth/messenger_impl.h [modify] https://crrev.com/24b9b406e912cee0b6726b1f627a4ca3a2d9a652/components/signin/core/browser/gaia_cookie_manager_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72d71de71b59d95c69866afebd8dc070e45c12ce commit 72d71de71b59d95c69866afebd8dc070e45c12ce Author: Henrik Boström <hbos@chromium.org> Date: Tue Aug 22 13:00:57 2017 Revert "Replace some uses of std::deque with base::circular_deque in componnets." This reverts commit 24b9b406e912cee0b6726b1f627a4ca3a2d9a652. Reason for revert: Speculative revert, this is the only patch touching gcm files in the commit range that causes consistent failures on the following tests on https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20CFI/builds/1265 GCMStatsRecorderImplTest.RegistrationTest GCMStatsRecorderImplTest.ConnectionTest GCMDriverFunctionalTest.EncryptedMessageReceivedError GCMStatsRecorderImplTest.ClearLogTest GCMStatsRecorderImplTest.StartStopRecordingTest GCMStatsRecorderImplTest.RecordReceivingTest GCMStatsRecorderImplTest.RecordDecryptionFailureTest GCMStatsRecorderImplTest.CheckinTest GCMStatsRecorderImplTest.RecordSendingTest Original change's description: > Replace some uses of std::deque with base::circular_deque in componnets. > > This is roughly half of the uses in //components. Some of the uses require > deque and TODOs have been added with the reason why. > > #include <algorithm> is added to circular_deque.h for the calls to > std::max. Previous uses apparently included this some other way. > > Some nontrivial updates were made to dependency_graph.cc to simplify the > code. In trying to study what this code's requirements were to see if > the usage could be replaced, I realized it could be simplified > by using the (relatively new) base::Erase function. The constructors > that take a range are also used, instead of the existing std::copy with a > back_inserter iterator. > > Bug: 757232 > Change-Id: I712b1368f5719dfd0bc79421ef3d0d8f58e8239f > Reviewed-on: https://chromium-review.googlesource.com/622887 > Reviewed-by: Elliot Glaysher <erg@chromium.org> > Commit-Queue: Brett Wilson <brettw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496164} TBR=brettw@chromium.org,erg@chromium.org Change-Id: I3adccbfad4e634e12a6b64bc3b9903a60ca7cb70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 757232 Reviewed-on: https://chromium-review.googlesource.com/625696 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#496287} [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/base/containers/circular_deque.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/app_modal/app_modal_dialog_queue.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/domain_reliability/context.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/download/internal/download_service_impl.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/drive/event_logger.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/drive/file_change.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/drive/job_queue.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/exo/shell_surface.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/exo/wayland/clients/rects.cc [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/gcm_driver/gcm_stats_recorder_android.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/gcm_driver/gcm_stats_recorder_impl.cc [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/gcm_driver/gcm_stats_recorder_impl.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/guest_view/browser/guest_view_base.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/guest_view/renderer/guest_view_container.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/keyed_service/core/dependency_graph.cc [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/machine_intelligence/ranker_model_loader_unittest.cc [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/nacl/browser/nacl_browser.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/nacl/renderer/plugin/pnacl_translate_thread.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/ntp_snippets/remote/remote_suggestions_fetcher_impl_unittest.cc [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/ntp_snippets/remote/remote_suggestions_provider_impl.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/omnibox/browser/history_match.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/proximity_auth/messenger_impl.h [modify] https://crrev.com/72d71de71b59d95c69866afebd8dc070e45c12ce/components/signin/core/browser/gaia_cookie_manager_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45d6f2d8ece330462a5e1964cc97900c233480dd commit 45d6f2d8ece330462a5e1964cc97900c233480dd Author: Brett Wilson <brettw@chromium.org> Date: Wed Aug 23 17:01:24 2017 Replace some uses of std::deque with base::circular_deque in components. This is roughly half of the uses in //components. Some of the uses require deque and TODOs have been added with the reason why. #include <algorithm> is added to circular_deque.h for the calls to std::max. Previous uses apparently included this some other way. Some nontrivial updates were made to dependency_graph.cc to simplify the code. In trying to study what this code's requirements were to see if the usage could be replaced, I realized it could be simplified by using the (relatively new) base::Erase function. The constructors that take a range are also used, instead of the existing std::copy with a back_inserter iterator. Bug: 757232 TBR: erg@chromium.org Reland of https://chromium-review.googlesource.com/622887 which should have been fixed by https://chromium-review.googlesource.com/627017 Change-Id: Iab83d5ec264f65786f39985e8bdfcdaf1e4a2762 Reviewed-on: https://chromium-review.googlesource.com/627187 Reviewed-by: Brett Wilson <brettw@chromium.org> Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#496716} [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/base/containers/circular_deque.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/app_modal/app_modal_dialog_queue.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/domain_reliability/context.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/download/internal/download_service_impl.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/drive/event_logger.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/drive/file_change.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/drive/job_queue.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/exo/shell_surface.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/exo/wayland/clients/rects.cc [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/gcm_driver/gcm_stats_recorder_android.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/gcm_driver/gcm_stats_recorder_impl.cc [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/gcm_driver/gcm_stats_recorder_impl.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/guest_view/browser/guest_view_base.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/guest_view/renderer/guest_view_container.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/keyed_service/core/dependency_graph.cc [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/machine_intelligence/ranker_model_loader_unittest.cc [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/nacl/browser/nacl_browser.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/nacl/renderer/plugin/pnacl_translate_thread.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/ntp_snippets/remote/remote_suggestions_fetcher_impl_unittest.cc [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/ntp_snippets/remote/remote_suggestions_provider_impl.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/omnibox/browser/history_match.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/proximity_auth/messenger_impl.h [modify] https://crrev.com/45d6f2d8ece330462a5e1964cc97900c233480dd/components/signin/core/browser/gaia_cookie_manager_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/becb7b74fc4e2c18f31559ac4dc6e2e982e38565 commit becb7b74fc4e2c18f31559ac4dc6e2e982e38565 Author: Brett Wilson <brettw@chromium.org> Date: Wed Aug 30 17:37:14 2017 Convert components to use circular_deque. Converts the remaining uses of std::deque in //components Adds an implementation of base::Erase and base::EraseIf for circular_deque. Bug: 757232 Change-Id: I99948e806c92bf027aa5e20ae537b5f14635a713 Reviewed-on: https://chromium-review.googlesource.com/637130 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#498527} [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/base/containers/circular_deque.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/domain_reliability/context.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/drive/job_queue.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/keyed_service/core/dependency_graph.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/ntp_snippets/remote/remote_suggestions_fetcher_impl_unittest.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/ntp_snippets/remote/remote_suggestions_provider_impl.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/offline_pages/core/background/pick_request_task.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/offline_pages/core/background/pick_request_task.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/offline_pages/core/background/pick_request_task_unittest.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/offline_pages/core/background/request_coordinator.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/offline_pages/core/background/request_coordinator_unittest.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/offline_pages/core/background/request_queue.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/offline_pages/core/background/request_queue.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/offline_pages/core/offline_event_logger.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/omnibox/browser/history_match.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/pairing/message_buffer.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/policy/core/common/cloud/device_management_service.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/policy/core/common/remote_commands/remote_commands_service.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/signin/core/browser/gaia_cookie_manager_service.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/signin/ios/browser/account_consistency_service.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/sync/base/immutable_unittest.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/sync/engine_impl/debug_info_event_listener.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/sync/engine_impl/events/protocol_event_buffer.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/sync/model_impl/attachments/task_queue.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/sync/syncable/directory.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/sync/syncable/directory.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/sync/test/engine/mock_model_type_worker.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/viz/common/gl_helper_benchmark.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/viz/common/gl_helper_scaling.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/viz/common/gl_helper_scaling.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/viz/common/gl_helper_unittest.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/viz/service/display/gl_renderer.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/viz/service/display_embedder/buffer_queue.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/viz/service/display_embedder/buffer_queue_unittest.cc [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/wallpaper/wallpaper_manager_base.h [modify] https://crrev.com/becb7b74fc4e2c18f31559ac4dc6e2e982e38565/components/web_modal/web_contents_modal_dialog_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712 commit 275a1378bcc24d3c3c07ef1e61faf6c34eeb4712 Author: Brett Wilson <brettw@chromium.org> Date: Fri Sep 01 20:27:54 2017 Convert std::deque to base::circular_deque in //chrome Three objects were converted to be move-only (from completely not movable nor copyable) which is required by circular_deque. See these files: - base/task_scheduler/task.h - chrome/browser/notifications/notification_permission_context.cc - chrome/profiling/memlog_stream_parser.h Changes affected typedefs to using statements, and in cases where there were adjacent typedefs, those were changed as well. Bug: 757232 Change-Id: Ia7ec0895dbfdbeec5ac3472108d88548086dd81a Reviewed-on: https://chromium-review.googlesource.com/644488 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#499279} [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/base/task_scheduler/task.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/base/task_scheduler/task.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/after_startup_task_utils.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/android/data_usage/tab_data_use_entry.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/accessibility/speech_monitor.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/file_manager/snapshot_manager.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/file_manager/snapshot_manager.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/file_system_provider/queue.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/login/ui/login_web_dialog.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/policy/device_status_collector.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/power/cpu_data_collector.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/power/power_data_collector.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/power/power_data_collector_unittest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/chromeos/settings/device_settings_service.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/extensions/api/notifications/notifications_apitest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/extensions/api/socket/tls_socket_unittest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/extensions/extension_apitest.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/extensions/user_script_listener.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/internal_auth.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/media/router/event_page_request_manager.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/media/router/event_page_request_manager.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/media/router/mojo/media_router_mojo_impl.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/media/webrtc/media_capture_devices_dispatcher.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/media/webrtc/permission_bubble_media_access_handler.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/metrics/chrome_metrics_service_client.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/notifications/notification_interactive_uitest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/notifications/notification_permission_context.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/permissions/permission_request_manager.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/permissions/permission_request_manager.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/prerender/prerender_browsertest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/prerender/prerender_test_utils.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/process_resource_usage.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/safe_browsing/local_database_manager.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/safe_browsing/protocol_manager.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/safe_browsing/safe_browsing_store.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/sync/test/integration/migration_test.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/sync_file_system/file_change.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/sync_file_system/local/local_file_change_tracker.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/sync_file_system/local/local_file_change_tracker.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/sync_file_system/local/local_file_sync_context.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/sync_file_system/task_logger.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/browser/ui/webui/chromeos/power_ui.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/chrome_watcher/system_load_estimator_unittest.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/profiling/memlog_stream_parser.cc [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/profiling/memlog_stream_parser.h [modify] https://crrev.com/275a1378bcc24d3c3c07ef1e61faf6c34eeb4712/chrome/test/chromedriver/logging.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/695adbbf4893f88202d317b93fd5970a02228a5b commit 695adbbf4893f88202d317b93fd5970a02228a5b Author: Brett Wilson <brettw@chromium.org> Date: Fri Sep 01 23:30:16 2017 Convert std::queue to base::queue in components. This is part of the "remove std::deque" project. std::queue uses std::deque as its default storage, while base::queue uses base::circular_deque. The goal is to improve memory usage (see doc linked in bug for more) Bug: 757232 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ibef56f602fc87e0d3233a7710c3d9320762d6e5f Reviewed-on: https://chromium-review.googlesource.com/644770 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#499337} [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/browser_sync/profile_sync_service_bookmark_unittest.cc [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/cast_channel/cast_transport.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/cast_channel/cast_transport_unittest.cc [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/cronet/android/cronet_url_request_context_adapter.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/cryptauth/device_capability_manager.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/cryptauth/secure_channel.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/history/core/browser/expire_history_backend.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/nacl/loader/nacl_ipc_adapter.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/ntp_snippets/contextual/contextual_suggestions_fetcher_impl.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/ntp_snippets/remote/remote_suggestions_fetcher_impl.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/offline_pages/core/task_queue.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/policy/core/common/cloud/external_policy_data_updater.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/policy/core/common/remote_commands/remote_commands_queue.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/policy/core/common/remote_commands/remote_commands_service_unittest.cc [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/previews/core/previews_black_list.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/rappor/log_uploader.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/sync/driver/data_type_manager_impl.cc [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/sync/driver/data_type_manager_impl.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/sync/engine_impl/sync_encryption_handler_impl.cc [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/sync/syncable/change_reorder_buffer.cc [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/sync/syncable/nigori_util.cc [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/update_client/update_client_internal.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/update_client/update_engine.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/update_client/url_request_post_interceptor.h [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/url_matcher/substring_set_matcher.cc [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/viz/common/gl_helper.cc [modify] https://crrev.com/695adbbf4893f88202d317b93fd5970a02228a5b/components/viz/service/surfaces/surface_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6a0c827068cf51a474ec7c2dd0228c22d337689 commit c6a0c827068cf51a474ec7c2dd0228c22d337689 Author: Brett Wilson <brettw@chromium.org> Date: Tue Sep 12 00:04:29 2017 Replace std::deque and std::queue in //net Replace uses of std::deque with base::circular_deque, and std::queue with base::queue. Uses in shared QUIC code are unchanged. We are standardizing on the base implementations to avoid the memory issues and widely varied implementations of the STL deque. Once most uses have been replaced, we will add a presubmit check to disallow the std:: variants. Three instances of deque were left where circular_deque is not appropriate (they required pointer stability across resizes). An implementation of EstimateMemoryUsage is provided for circular_deque which net required. BufferedSlice (quic_stream_send_buffer.h) was converted to be move-only (from being neither movable nor copyable) to support its membership in a circular_deque. When a typedef needed required changing, the typedef (and any adjacent one) was converted to "using" statements. The WebSocketChannel::PendingReceivedFrame declaration was moved to the .cc file since the limitations around its declaration in the header no longer exist (as explained in the removed comment). One include had to be added to a file in Chrome that was depending on net to being in <deque>. Bug: 757232 Change-Id: I8c265044ec2815deae457b299f30bf08938d0b87 Reviewed-on: https://chromium-review.googlesource.com/659317 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501105} [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/base/trace_event/memory_usage_estimator.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/chrome/browser/ui/cocoa/content_settings/cookies_tree_controller_bridge.mm [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/cookies/cookie_monster.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/cookies/cookie_monster.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/cookies/cookie_monster_unittest.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/disk_cache/simple/simple_entry_impl.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/dns/dns_transaction.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/dns/dns_transaction_unittest.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/dns/host_resolver_impl.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/dns/mdns_client_impl.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/dns/mdns_client_impl.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/dns/mdns_client_unittest.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/filter/mock_source_stream.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/ftp/ftp_ctrl_response_buffer.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/ftp/ftp_network_transaction_unittest.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/http/http_server_properties_impl.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/http2/hpack/decoder/hpack_decoder_tables.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/log/file_net_log_observer.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/nqe/observation_buffer.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/nqe/throughput_analyzer_unittest.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/proxy/mojo_proxy_resolver_impl.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/proxy/multi_threaded_proxy_resolver.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/proxy/proxy_resolver_factory_mojo_unittest.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/quic/chromium/mock_crypto_client_stream_factory.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/quic/chromium/quic_chromium_client_stream.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/quic/chromium/quic_stream_factory.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/server/http_connection.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/socket/client_socket_pool.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/socket/client_socket_pool_base.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/socket/socket_test_util.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/socket/ssl_server_socket_unittest.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/socket/transport_client_socket_pool_test_util.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/socket/udp_socket_unittest.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/socket/websocket_transport_client_socket_pool_unittest.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/spdy/chromium/spdy_read_queue.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/spdy/chromium/spdy_session.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/spdy/chromium/spdy_session.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/spdy/chromium/spdy_stream.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/spdy/chromium/spdy_write_queue.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/spdy/chromium/spdy_write_queue.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/spdy/core/hpack/hpack_header_table.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/spdy/core/priority_write_scheduler.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/url_request/sdch_dictionary_fetcher.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/url_request/url_request_throttler_entry.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/websockets/websocket_channel.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/websockets/websocket_channel.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/websockets/websocket_deflate_stream_test.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/websockets/websocket_deflater.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/websockets/websocket_deflater.h [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/websockets/websocket_inflater.cc [modify] https://crrev.com/c6a0c827068cf51a474ec7c2dd0228c22d337689/net/websockets/websocket_inflater.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2 commit cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2 Author: Brett Wilson <brettw@chromium.org> Date: Tue Sep 12 03:28:10 2017 Replace std::deque and std::queue in //content. These are replaced with the base versions base::circular_deque and base::queue. Typedefs were replaced with using statements in changed code, and adjacent typedefs were also converted. RTCTimestamps struct in rtc_video_encoder.cc was made copyable and moveable (it's just an int64 and an int32) to support being put in a circular_deque. BrowsingDataRemoverImpl::RemovalTask was made move-only (from previously not movable or copyable). BUG=757232 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ib83f929ae4c014ae0d3766a57e9cb56cba446e2b Reviewed-on: https://chromium-review.googlesource.com/656066 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501169} [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/android/synchronous_compositor_browser_filter.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/appcache/appcache_quota_client.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/appcache/appcache_storage_impl.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/appcache/appcache_update_job.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/appcache/mock_appcache_storage.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/background_fetch/background_fetch_data_manager.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/browser_plugin/browser_plugin_guest.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/browsing_data/browsing_data_remover_impl.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/browsing_data/browsing_data_remover_impl.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/byte_stream.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/byte_stream_unittest.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/devtools/devtools_io_context.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/devtools/protocol/input_handler.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/devtools/protocol/network_handler.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/devtools/protocol/target_auto_attacher.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/dom_storage/dom_storage_context_impl.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/download/download_item_impl_unittest.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/download/mhtml_generation_manager.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/download/save_package.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/find_request_manager.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/find_request_manager.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/frame_host/frame_tree.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/frame_host/navigation_entry_impl.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/gpu/gpu_process_host.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/indexed_db/indexed_db_database.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/indexed_db/indexed_db_transaction.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/loader/resource_buffer.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/loader/resource_loader_unittest.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/ppapi_plugin_process_host.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/browser_compositor_view_mac.mm [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/input/gesture_event_queue.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/input/legacy_input_router_impl.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/input/legacy_touch_event_queue.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/input/legacy_touch_event_queue_unittest.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/input/mouse_wheel_event_queue.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/input/synthetic_gesture_controller.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/input/touch_emulator.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/input/touch_emulator.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/media/audio_input_sync_writer.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/p2p/socket_host_tcp.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/p2p/socket_host_udp.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/pepper/pepper_network_proxy_host.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/pepper/pepper_vpn_provider_message_filter_chromeos.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/render_widget_host_view_android.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/resolve_proxy_msg_helper.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/service_worker/service_worker_cache_writer_unittest.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/service_worker/service_worker_fetch_dispatcher.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/service_worker/service_worker_job_coordinator.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/service_worker/service_worker_storage.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/speech/audio_buffer.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/speech/speech_recognition_engine_unittest.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/browser/webrtc/webrtc_internals.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/child/indexed_db/webidbcursor_impl.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/child/resource_dispatcher.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/child/shared_memory_data_consumer_handle.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/public/test/browser_test_utils.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/public/test/browser_test_utils.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/public/test/test_download_request_handler.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/public/test/test_download_request_handler.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/accessibility/render_accessibility_impl.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/input/main_thread_event_queue.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/input/main_thread_event_queue_task_list.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/media/gpu/rtc_video_decoder.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/media/gpu/rtc_video_encoder.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/media/webmediaplayer_ms_unittest.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/media_recorder/audio_track_recorder.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/media_recorder/vea_encoder.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/media_recorder/vea_encoder.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/pepper/content_decryptor_delegate.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/pepper/message_channel.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/pepper/pepper_media_stream_audio_track_host.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/pepper/video_decoder_shim.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/pepper/video_decoder_shim.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/pepper/video_encoder_shim.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/render_frame_impl.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/scheduler/resource_dispatch_throttler.cc [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/renderer/scheduler/resource_dispatch_throttler.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/shell/renderer/layout_test/blink_test_runner.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/shell/test_runner/event_sender.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/shell/test_runner/mock_web_speech_recognizer.h [modify] https://crrev.com/cc8623dc8e027afc1c21b7d44ef56fabf78ef3e2/content/shell/test_runner/test_runner.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3137bc1dadcd882c878b9218cab4c418cfc35862 commit 3137bc1dadcd882c878b9218cab4c418cfc35862 Author: Brett Wilson <brettw@chromium.org> Date: Tue Sep 19 22:23:37 2017 Convert queue and deque to base ones in //media Adds circular_deque iterator operator[] which is required for being a random access iterator but was not implemented. This is used by some media tests. Converts std::queue to base::queue and std::deque to base::circular_deque for all files in //media. We're standardizing on the base variants for platform consistency and memory usage. Eventually, a presubmit will be added to prevent using the STL ones. A base::hash_set in sender_rtcp_session.h was converted to a std::unordered_set using base::IntPairHash as the hash function. Affected typedefs were converted to using statements. If there were adjacent typedefs, those were also converted. An example was added to IntPairHash in base since I had trouble declaring it properly. A "std::" was added in stream_parser_unittest.cc that previously depended on Koenig lookup to resolve the namespace. Bug: 757232 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8ea4fb3b65238a466227aced3170bb768102894f Reviewed-on: https://chromium-review.googlesource.com/669667 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#502971} [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/base/containers/circular_deque.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/base/containers/circular_deque_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/base/hash.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/android/media_codec_loop.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/audio_buffer_converter.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/audio_buffer_queue.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/audio_shifter.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/audio_shifter.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/decoder_buffer_queue.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/serial_runner.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/silent_sink_suspender.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/stream_parser.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/stream_parser_buffer.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/stream_parser_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/base/video_frame_pool.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/blink/buffered_data_source_host_impl.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/blink/multibuffer_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/capture/content/animated_content_sampler.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/capture/video/chromeos/stream_buffer_manager.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/capture/video/linux/v4l2_capture_delegate.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/capture/video/win/video_capture_device_win.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/net/pacing/paced_sender_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/net/rtcp/receiver_rtcp_event_subscriber.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/net/rtcp/rtcp_builder.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/net/rtcp/sender_rtcp_session.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/net/rtp/cast_message_builder.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/net/rtp/packet_storage.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/receiver/frame_receiver_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/sender/congestion_control.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/sender/h264_vt_encoder_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/test/fake_media_source.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/test/receiver.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/test/sender.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/test/simulator.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/test/utility/barcode.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/test/utility/tap_proxy.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/test/utility/udp_proxy.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/cast/test/utility/udp_proxy_main.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/android/media_codec_audio_decoder.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/audio_clock.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/audio_decoder_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/chunk_demuxer.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/decoder_stream.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/ffmpeg_demuxer_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/gpu_video_decoder.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/source_buffer_stream.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/video_renderer_algorithm.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/vp9_parser.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/filters/vp9_parser.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/formats/mp2t/es_adapter_video.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/formats/webm/webm_cluster_parser.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/android/android_video_decode_accelerator.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/android/android_video_decode_accelerator.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/android/android_video_encode_accelerator.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/android/media_codec_video_decoder.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/fake_video_decode_accelerator.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/h264_decoder_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/media_foundation_video_encode_accelerator_win.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/rendering_helper.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/v4l2_image_processor.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/v4l2_jpeg_decode_accelerator.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/v4l2_slice_video_decode_accelerator.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/v4l2_video_decode_accelerator.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/v4l2_video_encode_accelerator.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/vaapi_video_decode_accelerator.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/vaapi_video_encode_accelerator.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/video_accelerator_unittest_helpers.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/video_decode_accelerator_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/video_encode_accelerator_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/vt_video_decode_accelerator_mac.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/gpu/vt_video_encode_accelerator_mac.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/midi/message_util.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/midi/midi_message_queue.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/mojo/services/mojo_demuxer_stream_adapter.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/muxers/webm_muxer.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/remoting/courier_renderer.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/remoting/fake_media_resource.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/remoting/stream_provider.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/remoting/stream_provider.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/renderers/audio_renderer_impl.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/renderers/video_renderer_impl.h [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/renderers/video_renderer_impl_unittest.cc [modify] https://crrev.com/3137bc1dadcd882c878b9218cab4c418cfc35862/media/video/fake_video_encode_accelerator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd commit a62d9c0d27dde694f4f7757f0817ff8ea722c5bd Author: Brett Wilson <brettw@chromium.org> Date: Wed Sep 20 20:53:20 2017 Convert many std::queue to base::queue Fix self-assignment of circular_deque which was asserted. This was exposed by the ClientSideDetectionServiceTest tests. Convert the std::queue in reporter_runner_win.h to a circular_deque instead of a base::queue. This one wants to check container contents equality which is (deliberately) not supported by circular_deque (which underlines base::queue and means base::queue equality also doesn't work). By converting to a circular_deque, the iterators can be used to run std::equal. We are standardizing on the base variant of deque and queue. This saves 6.8K code size on Linux 64. Convert typedefs to using statements in affected code. Bug: 757232 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6af98d213cb5a4202155683b8be38b2d31076f1b Reviewed-on: https://chromium-review.googlesource.com/673554 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#503241} [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/android_webview/browser/deferred_gpu_command_service.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/ash/system/bluetooth/bluetooth_power_controller.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/base/containers/circular_deque.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/base/containers/circular_deque_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/base/run_loop_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/android/vr_shell/vr_shell_gl.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/chromeos/arc/process/arc_process_service.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/chromeos/extensions/install_limiter.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/chromeos/platform_keys/platform_keys_service.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/chromeos/policy/upload_job_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/component_updater/sw_reporter_installer_win.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/conflicts/module_inspector_win.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/devtools/device/usb/android_usb_browsertest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/devtools/device/usb/android_usb_device.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/extensions/api/messaging/native_message_process_host.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/extensions/install_verifier.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/google/google_update_win_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/media/cast_remoting_sender.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/net/predictor.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/net/predictor.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/notifications/native_notification_display_service.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/policy/cloud/test_request_interceptor.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/printing/pdf_to_emf_converter.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/client_side_detection_service.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/client_side_detection_service.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/download_protection/download_feedback_service.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/notification_image_reporter.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/safe_browsing/permission_reporter.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/speech/tts_controller_impl.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/speech/tts_controller_impl.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/sync_file_system/local/local_file_change_tracker.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/sync_file_system/sync_process_runner_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/ui/cocoa/content_settings/cookies_tree_controller_bridge.mm [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/ui/webui/print_preview/print_preview_handler.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/browser/vr/vr_shell_renderer.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chrome/service/service_utility_process_host.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chromecast/media/cma/decoder/cast_audio_decoder.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/chromeos/dbus/fake_update_engine_client.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/bluetooth/bluetooth_remote_gatt_characteristic.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/bluetooth/bluetooth_socket_mac.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/bluetooth/bluetooth_socket_mac.mm [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/bluetooth/bluetooth_socket_net.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/bluetooth/bluetooth_socket_net.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/bluetooth/bluez/bluetooth_adapter_bluez.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/bluetooth/bluez/bluetooth_socket_bluez.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/bluetooth/test/mock_bluetooth_device.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/hid/hid_connection_linux.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/hid/hid_connection_mac.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/media_transfer_protocol/media_transfer_protocol_manager.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/usb/mojo/device_impl_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/device/usb/usb_service_impl.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/extensions/browser/api/alarms/alarm_manager.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/extensions/browser/api/lock_screen_data/lock_screen_item_storage_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/extensions/browser/api/mime_handler_private/mime_handler_private_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/extensions/browser/api/socket/socket.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/extensions/browser/api/system_info/system_info_provider.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/extensions/browser/extension_throttle_entry.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/gpu/command_buffer/client/client_discardable_manager.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/gpu/command_buffer/client/gles2_implementation.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/gpu/command_buffer/service/mailbox_manager_sync.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/gpu/command_buffer/service/sync_point_manager_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/gpu/ipc/host/shader_disk_cache.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/gpu/ipc/in_process_command_buffer.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/gpu/ipc/in_process_command_buffer.h [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/gpu/tools/compositor_model_bench/compositor_model_bench.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/ipc/ipc_channel_mojo_unittest.cc [modify] https://crrev.com/a62d9c0d27dde694f4f7757f0817ff8ea722c5bd/ipc/ipc_mojo_bootstrap.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b02c0a23bae6b784b766d828d26be0db19da972e commit b02c0a23bae6b784b766d828d26be0db19da972e Author: Brett Wilson <brettw@chromium.org> Date: Mon Sep 25 22:34:42 2017 Replace std::queue with base::queue. We are standardizing on the base implementation whenever possible. Updates typedefs to using statements when code was changed. file_transfer_message_handler_unittest.cc got a new helper function since base::queue lacks an operator== required for gtest. Bug: 757232 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I98d0c6880a5fcf5d236634abca51ba0fe41eeb6c Reviewed-on: https://chromium-review.googlesource.com/682755 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#504191} [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/mojo/edk/system/node_channel.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/mojo/edk/system/node_controller.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/mojo/edk/system/node_controller.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/mojo/edk/system/ports/ports_unittest.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/mojo/public/cpp/bindings/tests/message_queue.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/pdf/out_of_process_instance.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/pdf/out_of_process_instance.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ppapi/proxy/file_chooser_resource.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ppapi/proxy/file_system_resource.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ppapi/proxy/tcp_socket_resource_base.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ppapi/proxy/udp_socket_filter.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ppapi/proxy/udp_socket_resource_base.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ppapi/proxy/video_decoder_resource.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ppapi/proxy/vpn_provider_resource.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ppapi/proxy/websocket_resource.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/base/gaia_oauth_client.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/base/oauth_token_getter_impl.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/base/oauth_token_getter_impl.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/base/rate_counter.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/client/display/gl_renderer.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/client/input/keyboard_input_strategy.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/client/input/keyboard_interpreter.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/client/input/text_keyboard_input_strategy.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/client/input/text_keyboard_input_strategy.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/client/queued_task_poster.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/client/queued_task_poster.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/host/file_proxy_wrapper_linux.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/host/file_proxy_wrapper_linux_unittest.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/host/file_transfer_message_handler_unittest.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/host/linux/x11_character_injector.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/host/setup/daemon_controller.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/protocol/fake_message_pipe.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/protocol/pairing_registry.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/protocol/v2_authenticator.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/remoting/protocol/webrtc_frame_scheduler_simple.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/services/preferences/public/cpp/persistent_pref_store_client.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/services/ui/ime/ime_driver_bridge.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/services/ui/ws/drag_controller_unittest.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/services/ui/ws/event_dispatcher_unittest.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/services/ui/ws/window_manager_state.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/services/ui/ws/window_tree.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/storage/browser/fileapi/copy_or_move_operation_delegate_unittest.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/storage/browser/fileapi/dragged_file_util_unittest.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/storage/browser/fileapi/obfuscated_file_util.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/storage/browser/fileapi/recursive_operation_delegate.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/storage/browser/fileapi/recursive_operation_delegate.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/tools/gn/header_checker.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/tools/gn/visual_studio_writer.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ui/display/manager/chromeos/configure_displays_task.cc [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ui/display/manager/chromeos/configure_displays_task.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ui/display/manager/chromeos/display_configurator.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ui/display/manager/fake_display_delegate.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ui/events/gesture_detection/touch_disposition_gesture_filter.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ui/gl/sync_control_vsync_provider.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ui/ozone/platform/drm/gpu/mock_drm_device.h [modify] https://crrev.com/b02c0a23bae6b784b766d828d26be0db19da972e/ui/ozone/platform/drm/host/drm_display_host_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55ff1475eca8778624b684dd98b172f7bc49a22b commit 55ff1475eca8778624b684dd98b172f7bc49a22b Author: Brett Wilson <brettw@chromium.org> Date: Tue Sep 26 00:28:48 2017 Convert std::deque to base::circular_deque. The Request class in deterministic_dispatcher.h was made moveable to support its inclusion in a circular_deque. There was some minor cleanup of this class. Typedefs around changed code were converted to using statements. Some unnecessary <deque> includes were removed. An unnecessary <list> include is removed from remoting/protocol/message_decoder.h, and a <list> include was addedto remoting/protocol/message_decoder_unittest.cc which was depending on this. TBR=stevenjb (chromeos/network owners) Bug: 757232 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I654daa3f575b21fbfd6db225d0c321bc5781f96f Reviewed-on: https://chromium-review.googlesource.com/676201 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#504232} [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/android_webview/browser/child_frame.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ash/fast_ink/fast_ink_points.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ash/fast_ink/fast_ink_points.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ash/system/toast/toast_manager.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ash/wm/video_detector_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/base/files/file_enumerator_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/base/task/cancelable_task_tracker_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/base/test/scoped_mock_time_message_loop_task_runner.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/base/test/scoped_mock_time_message_loop_task_runner_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/base/test/test_mock_time_task_runner.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/base/test/test_mock_time_task_runner.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/base/test/test_simple_task_runner.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/base/test/test_simple_task_runner.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/base/trace_event/heap_profiler_stack_frame_deduplicator.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/build/precompile.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/cc/base/delayed_unique_notifier_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/cc/base/rolling_time_delta_history.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/cc/raster/staging_buffer_pool.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/cc/resources/resource_pool.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/cc/resources/resource_provider.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/cc/resources/resource_provider_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/cc/scheduler/scheduler.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/cc/test/fake_tile_manager.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/cc/trees/layer_tree_host_common_perftest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/chromecast/media/cma/backend/alsa/audio_decoder_alsa.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/chromecast/media/cma/backend/android/audio_decoder_android.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/chromeos/audio/cras_audio_handler.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/chromeos/dbus/fake_power_manager_client.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/chromeos/network/network_event_log.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/chromeos/network/network_sms_handler.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/chromeos/printing/ppd_provider.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/cast_channel/logger.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/favicon/core/large_icon_service_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/history/core/browser/history_types.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/invalidation/impl/registration_manager_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/pairing/proto_decoder.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/signin/core/browser/account_reconcilor.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/sync/model_impl/attachments/attachment_service_impl.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/viz/service/display/bsp_tree.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/viz/service/display/bsp_tree.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/viz/service/display/bsp_tree_perftest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/viz/service/display/bsp_tree_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/viz/service/display/direct_renderer.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/viz/service/display/direct_renderer.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/components/viz/service/display/output_surface.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/content/browser/presentation/presentation_service_impl.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/content/browser/renderer_host/input/gesture_event_queue.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/content/renderer/input/main_thread_event_queue.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/content/renderer/render_view_impl.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/content/renderer/render_widget.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/device/bluetooth/test/bluetooth_test_win.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/extensions/browser/api/power/power_api_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/extensions/browser/api/webcam_private/visca_webcam.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/extensions/browser/error_map.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/extensions/browser/updater/extension_downloader.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/extensions/browser/updater/request_queue.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/extensions/test/result_catcher.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/google_apis/gcm/engine/connection_event_tracker.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/google_apis/gcm/engine/mcs_client.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/google_apis/gcm/engine/mcs_client.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/command_buffer/client/query_tracker.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/command_buffer/client/query_tracker.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/command_buffer/client/ring_buffer.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/command_buffer/service/gpu_tracer.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/command_buffer/service/gpu_tracer.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/command_buffer/service/query_manager.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/command_buffer/service/scheduler.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/ipc/service/direct_composition_surface_win.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/ipc/service/gpu_channel.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/ipc/service/gpu_channel_manager.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/gpu/ipc/service/gpu_command_buffer_stub.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/headless/public/util/deterministic_dispatcher.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/headless/public/util/deterministic_dispatcher.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ios/chrome/browser/metrics/tab_usage_recorder.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ios/chrome/browser/reading_list/url_downloader.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ios/chrome/browser/ui/dialogs/dialog_presenter.mm [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ipc/ipc_channel_nacl.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ipc/ipc_sync_channel.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/jingle/glue/chrome_async_socket_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/mojo/edk/system/channel_fuchsia.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ppapi/proxy/url_loader_resource.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ppapi/proxy/video_encoder_resource.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ppapi/shared_impl/media_stream_buffer_manager.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/base/compound_buffer.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/base/running_samples.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/base/telemetry_log_writer.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/base/telemetry_log_writer_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/client/client_telemetry_logger_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/codec/codec_test.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/host/linux/x11_character_injector_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/protocol/message_decoder.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/protocol/message_decoder_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/protocol/pseudotcp_adapter_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/remoting/signaling/log_to_server.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/services/preferences/pref_store_consistency_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/storage/browser/blob/blob_transport_strategy.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/storage/browser/quota/quota_manager.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/third_party/leveldatabase/env_chromium.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/accelerated_widget_mac/ca_renderer_layer_tree.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/app_list/search/history_data.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/aura/mus/input_method_mus.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/compositor/compositor.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/compositor/layer_animator.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/events/blink/compositor_thread_event_queue.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/events/blink/input_handler_proxy_unittest.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/gl/gpu_timing.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/message_center/message_center_impl.cc [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/ozone/platform/drm/gpu/hardware_display_controller.h [modify] https://crrev.com/55ff1475eca8778624b684dd98b172f7bc49a22b/ui/ozone/platform/drm/host/drm_overlay_candidates_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f07f20e2cf89c72ea4c4948d73f386d7337ece3 commit 1f07f20e2cf89c72ea4c4948d73f386d7337ece3 Author: Brett Wilson <brettw@chromium.org> Date: Mon Oct 02 18:55:28 2017 Add base::stack, convert std::stack uses use it. std::stack is a wrapper that defaults to std::deque. As part of our std::deque removal, an implementation of stack that uses base::circular_deque is provided. Rewrites trace_event_argument.cc usage of stack to use indices and a circular_deque since it was relying on storage stability across updates. Changes the PPAPI/V8 variable conversion code to avoid unstable usage of a stack. Fixes a use-after-free in V8VarConverter::ToV8Value where the reference to the top of the stack was dereferenced after popping it off. BUG=757232 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4f3ff9b4c4403dafd809f7a6a77902a9cb59e5a0 Reviewed-on: https://chromium-review.googlesource.com/682761 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#505705} [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/BUILD.gn [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/at_exit.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/at_exit.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/containers/README.md [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/containers/queue.h [add] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/containers/stack.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/files/file_enumerator.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/files/file_util_posix.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/logging.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/run_loop.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/task_scheduler/scheduler_worker_pool_impl.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/trace_event/trace_event_argument.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/trace_event/trace_event_impl.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/base/trace_event/trace_log.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/build/precompile.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/cc/trees/draw_property_utils.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/cc/trees/layer_tree_host.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/chrome/browser/android/bookmarks/bookmark_bridge.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/chrome/browser/extensions/updater/extension_updater.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/chrome/browser/sync/test/integration/bookmarks_helper.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/chrome/browser/sync_file_system/drive_backend/metadata_database.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/components/browser_sync/profile_sync_service_bookmark_unittest.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/components/omnibox/browser/url_index_private_data.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/components/omnibox/browser/url_index_private_data.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/components/sync/syncable/base_node.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/components/sync_bookmarks/bookmark_change_processor.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/components/sync_bookmarks/bookmark_model_associator.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/content/browser/appcache/appcache_request_handler_unittest.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/content/browser/appcache/appcache_response_unittest.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/content/browser/appcache/appcache_storage_impl_unittest.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/content/browser/appcache/appcache_url_request_job_unittest.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/content/browser/indexed_db/indexed_db_transaction.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/content/renderer/pepper/v8_var_converter.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/content/test/content_browser_test_utils_internal.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/extensions/browser/file_highlighter.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/gpu/command_buffer/client/share_group.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/gpu/command_buffer/common/debug_marker_manager.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/gpu/command_buffer/service/gpu_tracer.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/ipc/ipc_sync_message.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/media/cdm/ppapi/cdm_file_io_test.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/ppapi/proxy/raw_var_data.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/storage/browser/fileapi/copy_or_move_operation_delegate.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/storage/browser/fileapi/dump_file_system.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/storage/browser/fileapi/recursive_operation_delegate.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/storage/browser/fileapi/remove_operation_delegate.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/storage/browser/fileapi/sandbox_directory_database.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/ui/accessibility/ax_position.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/ui/base/models/tree_node_iterator.h [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/ui/display/unified_desktop_utils.cc [modify] https://crrev.com/1f07f20e2cf89c72ea4c4948d73f386d7337ece3/ui/events/event_handler.h
Comment 1 by bugdroid1@chromium.org
, Aug 22 2017