New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757217 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in !it.done() in module-compiler.cc

Project Member Reported by ClusterFuzz, Aug 20 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6064891571208192

Fuzzer: libFuzzer_v8_wasm_async_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !it.done() in module-compiler.cc
  v8::internal::wasm::JSToWasmWrapperCache::CloneOrCompileJSToWasmWrapper
  v8::internal::wasm::AsyncCompileJob::CompileWrappers::RunInForeground
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=495819:495825

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6064891571208192

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 20 2017

Labels: M-62
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 20 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 20 2017

Labels: Pri-1
Components: Blink>JavaScript>WebAssembly
Owner: mtrofin@chromium.org
https://chromium.googlesource.com/v8/v8/+/72dd5738a6c6ebc0d605f8df95e8eb2d1cbd67b5 looks like the most likely culprit in the regression range.
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 21 2017

Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/172d6f50e5b8f3f5b484d16879a33198081b83bc

commit 172d6f50e5b8f3f5b484d16879a33198081b83bc
Author: Mircea Trofin <mtrofin@chromium.org>
Date: Thu Aug 24 00:10:52 2017

[wasm] Test and fix for module with no functions

Initialize the code table with a valid default (e.g. illegal builtin),
otherwise we're invalidating assumptions when relocating.

Bug:  chromium:757217 
Change-Id: I77890f1fe0e31534d9844d2e91694df1ec185110
Reviewed-on: https://chromium-review.googlesource.com/630097
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Commit-Queue: Brad Nelson <bradnelson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47560}
[modify] https://crrev.com/172d6f50e5b8f3f5b484d16879a33198081b83bc/src/wasm/module-compiler.cc
[add] https://crrev.com/172d6f50e5b8f3f5b484d16879a33198081b83bc/test/mjsunit/regress/wasm/regression-757217.js

Project Member

Comment 8 by ClusterFuzz, Aug 24 2017

ClusterFuzz has detected this issue as fixed in range 496919:496954.

Detailed report: https://clusterfuzz.com/testcase?key=6064891571208192

Fuzzer: libFuzzer_v8_wasm_async_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !it.done() in module-compiler.cc
  v8::internal::wasm::JSToWasmWrapperCache::CloneOrCompileJSToWasmWrapper
  v8::internal::wasm::AsyncCompileJob::CompileWrappers::RunInForeground
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=495819:495825
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=496919:496954

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6064891571208192

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Aug 24 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5801337077104640 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 24 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 30 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment