New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757195 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tests need rebaselining due to slight pixel changes after Skia GPU image rendering change.

Project Member Reported by bsalo...@google.com, Aug 19 2017

Issue description

Skia added a faster code path for simple image draws that can renders slightly differently. These tests will need to be rebaselined after Skia rolls:

virtual/gpu/fast/canvas/canvas-composite-video-shadow.html
virtual/gpu/fast/canvas/canvas-composite-video.html
virtual/gpu/fast/canvas/canvas-incremental-repaint.html
virtual/gpu/fast/canvas/image-object-in-canvas.html
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2b784c80d302ffcaf478d7e6f05e222fbf9c8bf

commit f2b784c80d302ffcaf478d7e6f05e222fbf9c8bf
Author: Brian Salomon <bsalomon@google.com>
Date: Sat Aug 19 21:35:12 2017

Mark tests as needing rebaseline to roll past Skia GPU image rendering change

Bug =  757195 

Change-Id: Id1187a489acbf56ddcf542130224e4f6b6f5414b
Reviewed-on: https://chromium-review.googlesource.com/622052
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495827}
[modify] https://crrev.com/f2b784c80d302ffcaf478d7e6f05e222fbf9c8bf/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0739daa74157a3ed9446dbafdc3a2d9ca81846b

commit e0739daa74157a3ed9446dbafdc3a2d9ca81846b
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Sun Aug 20 05:59:01 2017

LayoutTests: Changing tests between crbug.com/757165 and  crbug.com/757195 

Still trying to make the Windows bots go green.

BUG= 757195 ,757165
TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org,bsalomon@chromium.org
NOTRY=true

Change-Id: Id8cbb973ed54253e0d8621104f56b2bdddc5cf40
Reviewed-on: https://chromium-review.googlesource.com/622708
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495837}
[modify] https://crrev.com/e0739daa74157a3ed9446dbafdc3a2d9ca81846b/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dee06cc08d9147aed4978b1239b034c9889f67e

commit 6dee06cc08d9147aed4978b1239b034c9889f67e
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Sun Aug 20 11:30:24 2017

LayoutTests: More tests failures crbug.com/757165 and  crbug.com/757195 

Still trying to make the Windows RandomOrder bots go green.

BUG= 757195 ,757165,626703
TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org,bsalomon@chromium.org
NOTRY=true

Change-Id: Id6f87382d31b5fb8fd24aa9901d37d1f481968f6
Reviewed-on: https://chromium-review.googlesource.com/622628
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495840}
[modify] https://crrev.com/6dee06cc08d9147aed4978b1239b034c9889f67e/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/319f9fa42226ceeee2ac8e4f863bf5046cb40e16

commit 319f9fa42226ceeee2ac8e4f863bf5046cb40e16
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Mon Aug 21 04:52:47 2017

LayoutTests: Disabling flaky tests on Windows.

Yet more tests which are flaky. Aggressively disable;
 * virtual/gpu/fast/canvas/canvas-blending-*
 * fast/spatial-navigation/snav-*

Trying to make the Random Order bot go green so LayoutTests on swarming
can be deployed on the Windows FYI bots.

BUG=757165, 757195 
TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org
NOTRY=true

Change-Id: I85e455781617070921f66df39bf7e8f5a8817657
Reviewed-on: https://chromium-review.googlesource.com/622808
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495873}
[modify] https://crrev.com/319f9fa42226ceeee2ac8e4f863bf5046cb40e16/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by bsalo...@google.com, Aug 21 2017

Hi Tim, I was going to try to rebaseline the tests from f2b784c80d302ffcaf478d7e6f05e222fbf9c8bf. Should I hold off?

Comment 6 by junov@chromium.org, Sep 12 2017

Ping!  A bunch of layout tests related to this bug still need rebaselining.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/953c88223dbf2b2a0fec6f0cbf229492f9bade2b

commit 953c88223dbf2b2a0fec6f0cbf229492f9bade2b
Author: Brian Salomon <bsalomon@google.com>
Date: Wed Sep 20 14:00:58 2017

Rebaseline tests from  Issue 757195  (slight image differences due to Skia change).

Skip these tests on windows due to 757165.

Bug:757195,757165

Change-Id: If0a2e91aa0de250707f00525037535a82f043457
Reviewed-on: https://chromium-review.googlesource.com/667357
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503128}
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-composite-video-expected.png
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu/fast/canvas/canvas-composite-video-expected.png
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-expected.png
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png
[modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png

Comment 8 by bsalo...@google.com, Sep 21 2017

Status: Fixed (was: Assigned)

Sign in to add a comment