New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757187 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: rv == 0Resource deadlock avoided in lock_impl_posix.cc

Project Member Reported by ClusterFuzz, Aug 19 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5164140829343744

Fuzzer: libFuzzer_mojo_parse_message_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  rv == 0Resource deadlock avoided in lock_impl_posix.cc
  base::debug::DebugBreak
  base::internal::LockImpl::Lock
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=495780:495802

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5164140829343744

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org sandeepkumars@chromium.org
Labels: Test-Predator-Wrong-CLs M-62
Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "lock_impl_posix.cc" assigning to the concern owner who might be related.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/05b564e44b5289fa86ee281eb308f7437ec3299e

@rockot -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by roc...@chromium.org, Aug 28 2017

Cc: roc...@chromium.org tjbecker@google.com yzshen@chromium.org
Owner: ----
Status: Available (was: Assigned)
The CHECK was temporary to catch Lock misuse. It's been reverted.

This did however reveal a likely lock-order inversion, but it's not clear yo me whether the bug is in the bindings or in the fuzzer's use of the bindings.

Comment 3 by yzshen@chromium.org, Aug 28 2017

Owner: yzshen@chromium.org
Status: Assigned (was: Available)
I will take a look.

It seems the message in MultiplexRouter::MessageWrapper constains ScopedInterfaceEndpointHandle, which should never happen after my recent change. Hmm...

Project Member

Comment 4 by ClusterFuzz, Oct 1 2017

Components: Internals>Core Internals>Mojo
Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 5 by yzshen@chromium.org, Oct 16 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a917c60a906fbaa1541711af8009099fc6292ff

commit 4a917c60a906fbaa1541711af8009099fc6292ff
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Tue Oct 17 03:48:49 2017

Mojo C++ bindings: avoid destroying ScopedInterfaceEndpointHandle under MultiplexRouter's lock.

BUG= 757187 

Change-Id: If2513dfdd287f0c06df917bd2c0b87cf6e0ea539
Reviewed-on: https://chromium-review.googlesource.com/722029
Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509269}
[modify] https://crrev.com/4a917c60a906fbaa1541711af8009099fc6292ff/mojo/public/cpp/bindings/lib/multiplex_router.cc

Project Member

Comment 7 by ClusterFuzz, Oct 17 2017

ClusterFuzz has detected this issue as fixed in range 509258:509279.

Detailed report: https://clusterfuzz.com/testcase?key=5164140829343744

Fuzzer: libFuzzer_mojo_parse_message_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  rv == 0Resource deadlock avoided in lock_impl_posix.cc
  base::internal::LockImpl::Lock
  base::Lock::Acquire
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=495780:495802
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=509258:509279

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5164140829343744

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Oct 17 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5164140829343744 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment