Integer-overflow in cc::Animation::ConvertToActiveTime |
|||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=4890501752029184 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: cc::Animation::ConvertToActiveTime cc::Animation::InEffect cc::AnimationPlayer::GetPropertyAnimationState Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=488635:489609 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4890501752029184 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Oct 1 2017
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
,
Oct 3 2017
Looks like this method doesn't do a saturated subtraction: TimeDelta TimeBase<TimeClass>::operator-(TimeClass other) const But a similar one does: TimeClass TimeBase<TimeClass>::operator-(TimeDelta delta) const Was probably an oversight by the original changes that introduced the saturated math protections. However, this is not to say the fuzzer-found bug is in the time library: It's strange that the cc::Animation code would blindly accept/process bad time values. So, it's probably best that loyso@ (src/cc/animation/OWNERS) take a look first.
,
Nov 7 2017
,
Jan 25 2018
ClusterFuzz has detected this issue as fixed in range 531707:531718. Detailed report: https://clusterfuzz.com/testcase?key=4890501752029184 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: cc::Animation::ConvertToActiveTime cc::Animation::InEffect cc::AnimationTicker::GetPropertyAnimationState Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=488635:489609 Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=531707:531718 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4890501752029184 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jan 25 2018
ClusterFuzz testcase 4890501752029184 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sandeepkumars@chromium.org
, Aug 29 2017Labels: M-62 Test-Predator-Wrong-CLs
Owner: m...@chromium.org
Status: Assigned (was: Untriaged)