Layout Test which fail/flaky on Windows when using swarming |
|||
Issue descriptionThis bug will track the disabling of tests which are failing / flaky when run on Windows using swarming. These tests have most certainly been flaky for a long time, but have been covered up by other things. Swarming is just exposing these flakiness.
,
Aug 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/878083f484afea64e664958535e3b8af05ff0fb3 commit 878083f484afea64e664958535e3b8af05ff0fb3 Author: Tim 'mithro' Ansell <tansell@chromium.org> Date: Sat Aug 19 12:31:44 2017 LayoutTests: Disabling tests failing on Win locally. Trying to make the Random Order bot go green so LayoutTests on swarming can be deployed on the Windows FYI bots. BUG=757165 TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org NOTRY=true Change-Id: I084e41912c3decf600e809412bbef4ec91174c8b Reviewed-on: https://chromium-review.googlesource.com/622328 Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org> Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org> Cr-Commit-Position: refs/heads/master@{#495812} [modify] https://crrev.com/878083f484afea64e664958535e3b8af05ff0fb3/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0739daa74157a3ed9446dbafdc3a2d9ca81846b commit e0739daa74157a3ed9446dbafdc3a2d9ca81846b Author: Tim 'mithro' Ansell <tansell@chromium.org> Date: Sun Aug 20 05:59:01 2017 LayoutTests: Changing tests between crbug.com/757165 and crbug.com/757195 Still trying to make the Windows bots go green. BUG= 757195 ,757165 TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org,bsalomon@chromium.org NOTRY=true Change-Id: Id8cbb973ed54253e0d8621104f56b2bdddc5cf40 Reviewed-on: https://chromium-review.googlesource.com/622708 Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org> Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org> Cr-Commit-Position: refs/heads/master@{#495837} [modify] https://crrev.com/e0739daa74157a3ed9446dbafdc3a2d9ca81846b/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dee06cc08d9147aed4978b1239b034c9889f67e commit 6dee06cc08d9147aed4978b1239b034c9889f67e Author: Tim 'mithro' Ansell <tansell@chromium.org> Date: Sun Aug 20 11:30:24 2017 LayoutTests: More tests failures crbug.com/757165 and crbug.com/757195 Still trying to make the Windows RandomOrder bots go green. BUG= 757195 ,757165,626703 TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org,bsalomon@chromium.org NOTRY=true Change-Id: Id6f87382d31b5fb8fd24aa9901d37d1f481968f6 Reviewed-on: https://chromium-review.googlesource.com/622628 Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org> Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org> Cr-Commit-Position: refs/heads/master@{#495840} [modify] https://crrev.com/6dee06cc08d9147aed4978b1239b034c9889f67e/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5329dd04b7a17c6aca65a01095edc02c5ce18946 commit 5329dd04b7a17c6aca65a01095edc02c5ce18946 Author: Tim 'mithro' Ansell <tansell@chromium.org> Date: Sun Aug 20 23:40:18 2017 LayoutTests: Disabling flaky tests on Windows. Yet more tests which are flaky. Trying to make the Random Order bot go green so LayoutTests on swarming can be deployed on the Windows FYI bots. BUG=757165 TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org NOTRY=true Change-Id: I4fc76bde8b425c4c3eff99954dd7e6e457ae28c1 Reviewed-on: https://chromium-review.googlesource.com/622454 Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org> Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org> Cr-Commit-Position: refs/heads/master@{#495855} [modify] https://crrev.com/5329dd04b7a17c6aca65a01095edc02c5ce18946/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/319f9fa42226ceeee2ac8e4f863bf5046cb40e16 commit 319f9fa42226ceeee2ac8e4f863bf5046cb40e16 Author: Tim 'mithro' Ansell <tansell@chromium.org> Date: Mon Aug 21 04:52:47 2017 LayoutTests: Disabling flaky tests on Windows. Yet more tests which are flaky. Aggressively disable; * virtual/gpu/fast/canvas/canvas-blending-* * fast/spatial-navigation/snav-* Trying to make the Random Order bot go green so LayoutTests on swarming can be deployed on the Windows FYI bots. BUG=757165, 757195 TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org NOTRY=true Change-Id: I85e455781617070921f66df39bf7e8f5a8817657 Reviewed-on: https://chromium-review.googlesource.com/622808 Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org> Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org> Cr-Commit-Position: refs/heads/master@{#495873} [modify] https://crrev.com/319f9fa42226ceeee2ac8e4f863bf5046cb40e16/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 22 2017
None of the tests referenced above have anything to do with Layout. They're either spatial-navigation, loading, DevTools, or compositing tests.
,
Sep 14 2017
Is skipping tests a good practice for flaky tests? I think we should mark them [ Pass Failure ] instead of [ Skip ], so that we can see how they behave along the time on the flakiness dashboard. I even think we should ban [ Skip ] in TestExpectations. Perhaps we can add a SkippedTests file for tests that we really want to be skipped. (I found this bug because 'webkit-patch rebaseline-cl' for a CL removed the Skip line in TestExpectations for a test being rebaselined. Is this expected?) Wdyt?
,
Sep 14 2017
For many years I thought that it was better to run the tests so that we could report the results (and see if things stopped being flaky). However, over time I've come to the conclusion that running tests but ignoring the results like [ Pass Failure ] more often then not leads to people ignoring the results as well, and just increases the costs of the tests and the complexity of the system. As a result, I think we're actually better off banning [ Pass Failure ] instead of [ Skip ], and have been meaning to propose that instead :).
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/953c88223dbf2b2a0fec6f0cbf229492f9bade2b commit 953c88223dbf2b2a0fec6f0cbf229492f9bade2b Author: Brian Salomon <bsalomon@google.com> Date: Wed Sep 20 14:00:58 2017 Rebaseline tests from Issue 757195 (slight image differences due to Skia change). Skip these tests on windows due to 757165. Bug:757195,757165 Change-Id: If0a2e91aa0de250707f00525037535a82f043457 Reviewed-on: https://chromium-review.googlesource.com/667357 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#503128} [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-composite-video-expected.png [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu/fast/canvas/canvas-composite-video-expected.png [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-expected.png [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [modify] https://crrev.com/953c88223dbf2b2a0fec6f0cbf229492f9bade2b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e286250b9e5c11b0a9e14d6b243dc206999c4a50 commit e286250b9e5c11b0a9e14d6b243dc206999c4a50 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Jan 05 00:42:57 2018 Update TestExpectations with update-flaky-expectations This CL was initially based on changes made by the third_party/WebKit/Tools/Scripts/update-flaky-expectations, but includes manual changes as well, including formatting changes and making expectations more specific based on visually checking the flakiness dashboard results. Flakiness dashboard link: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=http/tests/devtools/coverage/coverage-view.js,inspector-protocol/layout-fonts/cjk-ideograph-fallback-by-lang.js,http/tests/websocket/close-code-and-reason.html,external/wpt/css/css-writing-modes/writing-mode-vertical-rl-001.xht,external/wpt/css/css-writing-modes/writing-mode-vertical-rl-002.xht,external/wpt/css/css-fonts/font-display/font-display.html,fast/workers/chromium/worker-document-leak.html,fast/dom/Window/window-resize-contents.html,fast/text/ellipsis-in-relative-inline.html,fast/spatial-navigation/snav-1st-stop.html,fast/spatial-navigation/snav-display-contents-crash.html,fast/spatial-navigation/snav-div-in-anchor-and-img-crash.html,fast/spatial-navigation/snav-div-in-anchor.html,fast/spatial-navigation/snav-hidden-focusable-element.html,fast/spatial-navigation/snav-iframe-nested.html,fast/spatial-navigation/snav-iframe-no-focusable-content.html,fast/spatial-navigation/snav-iframe-no-scrollable-content.html,fast/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html,fast/spatial-navigation/snav-media-elements.html,fast/spatial-navigation/snav-multiple-select-focusring.html,fast/spatial-navigation/snav-offscreen-content.html,fast/spatial-navigation/snav-only-clipped-overflow-content.html,fast/spatial-navigation/snav-simple-content-overflow.html,fast/spatial-navigation/snav-single-select-list.html,fast/spatial-navigation/snav-zero-margin-content.html,external/wpt/clear-site-data/storage.https.html,http/tests/devtools/network/network-xhr-same-url-as-main-resource.js,virtual/mouseevent_fractional/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html Bug: 518989 , 520737 , 520739, 564109 , 729836 , 731535 , 746904 , 757165, 767040, 767269 , 773353 , 785980 , 795250 Change-Id: I03ac7e658ee42ccf3798e7f3994d30fc74880565 Reviewed-on: https://chromium-review.googlesource.com/847835 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#527171} [modify] https://crrev.com/e286250b9e5c11b0a9e14d6b243dc206999c4a50/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e Author: Sahel Sharify <sahel@chromium.org> Date: Thu Mar 15 17:30:49 2018 Send GSB before switching to mainthread scrolling in smooth scroll path. This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling path,if the compositor handles the GSB and during the scrolling we have to switch to main thread since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original GSB was handled on the compositor rather than being sent to the main thread. touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling in this cl I've moved the test to a new virtual test suite that has default scroll animation value. I have removed the test expectations since I have changed the test and this might fix the flake. subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to a new test suite. Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 Reviewed-on: https://chromium-review.googlesource.com/961264 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#543425} [modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling [modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/VirtualTestSuites [rename] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/animated-scroll/touchpad-scroll-impl-to-main.html [rename] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/non-animated-scroll/subpixel-accumulation.html [copy] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt [rename] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt [modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/ui/events/blink/input_handler_proxy.cc
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a6d89788324987fbad1450b2db6f113129a7130 commit 0a6d89788324987fbad1450b2db6f113129a7130 Author: Caleb Rouleau <crouleau@chromium.org> Date: Thu Mar 15 19:20:17 2018 Revert "Send GSB before switching to mainthread scrolling in smooth scroll path." This reverts commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e. Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see issue 822386 bug: 822386 Original change's description: > Send GSB before switching to mainthread scrolling in smooth scroll path. > > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original > GSB was handled on the compositor rather than being sent to the main thread. > > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling > in this cl I've moved the test to a new virtual test suite that has default scroll animation > value. > > I have removed the test expectations since I have changed the test and this might fix the flake. > > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to > a new test suite. > > Bug: 820979, 708499, 757165, 800840 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 > Reviewed-on: https://chromium-review.googlesource.com/961264 > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543425} TBR=tdresser@chromium.org,sahel@chromium.org Change-Id: I3c5253d96d011c9723063effac91c969ee352305 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/963388 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#543467} [modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling [modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/VirtualTestSuites [rename] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/subpixel-accumulation.html [rename] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html [rename] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/README.txt [delete] https://crrev.com/44f923b213a284825b87fd7a8b9dea048c964653/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt [modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/ui/events/blink/input_handler_proxy.cc
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0842dc1779dae371e2bda39bdbe19c73bcac2f0 commit f0842dc1779dae371e2bda39bdbe19c73bcac2f0 Author: Sahel Sharify <sahel@chromium.org> Date: Thu Mar 15 21:22:26 2018 Reland "Send GSB before switching to mainthread scrolling in smooth scroll path." This reverts commit 0a6d89788324987fbad1450b2db6f113129a7130. Reason for revert: touchpad-scroll-impl-to-main.html is a flaky test that I changed it in the original cl and removed the tests expectations to see if the flake is fixed or not. Changing the test expectations caused unexpected test failure. In this reland I left the test expectations for touchpad-scroll-impl-to-main.html unchanged. Original change's description: > Revert "Send GSB before switching to mainthread scrolling in smooth scroll path." > > This reverts commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e. > > Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see issue 822386 > > bug: 822386 > > Original change's description: > > Send GSB before switching to mainthread scrolling in smooth scroll path. > > > > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling > > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread > > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original > > GSB was handled on the compositor rather than being sent to the main thread. > > > > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main > > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling > > in this cl I've moved the test to a new virtual test suite that has default scroll animation > > value. > > > > I have removed the test expectations since I have changed the test and this might fix the flake. > > > > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to > > a new test suite. > > > > Bug: 820979, 708499, 757165, 800840 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 > > Reviewed-on: https://chromium-review.googlesource.com/961264 > > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#543425} > > TBR=tdresser@chromium.org,sahel@chromium.org > > Change-Id: I3c5253d96d011c9723063effac91c969ee352305 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 820979, 708499, 757165, 800840 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/963388 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543467} TBR=tdresser@chromium.org,crouleau@chromium.org Change-Id: I460ff89a12c94772564c77418f2c1e58c72314a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/964809 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543498} [modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling [modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/VirtualTestSuites [rename] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/animated-scroll/touchpad-scroll-impl-to-main.html [rename] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/non-animated-scroll/subpixel-accumulation.html [copy] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt [rename] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt [modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/ui/events/blink/input_handler_proxy.cc
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b commit dfc61b12139e0a086e7e24994c7ef10a98b1aa2b Author: Sahel Sharify <sahel@chromium.org> Date: Tue Apr 03 15:56:43 2018 Reland "Send GSB before switching to mainthread scrolling in smooth scroll path." This reverts commit 0a6d89788324987fbad1450b2db6f113129a7130. Reason for revert: touchpad-scroll-impl-to-main.html is a flaky test that I changed it in the original cl and removed the tests expectations to see if the flake is fixed or not. Changing the test expectations caused unexpected test failure. In this reland I left the test expectations for touchpad-scroll-impl-to-main.html unchanged. Original change's description: > Revert "Send GSB before switching to mainthread scrolling in smooth scroll path." > > This reverts commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e. > > Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see issue 822386 > > bug: 822386 > > Original change's description: > > Send GSB before switching to mainthread scrolling in smooth scroll path. > > > > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling > > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread > > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original > > GSB was handled on the compositor rather than being sent to the main thread. > > > > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main > > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling > > in this cl I've moved the test to a new virtual test suite that has default scroll animation > > value. > > > > I have removed the test expectations since I have changed the test and this might fix the flake. > > > > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to > > a new test suite. > > > > Bug: 820979, 708499, 757165, 800840 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 > > Reviewed-on: https://chromium-review.googlesource.com/961264 > > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#543425} > > TBR=tdresser@chromium.org,sahel@chromium.org > > Change-Id: I3c5253d96d011c9723063effac91c969ee352305 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 820979, 708499, 757165, 800840 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/963388 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543467} TBR=tdresser@chromium.org,crouleau@chromium.org Change-Id: I460ff89a12c94772564c77418f2c1e58c72314a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/964809 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543498}(cherry picked from commit f0842dc1779dae371e2bda39bdbe19c73bcac2f0) Reviewed-on: https://chromium-review.googlesource.com/992852 Cr-Commit-Position: refs/branch-heads/3359@{#551} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling [modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/VirtualTestSuites [rename] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/animated-scroll/touchpad-scroll-impl-to-main.html [rename] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/non-animated-scroll/subpixel-accumulation.html [copy] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt [rename] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt [modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/ui/events/blink/input_handler_proxy.cc
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8442f319da925e10b9cd8c754d9a44467dd63c29 commit 8442f319da925e10b9cd8c754d9a44467dd63c29 Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Aug 21 09:54:56 2018 Gardening: Re-enable WPT navigation-redirect.https.html with failing expectation file. This was disabled on Windows and had separate expectations on Linux and Mac. It should be able to run on all platforms with a single expectation file. Attempting that. Bug: 876223, 757165 Change-Id: I5ea603e037373a6c17edc00a1a14177a8be99a1a Reviewed-on: https://chromium-review.googlesource.com/1183049 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#584702} [modify] https://crrev.com/8442f319da925e10b9cd8c754d9a44467dd63c29/third_party/WebKit/LayoutTests/TestExpectations [rename] https://crrev.com/8442f319da925e10b9cd8c754d9a44467dd63c29/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt [delete] https://crrev.com/0b5c2d1f81f8b6ab286dfc051f0aaac3d5feab1b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-blobs/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt [delete] https://crrev.com/0b5c2d1f81f8b6ab286dfc051f0aaac3d5feab1b/third_party/WebKit/LayoutTests/platform/linux/virtual/outofblink-cors/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt [delete] https://crrev.com/0b5c2d1f81f8b6ab286dfc051f0aaac3d5feab1b/third_party/WebKit/LayoutTests/platform/mac/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Aug 19 2017