New issue
Advanced search Search tips

Issue 757146 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in compute_quad_level

Project Member Reported by ClusterFuzz, Aug 19 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6628061507485696

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  compute_quad_level
  void hair_path<
  SkDraw::drawDevPath
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=474010:474024

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6628061507485696

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Components: Internals>Skia
Labels: M-62 Test-Predator-Wrong-CLs
Project Member

Comment 2 by ClusterFuzz, Oct 4 2017

Labels: Test-Predator-AutoOwner
Owner: reed@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/435071e8ab865e395bec34ef128a412ceb50f063 (color-correct patch).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by reed@google.com, Oct 9 2017

Cc: bunge...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/c4b015ad5f3b85b0c77d01ce1ce042294a3dd362

commit c4b015ad5f3b85b0c77d01ce1ce042294a3dd362
Author: Mike Reed <reed@google.com>
Date: Mon Oct 09 18:37:14 2017

use unsigned to allow for using all 32bits for approx distance

Bug:757146
Change-Id: If783f1b36fc70c443d0808947275acf003a872ee
Reviewed-on: https://skia-review.googlesource.com/57109
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/c4b015ad5f3b85b0c77d01ce1ce042294a3dd362/src/core/SkScan_Hairline.cpp

Project Member

Comment 5 by ClusterFuzz, Oct 11 2017

ClusterFuzz has detected this issue as fixed in range 507658:507664.

Detailed report: https://clusterfuzz.com/testcase?key=6628061507485696

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  compute_quad_level
  void hair_path<
  SkDraw::drawDevPath
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=474010:474024
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=507658:507664

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6628061507485696

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Oct 11 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6628061507485696 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner

Sign in to add a comment