extensions::test_util (extensions/common/test_util.*) is a collection of simple wrappers around ExtensionBuilder. With a better ExtensionBuilder ( issue 756488 ), these methods are no longer necessary. We should remove them.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef4a7b209705e207d502fbaf0fc30d738590775b commit ef4a7b209705e207d502fbaf0fc30d738590775b Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Aug 21 20:23:58 2017 [Extensions] Replace test_util::BuildApp() test_util::BuildApp() is now equivalent to ExtensionBuilder("Test", ExtensionBuilder::Type::PLATFORM_APP). Remove one of our no-longer-necessary extension construction methods. TBR=apacible@chromium.org for mechanical change in media_router_ui_unittest.cc Bug: 757138 Change-Id: Ia03b0a393ed1cbc0453782e8cbb620835065ee31 Reviewed-on: https://chromium-review.googlesource.com/621853 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#496045} [modify] https://crrev.com/ef4a7b209705e207d502fbaf0fc30d738590775b/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc [modify] https://crrev.com/ef4a7b209705e207d502fbaf0fc30d738590775b/chrome/browser/extensions/api/file_system/consent_provider_unittest.cc [modify] https://crrev.com/ef4a7b209705e207d502fbaf0fc30d738590775b/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc [modify] https://crrev.com/ef4a7b209705e207d502fbaf0fc30d738590775b/extensions/common/test_util.cc [modify] https://crrev.com/ef4a7b209705e207d502fbaf0fc30d738590775b/extensions/common/test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c89373f804e80e7309b5f8e47b8f6c3260123d02 commit c89373f804e80e7309b5f8e47b8f6c3260123d02 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Aug 21 22:08:33 2017 [Extensions] Replace test_util::CreateEmptyExtension test_util::CreateEmptyExtension() is now equivalent to ExtensionBuilder("Test").Build(). Remove one of our no-longer-necessary extension construction methods. Bug: 757138 Change-Id: I239e9a0788ebd8a490e1219a9d1faa8ee4b71881 Reviewed-on: https://chromium-review.googlesource.com/620248 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#496079} [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/activity_log/activity_log_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/browser/browser_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/file_system/consent_provider_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/identity/identity_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/management/management_api_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/notifications/notifications_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/tabs/tabs_api_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/tabs/tabs_interactive_test.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/tabs/tabs_test.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/extensions/extension_action_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/chrome/browser/media/router/mojo/media_router_mojo_test.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/browser/api/bluetooth/bluetooth_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/browser/api/cast_channel/cast_channel_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/browser/api/dns/dns_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/browser/api/socket/socket_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/browser/api/sockets_udp/sockets_udp_apitest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/browser/api/system_network/system_network_api_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/browser/runtime_data_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/common/test_util.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/common/test_util.h [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/renderer/api_activity_logger_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/shell/browser/root_window_controller_unittest.cc [modify] https://crrev.com/c89373f804e80e7309b5f8e47b8f6c3260123d02/extensions/shell/browser/shell_desktop_controller_aura_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad578c5727f15d96f8d05a36b3cd9379cf352136 commit ad578c5727f15d96f8d05a36b3cd9379cf352136 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Aug 21 23:32:12 2017 [Extensions] Replace test_util::BuildExtension() test_util::BuildExtension() is now equivalent to ExtensionBuilder("Test"). Remove one of our no-longer-necessary extension construction methods. Bug: 757138 Change-Id: I69bebd7e25b851e7c0a19e1b53e7da6e44147ae1 Reviewed-on: https://chromium-review.googlesource.com/621234 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#496116} [modify] https://crrev.com/ad578c5727f15d96f8d05a36b3cd9379cf352136/chrome/browser/extensions/permission_messages_unittest.cc [modify] https://crrev.com/ad578c5727f15d96f8d05a36b3cd9379cf352136/chrome/common/extensions/api/common_extension_api_unittest.cc [modify] https://crrev.com/ad578c5727f15d96f8d05a36b3cd9379cf352136/extensions/browser/updater/update_service_unittest.cc [modify] https://crrev.com/ad578c5727f15d96f8d05a36b3cd9379cf352136/extensions/common/test_util.cc [modify] https://crrev.com/ad578c5727f15d96f8d05a36b3cd9379cf352136/extensions/common/test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/322031ea3956b9e32face8cc012db9347c78ac4b commit 322031ea3956b9e32face8cc012db9347c78ac4b Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Aug 25 02:00:08 2017 [Extensions] Replace test_util::CreateEmptyExtension(<id>) test_util::CreateEmptyExtension(<id>) is now equivalent to ExtensionBuilder("Test").SetId(<id>.Build(). Remove one of our no-longer-necessary extension construction methods. Additionally, in the cases where the id provided was not a valid extension id (i.e., doesn't match the regex [a-p]{32}), and the id was not explicitly used, prefer to use a unique name (which ensures a unique id) and a generated id, which will be valid. TBR=dpapad@chromium.org (trivial webui change) Bug: 757138 Change-Id: Id02602b1ae3c8706fa0917dcc90dc89bea27e206 Reviewed-on: https://chromium-review.googlesource.com/622351 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#497298} [modify] https://crrev.com/322031ea3956b9e32face8cc012db9347c78ac4b/chrome/browser/extensions/activity_log/activity_log_unittest.cc [modify] https://crrev.com/322031ea3956b9e32face8cc012db9347c78ac4b/chrome/browser/extensions/api/identity/identity_apitest.cc [modify] https://crrev.com/322031ea3956b9e32face8cc012db9347c78ac4b/chrome/browser/ui/toolbar/toolbar_model_unittest.cc [modify] https://crrev.com/322031ea3956b9e32face8cc012db9347c78ac4b/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc [modify] https://crrev.com/322031ea3956b9e32face8cc012db9347c78ac4b/extensions/browser/api/api_resource_manager_unittest.cc [modify] https://crrev.com/322031ea3956b9e32face8cc012db9347c78ac4b/extensions/browser/api/power/power_api_unittest.cc [modify] https://crrev.com/322031ea3956b9e32face8cc012db9347c78ac4b/extensions/browser/event_router_unittest.cc [modify] https://crrev.com/322031ea3956b9e32face8cc012db9347c78ac4b/extensions/browser/extension_registry_unittest.cc [modify] https://crrev.com/322031ea3956b9e32face8cc012db9347c78ac4b/extensions/common/test_util.cc [modify] https://crrev.com/322031ea3956b9e32face8cc012db9347c78ac4b/extensions/common/test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75dc783ace34d617e938cadc4ec55e524d934927 commit 75dc783ace34d617e938cadc4ec55e524d934927 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Aug 25 19:18:10 2017 [Extensions][Cleanup] Remove extensions/common/test_util.* extensions/common/test_util.* are no longer necessary. Remove them completely. Bug: 757138 TBR=avi@chromium.org (removing unneeded include) TBR=apacible@chromium.org (removing unneeded include) Change-Id: I5651cdc998e09b5149e22ce4eeb0615547ded0c9 Reviewed-on: https://chromium-review.googlesource.com/634487 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#497486} [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/chrome/browser/extensions/activity_log/activity_log_unittest.cc [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/chrome/browser/extensions/api/file_system/consent_provider_unittest.cc [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/chrome/browser/extensions/api/identity/identity_apitest.cc [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/chrome/browser/extensions/api/management/management_api_browsertest.cc [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/chrome/common/extensions/extension_test_util.h [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/extensions/BUILD.gn [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/extensions/browser/api/storage/storage_api_unittest.cc [modify] https://crrev.com/75dc783ace34d617e938cadc4ec55e524d934927/extensions/common/manifest_test.cc [delete] https://crrev.com/01a170a8595c9ffd7ad144a02a7748db4313ecec/extensions/common/test_util.cc [delete] https://crrev.com/01a170a8595c9ffd7ad144a02a7748db4313ecec/extensions/common/test_util.h
Comment 1 by bugdroid1@chromium.org
, Aug 21 2017