New issue
Advanced search Search tips

Issue 757110 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cherry pick commits aren't properly identified

Project Member Reported by s...@chromium.org, Aug 18 2017

Issue description

Of these three commits by me which are all merges to release branches

https://chromiumdash-staging.googleplex.com/commit/ec2a6b24c7b356aa35cbe950a49bf4cd7f1909bb
https://chromiumdash-staging.googleplex.com/commit/ba7379dd20bddc606d96c7ecb96fca4fcde34d94
https://chromiumdash-staging.googleplex.com/commit/9d5317aed8162655e22f2e793f47ec052007a534

They all seem to be treated differently when looking at all commits for skym@chromium.org. The first shows up with no icon, the second show up with a tiny green icon (merge?). And the third isn't listed at all. Seems like they should all behave like the second one does?

Btw that little green and red icons are really helpful for quickly getting information at a glance, love them!
 
Labels: Dashboard-Polish
Summary: Cherry pick commits aren't properly identified (was: Chromium Dash Feedback - Merged changes don't always show up?)
Sorry to take so long to reply here - updating title a bit to match other bugs.

We actually spent some time on this after your report and we think it's due to us failing to parse the commit message for the parent hash properly, so it doesn't think these are cherry-picks.  We'll try to get this fixed when we have a chance, likely by copying Gerrit's algorithm (which appears to have correctly parsed and found related commits).
Status: Available (was: Untriaged)

Sign in to add a comment