Zeroconf printers not showing up |
|||||||
Issue descriptionWe are looking at service_name where we should be looking at service_type.
,
Aug 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/172c6a15317aaff4f84455e8a7b634d23c26cf24 commit 172c6a15317aaff4f84455e8a7b634d23c26cf24 Author: Justin Carlson <justincarlson@chromium.org> Date: Sat Aug 19 01:03:49 2017 Fix several Zeroconf bugs. * Use service_type instead of service_name to determine...the service type. * Don't dereference a map iterator at end() * Completely initialize CupsPrintersManager before starting callbacks * Bug: 757091 Change-Id: I7a63962046ae9a8376439cf181b9edc729163589 Reviewed-on: https://chromium-review.googlesource.com/622167 Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: Justin Carlson <justincarlson@chromium.org> Cr-Commit-Position: refs/heads/master@{#495775} [modify] https://crrev.com/172c6a15317aaff4f84455e8a7b634d23c26cf24/chrome/browser/chromeos/printing/cups_printers_manager.cc [modify] https://crrev.com/172c6a15317aaff4f84455e8a7b634d23c26cf24/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc
,
Aug 21 2017
Zeroconf printers are showing up now.
,
Aug 22 2017
,
Aug 22 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 22 2017
Approving merge to M61 Chrome OS.
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/744da547a43a3c0d79a33762a513949122596600 commit 744da547a43a3c0d79a33762a513949122596600 Author: Sean Kau <skau@chromium.org> Date: Tue Aug 22 19:40:00 2017 Fix several Zeroconf bugs. * Use service_type instead of service_name to determine...the service type. * Don't dereference a map iterator at end() * Completely initialize CupsPrintersManager before starting callbacks * TBR=justincarlson@chromium.org (cherry picked from commit 172c6a15317aaff4f84455e8a7b634d23c26cf24) Bug: 757091 Change-Id: I7a63962046ae9a8376439cf181b9edc729163589 Reviewed-on: https://chromium-review.googlesource.com/622167 Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: Justin Carlson <justincarlson@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#495775} Reviewed-on: https://chromium-review.googlesource.com/627276 Cr-Commit-Position: refs/branch-heads/3163@{#768} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/744da547a43a3c0d79a33762a513949122596600/chrome/browser/chromeos/printing/cups_printers_manager.cc [modify] https://crrev.com/744da547a43a3c0d79a33762a513949122596600/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by skau@chromium.org
, Aug 18 2017