New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757091 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Zeroconf printers not showing up

Project Member Reported by justincarlson@chromium.org, Aug 18 2017

Issue description

We are looking at service_name where we should be looking at service_type.
 

Comment 1 by skau@chromium.org, Aug 18 2017

Tracking internally with linked feedback report
http://b/64849248
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/172c6a15317aaff4f84455e8a7b634d23c26cf24

commit 172c6a15317aaff4f84455e8a7b634d23c26cf24
Author: Justin Carlson <justincarlson@chromium.org>
Date: Sat Aug 19 01:03:49 2017

Fix several Zeroconf bugs.

* Use service_type instead of service_name to determine...the service type.
* Don't dereference a map iterator at end()
* Completely initialize CupsPrintersManager before starting
  callbacks
* 

Bug:  757091 
Change-Id: I7a63962046ae9a8376439cf181b9edc729163589
Reviewed-on: https://chromium-review.googlesource.com/622167
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495775}
[modify] https://crrev.com/172c6a15317aaff4f84455e8a7b634d23c26cf24/chrome/browser/chromeos/printing/cups_printers_manager.cc
[modify] https://crrev.com/172c6a15317aaff4f84455e8a7b634d23c26cf24/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc

Comment 3 by skau@chromium.org, Aug 21 2017

Status: Fixed (was: Assigned)
Zeroconf printers are showing up now.

Comment 4 by skau@chromium.org, Aug 22 2017

Labels: M-61 Merge-Request-61
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 22 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/744da547a43a3c0d79a33762a513949122596600

commit 744da547a43a3c0d79a33762a513949122596600
Author: Sean Kau <skau@chromium.org>
Date: Tue Aug 22 19:40:00 2017

Fix several Zeroconf bugs.

* Use service_type instead of service_name to determine...the service type.
* Don't dereference a map iterator at end()
* Completely initialize CupsPrintersManager before starting
  callbacks
*

TBR=justincarlson@chromium.org

(cherry picked from commit 172c6a15317aaff4f84455e8a7b634d23c26cf24)

Bug:  757091 
Change-Id: I7a63962046ae9a8376439cf181b9edc729163589
Reviewed-on: https://chromium-review.googlesource.com/622167
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495775}
Reviewed-on: https://chromium-review.googlesource.com/627276
Cr-Commit-Position: refs/branch-heads/3163@{#768}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/744da547a43a3c0d79a33762a513949122596600/chrome/browser/chromeos/printing/cups_printers_manager.cc
[modify] https://crrev.com/744da547a43a3c0d79a33762a513949122596600/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment