New issue
Advanced search Search tips

Issue 757090 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 732609



Sign in to add a comment

[SPv2] Movement of root layer position caused by negative content position

Project Member Reported by wangxianzhu@chromium.org, Aug 18 2017

Issue description

For example, paint/invalidation/abspos-shift-image-incorrect-repaint.html moves a child to negative position, causing the root layer to expand to negative position to enclose the child. This causes full invalidation of the layer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70cc1dad4ad07c507895e6b22995ee54faed8ffd

commit 70cc1dad4ad07c507895e6b22995ee54faed8ffd
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Sep 28 06:19:43 2017

[SPv2] Clip composited layer bounds

1. Clip the layer bounds with the direct clip in the layer's property
   tree state if the clip is in the space of the transform in property
   tree state.
2. Clip the layer bounds with the scrolling range if the transform
   in the layer's property tree state references a scroll node.

This helps:
- to reduce layer bounds by excluding the areas that are not visible
  (while still allowing composited scrolling);
- to avoid full layer raster invalidation when layer bounds change
  outside of the visible area.

Bug:  757090 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If56cebe6e3235613bacef388f04f01c42abfdaec
Reviewed-on: https://chromium-review.googlesource.com/683249
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504923}
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/layer-creation/fixed-position-nonscrollable-body-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/layer-creation/fixed-position-nonscrollable-body-overlap-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/absolute-position-change-containing-block-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/absolute-position-moved-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/border-radius-repaint-2-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/inline-focus-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/inline-outline-repaint-2-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/mask-clip-change-stacking-child-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline-change-in-scrollers-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline-change-scrollable-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline-change-vertical-rl-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow-flipped-writing-mode-block-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow-flipped-writing-mode-table-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow-hide-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow-show-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/scroll-in-clipped-layer-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/scroll-in-transformed-layer-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/scroll-with-transformed-parent-layer-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/add-outline-property-on-root-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/remove-outline-property-on-root-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/transform-replaced-shadows-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/transform-rotate-and-remove-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize-no-layout-change1-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize-no-layout-change2-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/paint/invalidation/outline-change-in-scrollers-expected.html
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/paint/invalidation/outline-change-in-scrollers-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/paint/invalidation/outline-change-in-scrollers.html
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/paint/invalidation/outline-change-scrollable-expected.html
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/paint/invalidation/outline-change-scrollable-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/paint/invalidation/outline-change-scrollable.html
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/paint/invalidation/outline-change-vertical-rl-expected.html
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/paint/invalidation/outline-change-vertical-rl-expected.txt
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/paint/invalidation/outline-change-vertical-rl.html
[add] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/outline-change-in-scrollers-expected.txt
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/core/paint/BlockPainterTest.cpp
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.cpp
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp
[modify] https://crrev.com/70cc1dad4ad07c507895e6b22995ee54faed8ffd/third_party/WebKit/Source/platform/testing/TestPaintArtifact.h

Status: Fixed (was: Assigned)

Sign in to add a comment