New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757069 link

Starred by 28 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Hotlist-1
Hotlist-2


Sign in to add a comment

Wacom Stylus - mouse event not fire correctly after leave&re-enter with stylus

Project Member Reported by girard@chromium.org, Aug 18 2017

Issue description

Wacom Intuos 4 (PTK-640 A4 size) on macOS Sierra 10.12.6, Chrome Version 60.0.3112.101 (Official Build) (64-bit).

On macOS it started with Chrome 60. Some buttons like the Gmail buttons on mail.google.com (archive, delete, …) don't receive a click event. The button gets the blue highlight around it but never receives a click event.

Same thing happens with the tabs in the Chrome developer tools (Network, Performance, …).

The issue is a bit more complicated. To have Wacom Intuos Pen clicks registered by Google Chrome, the first click in a browser tab has to come from a second device like the magic mouse or a trackpad. After the first click, the Wacom tablet clicks are also registered. This is true for each separate browser tab. Very odd.

[Originally comment appeared in https://bugs.chromium.org/p/chromium/issues/detail?id=738357#c22]

 
Confirm, broke as of Chrome 60 on Mac OSX

Mac OSX (Yosemite 10.10.5)
WACOM Bamboo CRH-670, touch disabled

First noticed on Aug 15, 2017 with Chrome update 60.0.3112.90 (Official Build) (64-bit), did not have any issue before then.

Concur, does appear to start working again if you click with the trackpad and then go back to using pen (both clicking and drag and drop) however, it does appear to be inconsistent (sometimes clicks will start working again, other times not).
 Issue 755831  has been merged into this issue.

Comment 3 by lgrey@chromium.org, Aug 22 2017

Components: Blink>Input

Comment 4 by adw...@gmail.com, Aug 22 2017

Also confirmed.
Chrome Version 60.0.3112.101 (Official Build) (64-bit)
Mac OS Sierra 10.12.5
Wacom Intuos 3 using latest drivers.

This bug renders Chrome unusable for graphics tablet users.

Issue effecting many webpages, most Chrome Apps including Google Keep, Google Sheets, the Gmail website, and Chrome Developer Tools.

When page/app is first loaded/refreshed the problem does not occur. Problem often begins occurring after changing window focus, or after a short (indeterminate) period of time.

Identified the issue as mouse events not registering as can be seen in the attached - first two clicks register both 'pointerdown/pointerup' and 'mousedown/mouseup' events, but the third click only registers 'pointerdown/pointerup' events.

A similar problem occurred on Windows with Chrome version 55. Users temporarily fixed the issue by disabling 'Windows Ink' setting (mentioned in OPs linked report https://bugs.chromium.org/p/chromium/issues/detail?id=738357) Cannot find relevant bug reports, but see following Chrome Help Forum posts:
https://productforums.google.com/forum/#!topic/chrome/qAGMbbcomrM
https://productforums.google.com/forum/#!topic/chrome/kXSsQWNXfxA

May be related to an issue with Wacom input not registering in flash content in Chrome 55, fixed in Chrome 56: https://bugs.chromium.org/p/chromium/issues/detail?id=675410

I believe this is NOT related to the pressure-sensitivity issue due to discontinuing NPAPI support: https://bugs.chromium.org/p/chromium/issues/detail?id=344181
thing2.jpg
142 KB View Download
Cc: nzolghadr@chromium.org
Owner: eirage@chromium.org
Status: Assigned (was: Untriaged)
Labels: Hotlist-Input-Dev

Comment 7 by thex...@gmail.com, Aug 24 2017

This doesn't only affect Chrome, but all the latest Electron/Chromium powered apps I'm using as well, Atom, VS Code, etc..

macOS Version 10.12.4
Chrome Version 60.0.3112.101 (Official Build) (64-bit)
Wacom Intuos PT S Latest Driver Version 6.3.23-4
VS Code Version 1.15.1
Labels: -Type-Bug -Pri-3 M-60 Hotlist-Enterprise Pri-2 Type-Bug-Regression
Also happening with Wacom Intuos5 touch M on Mac on 60.0.3112.101

Logfiles: https://drive.google.com/open?id=0B-g52zibXA02anUyejlPMlVaTjg
Video: https://drive.google.com/open?id=0B-g52zibXA02UmhWOU9tNmNSenc

Eirage can you please help to triage?
Cc: marcore@google.com marchuk@google.com
Summary: Wacom Stylus - mouse event not fire correctly after leave&re-enter with stylus (was: Wacom Stylus - buttons unclickable until app gets focus)
Thanks Marchluk, I am working on this right now. 
Issue 756299 has been merged into this issue.
Cc: eirage@chromium.org
 Issue 757214  has been merged into this issue.
Same for me. Are there any chance to disable pen-mode in chrome for now? 
No this is just a bug in handling the primary pointer id for pen. We hope to have a fix in the code base today. That would appear in the Chrome Canary channel next week and we might be able to merge it into the build for Chrome 61. But you are out of luck for Chrome 60.
Ok thanks. I'll just have to dig out and use a mouse for a couple of weeks then. Have a nice weekend! 
 Issue 757216  has been merged into this issue.
 Issue 748960  has been merged into this issue.
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6038027e89747913716cf298c822f70f67444812

commit 6038027e89747913716cf298c822f70f67444812
Author: Ella Ge <eirage@chromium.org>
Date: Fri Aug 25 17:59:27 2017

Set pointer id to 0 for mouse event in mac .

In this patch, we disable support for multi-pen on mac.
Set WebMouseEvent id to 0 before the return of event with type
NSMouseExited or NSMouseEntered to make all the event 
have the id set. 
In trybot(mac10.9), NSMouseExited and NSMouseEntered don't have 
[event deviceID]. (Although in my machine 10.12, they have it).

Also, re-enable drag by pen on mac. pen dragging should only disable
on windows.

Bug:  757069 
Change-Id: I44d0021f749151bf8f76e89019bb5b5edf74957c
Reviewed-on: https://chromium-review.googlesource.com/633356
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497463}
[modify] https://crrev.com/6038027e89747913716cf298c822f70f67444812/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[modify] https://crrev.com/6038027e89747913716cf298c822f70f67444812/third_party/WebKit/Source/core/input/MouseEventManager.cpp

Status: Fixed (was: Assigned)
eirage@ please test on Canary on Mac and verify it is working correctly then request merge to M61.
Labels: Merge-Request-61
Test on canary version 62.0.3197.0
Project Member

Comment 23 by sheriffbot@chromium.org, Aug 28 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 7 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Before we approve merge to M61, please answer followings:
* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M61? 
* Is this change only applicable to Mac or can have impact on any other OSs?
* Any other important details to justify the merge.


Please note M61 Stable promotion is coming VERY soon, so merge bar is very high. Thank you.


I tested the fix in Canary version 62.0.3197.0. The issue is fixed in Canary.

The primary pointer problem only apply to Mac and should only apply to stylus. 
And I also re-enable handle drag for stylus on not windows OS. It was disabled because a windows bug:  crbug.com/724836 , and dragging should only be disabled on windows. So it should be safe to re-enable on other OS. This also only apply to stylus. 
 
ChromeOps flagged the stylus issues on Mac as one of the top issues gaining traction on Mac so we'd like it in for 61.
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 branch 3163 based on comment #25, #26 and per chat with  eirage@, this should be a safe merge.
Project Member

Comment 28 by bugdroid1@chromium.org, Aug 28 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b769908f060eca5d42107f65db395bcf26171846

commit b769908f060eca5d42107f65db395bcf26171846
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Aug 28 15:40:35 2017

Set pointer id to 0 for mouse event in mac .

In this patch, we disable support for multi-pen on mac.
Set WebMouseEvent id to 0 before the return of event with type
NSMouseExited or NSMouseEntered to make all the event
have the id set.
In trybot(mac10.9), NSMouseExited and NSMouseEntered don't have
[event deviceID]. (Although in my machine 10.12, they have it).

Also, re-enable drag by pen on mac. pen dragging should only disable
on windows.

TBR=dtapuska@chromium.org

(cherry picked from commit 6038027e89747913716cf298c822f70f67444812)

Bug:  757069 
Change-Id: I44d0021f749151bf8f76e89019bb5b5edf74957c
Reviewed-on: https://chromium-review.googlesource.com/633356
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497463}
Reviewed-on: https://chromium-review.googlesource.com/638531
Cr-Commit-Position: refs/branch-heads/3163@{#926}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/b769908f060eca5d42107f65db395bcf26171846/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[modify] https://crrev.com/b769908f060eca5d42107f65db395bcf26171846/third_party/WebKit/Source/core/input/MouseEventManager.cpp

 Issue 759151  has been merged into this issue.
Tried Version 62.0.3199.0 canary right now and I confirm mouse dragging is back to normal behavior on MacOS, AND it *MIGHT* have solved the other ugly issues around mousedown being skipped with pen, as described in my post here:
https://productforums.google.com/forum/#!msg/chrome/YGtk9DhgTLk/dgm6N7UHEQAJ

(this last issue solved is to be confirmed as it's a nasty bug not always showing up)

Thanks anyway.
Cc: pbhattacherjea@google.com
Just tried Google Chrome Beta Version 61.0.3163.71 (Official Build) beta (64-bit) on macOS 10.12.6.

Now the middle click for opening links in background tabs is broken.

If you click very fast and multiple times with an assigned middle click button the event triggers otherwise the action is ignored.
#32, Thanks. I create a new entry for the middle click issue  crbug.com/762095 
Issue 760548 has been merged into this issue.

Sign in to add a comment