New issue
Advanced search Search tips

Issue 757057 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Add a CQ flag in CL description to disable equivalent builders

Project Member Reported by no...@chromium.org, Aug 18 2017

Issue description

If a builder temporarily fails on LUCI, but LUCI dogfooders still need to land CLs, they can do one of the following

1) use "No-Try: true" in CL, but that disables testing for the CL all together
2) remove them from the dogfood list on CIA, but that means then have to be notified that LUCI works again somehow, so they add themselves back. What if they forget?

It would be great to opt-out from LUCI at the CL level, e.g. "No-Equivalent-Builders: true" in CL description.

Andrii, how hard it is to implement? Please triage.
 

Comment 1 by no...@chromium.org, Aug 18 2017

Cc: efoo@chromium.org
efoo@, we may want to have this before open beta
EstimatedDays: 1
Owner: tandrii@chromium.org
Status: Started (was: Untriaged)
Good idea. This took only 15 minutes: https://chrome-internal-review.googlesource.com/c/435092, I can deploy it tomorrow.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/f9e97bda0c2d04fd0cc34e18312022fa33dbd54e

commit f9e97bda0c2d04fd0cc34e18312022fa33dbd54e
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Aug 21 07:44:12 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/7002f99e5d6e99db034b4264e7265857a3fb00f3

commit 7002f99e5d6e99db034b4264e7265857a3fb00f3
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Aug 21 11:20:21 2017

Status: Verified (was: Started)
End-2-end test completed: https://chromium-review.googlesource.com/c/541299

Comment 6 by no...@chromium.org, Aug 21 2017

Cc: dpranke@chromium.org jbudorick@chromium.org
please announce No-Equivalent-Builders flag on luci-eng and cc dogfooders. Thanks!
Nice, thanks!
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/064e4d20930d2c98e9e4819b86c3293d093a17dd

commit 064e4d20930d2c98e9e4819b86c3293d093a17dd
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Aug 22 20:43:21 2017

Sign in to add a comment