New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757044 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression


Participants' hotlists:
Fixing-touch


Sign in to add a comment

keyboard_unittests flaky on chromium.win/Win 7 Tests x64 (1)

Project Member Reported by cmumford@chromium.org, Aug 18 2017

Issue description

keyboard_unittests failing on chromium.win/Win 7 Tests x64 (1)

Builders failed on: 
- Win 7 Tests x64 (1): 
  https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29


NewAndOldBehavior/KeyboardControllerTest.KeyboardSizeMultiRootWindow

 RUN      ] NewAndOldBehavior/KeyboardControllerTest.KeyboardSizeMultiRootWindow/0
../../ui/keyboard/keyboard_controller_unittest.cc(392): error:       Expected: 1000
To be equal to: secondary_tree_host->window()->bounds().width()
      Which is: 838
[  FAILED  ] NewAndOldBehavior/KeyboardControllerTest.KeyboardSizeMultiRootWindow/0, where GetParam() = false (5 ms)
[ RUN      ] NewAndOldBehavior/KeyboardControllerTest.KeyboardSizeMultiRootWindow/0
../../ui/keyboard/keyboard_controller_unittest.cc(392): error:       Expected: 1000
To be equal to: secondary_tree_host->window()->bounds().width()
      Which is: 838
[  FAILED  ] NewAndOldBehavior/KeyboardControllerTest.KeyboardSizeMultiRootWindow/0, where GetParam() = false (7 ms)
[ RUN      ] NewAndOldBehavior/KeyboardControllerTest.KeyboardSizeMultiRootWindow/0
../../ui/keyboard/keyboard_controller_unittest.cc(392): error:       Expected: 1000
To be equal to: secondary_tree_host->window()->bounds().width()
      Which is: 838
[  FAILED  ] NewAndOldBehavior/KeyboardControllerTest.KeyboardSizeMultiRootWindow/0, where GetParam() = false (8 ms)
[ RUN      ] NewAndOldBehavior/KeyboardControllerTest.KeyboardSizeMultiRootWindow/0
../../ui/keyboard/keyboard_controller_unittest.cc(392): error:       Expected: 1000
To be equal to: secondary_tree_host->window()->bounds().width()
      Which is: 838
[  FAILED  ] NewAndOldBehavior/KeyboardControllerTest.KeyboardSizeMultiRootWindow/0, where GetParam() = false (8 ms)
 
Owner: oka@chromium.org
Status: Assigned (was: Available)
Oka-san, can you take a look at this?
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09521283ba53ee06035be8cfe3059917a9223fbe

commit 09521283ba53ee06035be8cfe3059917a9223fbe
Author: Trent Apted <tapted@chromium.org>
Date: Wed Aug 23 07:54:02 2017

Disable Flaky NewAndOldBehavior/KeyboardControllerTest.KeyboardSizeMultiRootWindow/* on Windows

TBR=oka@chromium.org

Bug:  757044 
Change-Id: I45a9da9ce9418fae0c5e197e60d1e8a70bfd2188
Reviewed-on: https://chromium-review.googlesource.com/627347
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496620}
[modify] https://crrev.com/09521283ba53ee06035be8cfe3059917a9223fbe/ui/keyboard/keyboard_controller_unittest.cc

Comment 5 by oka@chromium.org, Feb 20 2018

Status: WontFix (was: Assigned)
I think the test is not meaningful in windows, hence closing. Please reopen if windows actually rely on ui/keyboard/KeyboardController.

Sign in to add a comment