New issue
Advanced search Search tips

Issue 757036 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Tests flaky on macOS: MoreDrawing, LessDrawingInSubsequence, & ChangeNonCacheableInSubsequence

Project Member Reported by cmumford@chromium.org, Aug 18 2017

Issue description

Correction LessDrawing -> MoreDrawing.
Summary: Tests flaky on macOS: MoreDrawing, LessDrawingInSubsequence, & ChangeNonCacheableInSubsequence (was: Tests flaky on macOS: LessDrawing, LessDrawingInSubsequence, & ChangeNonCacheableInSubsequence)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e56474e1d13c066acddeb930f36bccf122659dc0

commit e56474e1d13c066acddeb930f36bccf122659dc0
Author: Chris Mumford <cmumford@chromium.org>
Date: Fri Aug 18 21:48:28 2017

Disabled three flaky tests in PaintControllerUnderInvalidationTest.

TBR=chrishtr@chromium.org

Bug:  757036 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic86d59da3c8598012cbe57b8e3468ef4145f9768
Reviewed-on: https://chromium-review.googlesource.com/621867
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495699}
[modify] https://crrev.com/e56474e1d13c066acddeb930f36bccf122659dc0/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp

Comment 4 by pdr@chromium.org, Aug 18 2017

Components: Blink>Paint
Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
These appear to be timeouts? I wonder if there's a crash hiding in there.
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
Labels: BugSource-Chromium PaintTeamTriaged0-20170818
Status: Fixed (was: Assigned)
Reenable death tests on Mac

Added testing::FLAGS_gtest_death_test_style = "threadsafe" to avoid
flakiness and gtest warnings like:
../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use
fork(), which is unsafe particularly in a threaded context. For this
test, Google Test detected 5 threads.

References:
Gtest documentation about the flag:
https://cs.chromium.org/chromium/src/third_party/googletest/src/googletest/docs/AdvancedGuide.md?q=FLAGS_gtest_death_test_style&sq=package:chromium&l=731&dr=C
Other usages of the flag in current code:
https://cs.chromium.org/search/?q=FLAGS_gtest_death_test_style&sq=package:chromium&type=cs

BUG= 757036 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9fbbc2b34a22ca83c812168597694340a415861a
Reviewed-on: https://chromium-review.googlesource.com/630240
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497146}
Labels: -PaintTeamTriaged0-20170818 PaintTeamTriaged-20170818

Sign in to add a comment