Tests flaky on macOS: MoreDrawing, LessDrawingInSubsequence, & ChangeNonCacheableInSubsequence |
|||||||
Issue description
,
Aug 18 2017
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e56474e1d13c066acddeb930f36bccf122659dc0 commit e56474e1d13c066acddeb930f36bccf122659dc0 Author: Chris Mumford <cmumford@chromium.org> Date: Fri Aug 18 21:48:28 2017 Disabled three flaky tests in PaintControllerUnderInvalidationTest. TBR=chrishtr@chromium.org Bug: 757036 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic86d59da3c8598012cbe57b8e3468ef4145f9768 Reviewed-on: https://chromium-review.googlesource.com/621867 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#495699} [modify] https://crrev.com/e56474e1d13c066acddeb930f36bccf122659dc0/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
,
Aug 18 2017
These appear to be timeouts? I wonder if there's a crash hiding in there.
,
Aug 21 2017
,
Aug 22 2017
,
Aug 24 2017
Reenable death tests on Mac Added testing::FLAGS_gtest_death_test_style = "threadsafe" to avoid flakiness and gtest warnings like: ../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 5 threads. References: Gtest documentation about the flag: https://cs.chromium.org/chromium/src/third_party/googletest/src/googletest/docs/AdvancedGuide.md?q=FLAGS_gtest_death_test_style&sq=package:chromium&l=731&dr=C Other usages of the flag in current code: https://cs.chromium.org/search/?q=FLAGS_gtest_death_test_style&sq=package:chromium&type=cs BUG= 757036 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9fbbc2b34a22ca83c812168597694340a415861a Reviewed-on: https://chromium-review.googlesource.com/630240 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#497146}
,
Sep 6 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by cmumford@chromium.org
, Aug 18 2017